From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92087 invoked by alias); 5 Jun 2017 13:49:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90238 invoked by uid 89); 5 Jun 2017 13:49:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1113 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Jun 2017 13:49:10 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C02C2C0587CD; Mon, 5 Jun 2017 13:49:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C02C2C0587CD Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com C02C2C0587CD Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2001E81960; Mon, 5 Jun 2017 13:49:12 +0000 (UTC) Subject: Re: [RFA 19/23] Replace do_restore_instream_cleanup with scoped_restore To: Tom Tromey , gdb-patches@sourceware.org References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-20-tom@tromey.com> From: Pedro Alves Message-ID: Date: Mon, 05 Jun 2017 13:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170503224626.2818-20-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00117.txt.bz2 On 05/03/2017 11:46 PM, Tom Tromey wrote: > This changes the users of do_restore_instream_cleanup to use a > scoped_restore instead. This patch is broken out because it warrants > some additional attention: in particular it's unclear to me whether > current_ui can change in the body of these functions -- but if it can, > then the cleanup would have modified a different UI's instream member. > The only places that change the current UI without restoring it back are the top level event loop code that reacts to stdin input and signal handlers (stdin_event_handler / invoke_async_signal_handlers). Everything else that temporarily switches UI switches back before returning, using scoped_restore. (This includes nested even loops like wait_sync_command_done.) > 2017-05-02 Tom Tromey > > * top.h (do_restore_instream_cleanup): Remove. > * top.c (do_restore_instream_cleanup): Remove. > (read_command_file): Use scoped_restore. > * cli/cli-script.c (execute_user_command): Use scoped_restore. OK. Thanks, Pedro Alves