From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 3AF103858010 for ; Mon, 23 May 2022 11:26:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3AF103858010 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6A3761F8CF; Mon, 23 May 2022 11:26:11 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 432D1139F5; Mon, 23 May 2022 11:26:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9kfsDlNvi2KpHgAAMHmgww (envelope-from ); Mon, 23 May 2022 11:26:11 +0000 Message-ID: Date: Mon, 23 May 2022 13:26:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH][gdb/testsuite] Fix printing of 0x10000000000000000 Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org Cc: Tom Tromey , Pedro Alves References: <20220518122555.GA24256@delia> <87v8u1icjk.fsf@redhat.com> From: Tom de Vries In-Reply-To: <87v8u1icjk.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 May 2022 11:26:13 -0000 On 5/19/22 20:48, Andrew Burgess wrote: > Maybe you're working on modula-2 right now, in which case, ignore this. > But, if you're not, then it might be better to raise a bug for the > module-2 issues - even if it's just "parse_number needs a rewrite", and > then use setup_xfail here instead of continue. > I filed: - https://sourceware.org/bugzilla/show_bug.cgi?id=29163 "[gdb/m2] parse_number needs rewrite" listing two UB errors. And then submitted this ( https://sourceware.org/pipermail/gdb-patches/2022-May/189313.html ) to fix those. > But otherwise, this all looks OK to me. Thanks for the review. I've now resubmitted in a slightly different format: - one patch to increase test coverage in gdb.base/parse_number.exp - patches for each language to address all exposes issues. I'm hoping that the per-language patches will be easier to review. Thanks, - Tom