From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id 037793858D33 for ; Thu, 16 Feb 2023 10:52:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 037793858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f53.google.com with SMTP id by3so1401591wrb.10 for ; Thu, 16 Feb 2023 02:52:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:cc:to:from:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bYugrF3zYYg4qqQZq/VW1BYoRVk6otHZm3OR9QUXiDI=; b=bW0Nuss/HQhbcnF2dlJDMEqyui3+A+pplc3hiQM0dtRf3kmVj+VKNXJZ+a/NlogcgN xVigW+R2zQCdFNBqP1lRRopIBwO4SbtfOsAXLVgJdAZxE+g8/tST2PN4ifhdSwZgUbaW mMxEN8Ubk3VIC+EpggRLzY8a2R8+yXPpnyLXvICQedOmrnxziIN02JkdoaxydlKFVcYI RY3Vmd7tmSGwTvP+PLam0RwaX4iPjm6Ts9ott6DSA7bw5o8Ipbi6UVzniZPwRBNJEZYG Jn/LN1k83qarQygIpIsyJpGG9AdjUjS1tbb2pxIMxzJ4ESnAUHfNDPelSdnwb2YTQzpH lCZg== X-Gm-Message-State: AO0yUKUJSVROI5lFeKvHIlyIqqrsrtKwvcHuh/epGs8oZ5TQSZv5o/yn VOlV8ze1A/csr4hL8G0MgAs+Ah7wUAf3+w== X-Google-Smtp-Source: AK7set+wAEJsOKQXrEV37Q9u5xrtKUjSN3NjZJ13EJkzlwqEftJEJxX8EX1rYObWeeowYGmQ5WISjQ== X-Received: by 2002:a5d:594f:0:b0:2c4:67b:36b7 with SMTP id e15-20020a5d594f000000b002c4067b36b7mr4456727wri.54.1676544747813; Thu, 16 Feb 2023 02:52:27 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id c1-20020adfe701000000b002c5526234d2sm1212278wrm.8.2023.02.16.02.52.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 02:52:27 -0800 (PST) Subject: Re: [PATCH v4 3/8] Catch gdb_exception_error instead of gdb_exception (in many places) From: Pedro Alves To: Kevin Buettner , gdb-patches@sourceware.org Cc: simark@simark.ca, tdevries@suse.de References: <20230112015630.32999-1-kevinb@redhat.com> <20230112015630.32999-4-kevinb@redhat.com> Message-ID: Date: Thu, 16 Feb 2023 10:52:25 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kevin, On 2023-01-30 7:00 p.m., Pedro Alves wrote: > Hi Kevin, > > This patch took me a bit to convince myself is good as is. See below why. ... > So I'm thinking that we should probably install a custom quit_handler while inside > fetch_inferior_event, like we disable pagination and other things, one that just does nothing, > or at least, does nothing until the user to tries ctrl-c a number of times before querying the > user what to do, in case GDB really gets stuck. > > And if we agree with that direction, then I guess my concern about making all these try/catch that can > be run during run control, the ones in infrun.c, breakpoint.c, etc., escape gdb_exception_quit mostly > goes away. > > So I think with that direction this patch is OK. > Just wanted to explicitly state that changes implementing the above are all in master now, since yesterday.