public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Find arm-linux-gnueabihf-gcc in compile
Date: Thu, 18 Jan 2018 15:35:00 -0000	[thread overview]
Message-ID: <f2d81fc5964169d2bfb8bb222f0c38c8@polymtl.ca> (raw)
In-Reply-To: <1516265199-29059-1-git-send-email-yao.qi@linaro.org>

On 2018-01-18 03:46, Yao Qi wrote:
> GCC for arm-linux has different names on different distros.  It is
> arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has 
> arm-linux-gnueabihf-gcc.
> So when I run gdb.compile/ tests on arm-linux, I get,
> 
> (gdb) compile code -- ;
> Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"
> 
> This patch extend the regexp to match both arm-linux-gnu-gcc and
> arm-linux-gnueabihf-gcc.
> 
> gdb:
> 
> 2018-01-17  Yao Qi  <yao.qi@linaro.org>
> 
> 	* osabi.c (gdb_osabi_names): Extend the regexp for
> 	arm-linux-gnueabihf.
> ---
>  gdb/osabi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/osabi.c b/gdb/osabi.c
> index 129164f..fd44deb 100644
> --- a/gdb/osabi.c
> +++ b/gdb/osabi.c
> @@ -63,7 +63,7 @@ static const struct osabi_names gdb_osabi_names[] =
>    { "SVR4", NULL },
>    { "GNU/Hurd", NULL },
>    { "Solaris", NULL },
> -  { "GNU/Linux", "linux(-gnu)?" },
> +  { "GNU/Linux", "linux(-gnu[^-]*)?" },
>    { "FreeBSD", NULL },
>    { "NetBSD", NULL },
>    { "OpenBSD", NULL },

That seem reasonable to me.

Simon

  reply	other threads:[~2018-01-18 15:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18  8:46 Yao Qi
2018-01-18 15:35 ` Simon Marchi [this message]
2018-01-18 18:32 ` Pedro Alves
2018-01-19  9:12   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2d81fc5964169d2bfb8bb222f0c38c8@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).