[PATCH] Find arm-linux-gnueabihf-gcc in compile

[PATCH] Find arm-linux-gnueabihf-gcc in compile

[Yao Qi]

GCC for arm-linux has different names on different distros.  It is
arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has arm-linux-gnueabihf-gcc.
So when I run gdb.compile/ tests on arm-linux, I get,

(gdb) compile code -- ;
Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"

This patch extend the regexp to match both arm-linux-gnu-gcc and
arm-linux-gnueabihf-gcc.

gdb:

2018-01-17  Yao Qi  <yao.qi@linaro.org>

	* osabi.c (gdb_osabi_names): Extend the regexp for
	arm-linux-gnueabihf.
---
 gdb/osabi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/osabi.c b/gdb/osabi.c
index 129164f..fd44deb 100644
--- a/gdb/osabi.c
+++ b/gdb/osabi.c
@@ -63,7 +63,7 @@ static const struct osabi_names gdb_osabi_names[] =
   { "SVR4", NULL },
   { "GNU/Hurd", NULL },
   { "Solaris", NULL },
-  { "GNU/Linux", "linux(-gnu)?" },
+  { "GNU/Linux", "linux(-gnu[^-]*)?" },
   { "FreeBSD", NULL },
   { "NetBSD", NULL },
   { "OpenBSD", NULL },
-- 
1.9.1

Re: [PATCH] Find arm-linux-gnueabihf-gcc in compile

[Simon Marchi]

On 2018-01-18 03:46, Yao Qi wrote:
> GCC for arm-linux has different names on different distros.  It is
> arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has 
> arm-linux-gnueabihf-gcc.
> So when I run gdb.compile/ tests on arm-linux, I get,
> 
> (gdb) compile code -- ;
> Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"
> 
> This patch extend the regexp to match both arm-linux-gnu-gcc and
> arm-linux-gnueabihf-gcc.
> 
> gdb:
> 
> 2018-01-17  Yao Qi  <yao.qi@linaro.org>
> 
> 	* osabi.c (gdb_osabi_names): Extend the regexp for
> 	arm-linux-gnueabihf.
> ---
>  gdb/osabi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/osabi.c b/gdb/osabi.c
> index 129164f..fd44deb 100644
> --- a/gdb/osabi.c
> +++ b/gdb/osabi.c
> @@ -63,7 +63,7 @@ static const struct osabi_names gdb_osabi_names[] =
>    { "SVR4", NULL },
>    { "GNU/Hurd", NULL },
>    { "Solaris", NULL },
> -  { "GNU/Linux", "linux(-gnu)?" },
> +  { "GNU/Linux", "linux(-gnu[^-]*)?" },
>    { "FreeBSD", NULL },
>    { "NetBSD", NULL },
>    { "OpenBSD", NULL },

That seem reasonable to me.

Simon

Re: [PATCH] Find arm-linux-gnueabihf-gcc in compile

[Pedro Alves]

On 01/18/2018 08:46 AM, Yao Qi wrote:
> GCC for arm-linux has different names on different distros.  It is
> arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has arm-linux-gnueabihf-gcc.
> So when I run gdb.compile/ tests on arm-linux, I get,
> 
> (gdb) compile code -- ;
> Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"
> 
> This patch extend the regexp to match both arm-linux-gnu-gcc and
> arm-linux-gnueabihf-gcc.

Debian seems to have a "arm-linux-gnueabi-gcc" as well,
<https://packages.debian.org/sid/gcc-7-arm-linux-gnueabi>, 
which I assume is a version that defaults to soft-float.  (Or
is that softfp?)

So it's not entirely accurate to say that it's
arm-linux-gnueabihf-gcc on Debian.  It has both (and maybe more).

The "hf" in the name is encoding the default float ABI the compiler
outputs (hf is for hard float), which may not be the right one if
you have multiple versions of the compiler around in the PATH.
(more likely in a cross setup than on native, I guess.)

I think either gnueabihf/gnueabi compiler would be able to emit
code for either ABI, it's just a matter of what is the default, so
which ABI to pick can be left to making gdb pass the
right -mfloat-abi=soft/softfp/hard (and likewise other
"-m" options).

Thus, seems OK.

Thanks,
Pedro Alves

Re: [PATCH] Find arm-linux-gnueabihf-gcc in compile

[Yao Qi]

Pedro Alves <palves@redhat.com> writes:

> Debian seems to have a "arm-linux-gnueabi-gcc" as well,
> <https://packages.debian.org/sid/gcc-7-arm-linux-gnueabi>, 
> which I assume is a version that defaults to soft-float.  (Or
> is that softfp?)

Yes, arm-linux-gnueabi implies the EABI with -mfloat-abi=soft or
-mfloat-abi=softfp, while arm-linux-gnueabihf implies -mfloat-abi=hard.
I amend the commitlog a little, and push the patch below in.

-- 
Yao (齐尧)
From dea445b940545f9564972c5410ac8792b72cc9c3 Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Fri, 19 Jan 2018 09:08:36 +0000
Subject: [PATCH] Find arm-linux-gnueabi(hf)?-gcc in compile

GCC for arm-linux has different names on different distros.  It is
arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has arm-linux-gnueabihf-gcc
and arm-linux-gnueabi-gcc.  So when I run gdb.compile/ tests on arm-linux,
I get,

(gdb) compile code -- ;
Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"

This patch extend the regexp to match both arm-linux-gnu-gcc and
arm-linux-gnueabihf-gcc.

gdb:

2018-01-19  Yao Qi  <yao.qi@linaro.org>

	* osabi.c (gdb_osabi_names): Extend the regexp for
	arm-linux-gnueabihf and arm-linux-gnueabi.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 90dacd2..6709f44 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-19  Yao Qi  <yao.qi@linaro.org>
+
+	* osabi.c (gdb_osabi_names): Extend the regexp for
+	arm-linux-gnueabihf.
+
 2018-01-18  Yao Qi  <yao.qi@linaro.org>
 
 	* dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
diff --git a/gdb/osabi.c b/gdb/osabi.c
index 129164f..fd44deb 100644
--- a/gdb/osabi.c
+++ b/gdb/osabi.c
@@ -63,7 +63,7 @@ static const struct osabi_names gdb_osabi_names[] =
   { "SVR4", NULL },
   { "GNU/Hurd", NULL },
   { "Solaris", NULL },
-  { "GNU/Linux", "linux(-gnu)?" },
+  { "GNU/Linux", "linux(-gnu[^-]*)?" },
   { "FreeBSD", NULL },
   { "NetBSD", NULL },
   { "OpenBSD", NULL },