From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 44B413858409 for ; Thu, 2 Feb 2023 15:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44B413858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 873E21E112; Thu, 2 Feb 2023 10:08:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1675350533; bh=eiyAFxS3Viztg/9Nfq9eG0wdKBS4sBXwE9AiJHM/DxM=; h=Date:Subject:To:References:From:In-Reply-To:From; b=P2QtoK0qRrajGQ1cR5cGzXCB5Ba3xi4I6beuejYLoV6uYPMZq6c7RYGG28W6kDTcg HBuHeIPxmfcsZqJXimfHM7Tixeu9TOYGG1dWxqC6lRmvm0TPPopM1nmPztJUYZ9b/1 cy0rltwP3IUHOv1OJuSHFD8MLrffH0jnd4cQ1XJ0= Message-ID: Date: Thu, 2 Feb 2023 10:08:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230105200237.987771-1-simon.marchi@polymtl.ca> <5f28702a-53a9-1e8c-88d2-85e020e3b3f2@polymtl.ca> From: Simon Marchi In-Reply-To: <5f28702a-53a9-1e8c-88d2-85e020e3b3f2@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/23 12:03, Simon Marchi via Gdb-patches wrote: > > > On 1/5/23 15:02, Simon Marchi wrote: >> This is the v2 of: >> >> https://inbox.sourceware.org/gdb-patches/20221206135729.3937767-1-simon.marchi@efficios.com/ >> >> I pushed patches 5, 7, 8 and 9, since I considered them good chances even >> outside of this series. >> >> Most other preparatory patches have been reviewed and LGTM'ed by Andrew >> Burgess, but they are not really useful on their own, so they are still >> in this series. There are no changes in them, except a typo fix in >> patch 3. >> >> The only preparatory patch which was not reviewed is "gdb/solib-svr4: >> don't disable probes interface if probe not found". > > Ping. > > I plan to push the series in a week from now, if there are no more > comments on this. Note that this code has been heavily scrutinized by > Pedro and Lancelot, so I am confident that it is in good shape already. > > Simon I pushed the series. Simon