From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140041.outbound.protection.outlook.com [40.107.14.41]) by sourceware.org (Postfix) with ESMTPS id 235AF38303D8 for ; Wed, 1 Jun 2022 10:00:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 235AF38303D8 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jf1aedm6yuwWwcaL5pG3FhGeYvP3LpAMSMa+/2aojRCNGtm2wAy7OoDu/mvKiD0gR77PgaPzA/eEYPZlns6OGGGZ25qh/SX2apJaxAXXiNEmBtswIPjp8DBwTbacoB7DLl3EDogldd0Bysn148iKYcifJGa/LIhL+kouEYU86UdYM4dLCjK5LY+l+YVpa2VyKdJ99KFiRCQy1t+uj1L0qlnMCupBG3Dce1WXwJlEb50KzpxHvpvsp4FQjH9fKBt9kvvnb5kArZmM/U+had8XpkCtpvIH4JiXAuSE0qdJuNY77r7f0yEN0bTAwXRdxTng0oeBA8vnUYqGW8mPwBBmkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=11gQ1TwPgEb7sx+xNXzUxRcj9X38FrsDxKhNSJlLQwk=; b=neo8/CeA74UWLjCmzCtpwPhgBg6J9GMdkvNJNUr1sAKP1p5oysSbQIK1PsOp/M3CZBLFSIKMltZzCKE2CyWBwNqAw+Zdyb+BH7jCt2ImuNFIX5+mglqZ9sLCSc7UDVhhJCKwjJKBTW1zaXjjvlueC0FJKBYSrVKPaL44Sp824maKadrOXH8Y6lEjN5iqkCTGxUPgjVlxF7UGuF/rSA4Sam1Ga15M93g55i7qQoYyqSHbUcASHJS943P+VOcJyMCuokyj6VMoaZqXqDy8lLjoVIp0LicpFNoAJbgmAsDKALuAoXQFJe4LQEfXzyISooFrRDOsJYI97gFOKhwDuw0BuQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AM5PR04CA0018.eurprd04.prod.outlook.com (2603:10a6:206:1::31) by AM7PR08MB5319.eurprd08.prod.outlook.com (2603:10a6:20b:dc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 1 Jun 2022 10:00:13 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::82) by AM5PR04CA0018.outlook.office365.com (2603:10a6:206:1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13 via Frontend Transport; Wed, 1 Jun 2022 10:00:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.12 via Frontend Transport; Wed, 1 Jun 2022 10:00:13 +0000 Received: ("Tessian outbound 1766a3bff204:v120"); Wed, 01 Jun 2022 10:00:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b90f1dad9b93146e X-CR-MTA-TID: 64aa7808 Received: from a7c655b77f65.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 34C8CFC0-4DE7-48F8-8ED1-028264342FF0.1; Wed, 01 Jun 2022 10:00:06 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7c655b77f65.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 01 Jun 2022 10:00:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oDUCPw97mCly4iv3lVBA5rzjZJ6OeupLWLfbDC4ITm9y4RSa6KK5ntsKVBz97eIDJidFkW7OiLZOrWDwHu2/Gk7KAZxg2pVmnybaZ5bS3vQ+0zR32OryX2HxPXS8RXRBJfwAVHo5TOXMG0YBAeSu+Sfka4i4W78UzVZ1F4vWeHbHcLRWmfU3Rqv5WR+h/pek50/lELK5DlXPuIs1JY3dvE5phkJ36/+7Q0+YBiyAsQyQk+yog49XDrBCRPkIEGim7MmrfwdgbM/rU8IkaJVQ3DSzPzTBduo1I1IOxCq1G2Jrny8cmGuJSB8b46SzrbSEAT46Ji3zUQlQzZFLI43hYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=11gQ1TwPgEb7sx+xNXzUxRcj9X38FrsDxKhNSJlLQwk=; b=m8eHfGXQaxshLdK0glUtuuPMXzoC/MfnJdNnme/9/UYfeHZ07l0LuuL3JPsw5MF+2Vjxdpr9kAnX5kKhMJc33D0zs0STZPJ5sHZPcplQchPKTKqCf/wmKjHcy79t1g9gDLTdtm41wTwz7pLExbd4SuC3DIfayEAbxa3UIn1KPwdVIlOzeIG/4UGe0heCOm3PKJBX+WAEfo8eUF7KdGjYMdEKdqaDy5VhEB9XbUGej1QqNzGzjuYJQWxAHuL5VsCijOeXfhryzFqZ/0pAgqfYVUyxay9NXCNHc3ZBHhty96Lg28bISetPhsRKhLXw0X//SdTnfYzQi8r+THtvM+l9uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DB9PR08MB6937.eurprd08.prod.outlook.com (2603:10a6:10:26e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5293.13; Wed, 1 Jun 2022 10:00:05 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::9545:ff73:df89:3e50]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::9545:ff73:df89:3e50%7]) with mapi id 15.20.5314.013; Wed, 1 Jun 2022 10:00:05 +0000 Message-ID: Date: Wed, 1 Jun 2022 11:00:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] gdb/arm: Don't use special treatment for PC Content-Language: en-US To: Yvan Roux , gdb-patches@sourceware.org Cc: Torbjorn SVENSSON References: <20220531134754.GD13232@gnbcxd0114.gnb.st.com> From: Luis Machado In-Reply-To: <20220531134754.GD13232@gnbcxd0114.gnb.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0122.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c6::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 315d96bf-2c5a-4424-18f3-08da43b58566 X-MS-TrafficTypeDiagnostic: DB9PR08MB6937:EE_|AM5EUR03FT047:EE_|AM7PR08MB5319:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QAtyYkUCCkDcjnln/5FNVdG8iFNYkN3SSdKwLs7AVcfzZQQkpWYGEOu+U1Kg9jYf7w4cY2mFGhrqCnFjmnyZdKKydJat+aHdJiHMd/mBZ4ml0QiViV+qXzNKtOuwWYQgQq1xJDwNDhbzNQE38KL2AirCvdCH3gvpbHehURZHXwufYuASqyPrEQYWL/17GtFZBEpLHvmNBCPe/B6Aa4h3UQj+X/pryIEO4/R20Uvw/gIfM/+2lI472m6kvdYgrxX/NBWkfCD58bg8lmqWCOIvjgrTvlCJVbl/yf5g9w6oX/bYWaVlddQthxewvPJSK7wHv0TAvDjOIx4k4QVc0ZsZHdyEJ8lpqNNwX08Va+xub0wDOq98aLy6wkUfDjeGsSnWsgnGZwAsk5434hVlPiZ5KJDo9SMK5iJk/nRosa2R3sfXHQNITzllUpRyNdRJgepdNMqwd6GElYF4uOJxQDRCZHlpwD/dxnWhbQp0MN+zstvJH+qCa+eseR6tH2k0DiidWOJEVKkJhE8oVUldirKRpYM9OcgELM3IzxBQ5i8QJ/ZPsGmFtaTJIe+J+ioZzKrNywm+vYfb0/NP9VPrnmOBn7L3ovyXuwX0MiNAHCxclt0+0crdCLYCHzSi4cEVnYo/AgHMLzObrrxMAIRRwvoNG7oEGsiZBt3cL9lin2ROSlNi7PwKuyoMSIfeBzkq9vBXqJ8L4Sm/N/VlupptuqpNHcf5fGhx4KPb1vz2qghVE3s= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(31686004)(86362001)(316002)(83380400001)(186003)(31696002)(26005)(2616005)(6506007)(6512007)(53546011)(2906002)(38100700002)(36756003)(6486002)(66476007)(8936002)(66556008)(66946007)(8676002)(4326008)(508600001)(44832011)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6937 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ab3e7dd3-e17f-4e37-2cac-08da43b58077 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zhpt77wmq/SpX+UaQih8ZRW7oy5WkVP4Ff4YGHlhUvZPxTbDIwCT0x4BmC9oAZT/titZkpKF6SQRdd8EFq/4f/q3OAVMdjtK2BNepS+zKkGPD3UopJpU/IZ4Tl8VQ1MTvyfL9TU0Em9HV1JmELY0SU31HnrL5/B2Kk9QD5SOUZ4JjEaJLl652v1C8uCvdwwI6MOmN7FCTudfY+3tbv6q1SnRceY1vfPjbM7HMy/U+u2T4KR9yroLd+YGjyr9FJCnBg7+kSNNDMZU4jpsIqD3TDIMU1B4rny9GNpOLCVN3xvtVEiFm0qPeEU3fHbLo02lxrQgFdZ5elDGHOdQ2uDy5WyiAvWdyk51DnPP990oMNmonhDacdpiplGsfcLH5j0duZfetHoUg2ucUfDrWeRtDefWc6OU+z0svso4WhkZW74IHV4JMAAy2Abt94MOZYhx47+gIsJY8Izlj4AJJ0G96Yd7eQvsjC7T0E/vYvisD4cFiMnI9yjL5g4X/gNC28ABBWFpWUiilP98kD/w66ylK+QXzoULlCbFrHfhba8CulSEbh4mIEA9dz4b85m9+wJBbLCX0LirCq/ieqv9OQ1puyOH+2J452Jx/GAo/qk3qNeut6443yD6gRmczhy+O2zIx/ltx2C+UDBEx+s0b1FG9nKaLDvwfKn0YB+f2uAG+OxRLGfeRZBP25Lyl5gReMlgttnhenQrpiGGeggSGaGVvA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(356005)(186003)(40460700003)(31686004)(81166007)(86362001)(70206006)(5660300002)(336012)(4326008)(70586007)(83380400001)(36756003)(8936002)(44832011)(2616005)(8676002)(2906002)(316002)(82310400005)(6506007)(26005)(53546011)(6512007)(508600001)(47076005)(6486002)(36860700001)(31696002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 10:00:13.1914 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 315d96bf-2c5a-4424-18f3-08da43b58566 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5319 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jun 2022 10:00:17 -0000 On 5/31/22 14:47, Yvan Roux wrote: > Hi, > > In an exception frame the PC register is extracted from the stack > just like other base registers, so there is no need for a special > treatment. > > Signed-off-by: Torbj�rn SVENSSON > Signed-off-by: Yvan Roux > --- > gdb/arm-tdep.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 49664093f00..4ef10ec214d 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -3558,15 +3558,6 @@ arm_m_exception_prev_register (struct frame_info *this_frame, > return frame_unwind_got_constant (this_frame, prev_regnum, sp_value); > } > > - if (prev_regnum == ARM_PC_REGNUM) > - { > - CORE_ADDR lr = frame_unwind_register_unsigned (this_frame, ARM_LR_REGNUM); > - struct gdbarch *gdbarch = get_frame_arch (this_frame); > - > - return frame_unwind_got_constant (this_frame, prev_regnum, > - arm_addr_bits_remove (gdbarch, lr)); > - } > - > return trad_frame_get_prev_register (this_frame, cache->saved_regs, > prev_regnum); > } Thanks. This is OK as well.