Re: [PATCH 12/12] Testcase for detaching while stepping over breakpoint

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2021-01-12 8:15 p.m., Pedro Alves wrote:
> +# The test proper.  See description above.
> +proc test {condition_eval target_non_stop non_stop displaced} {
> +    global binfile srcfile
> +    global gdb_prompt
> +    global decimal
> +    global bp_lineno
> +    global GDBFLAGS
> +
> +    # Number of threads started by the program.
> +    set n_threads 10
> +
> +    save_vars { GDBFLAGS } {
> +	append GDBFLAGS " -ex \"maint set target-non-stop $target_non_stop\""
> +	append GDBFLAGS " -ex \"set non-stop $non_stop\""
> +	append GDBFLAGS " -ex \"set displaced $displaced\""
> +	append GDBFLAGS " -ex \"set schedule-multiple on\""
> +	clean_restart $binfile
> +    }
> +
> +    set test_spawn_id [spawn_wait_for_attach $binfile]
> +    set testpid [spawn_id_get_pid $test_spawn_id]
> +
> +    set any "\[^\r\n\]*"
> +
> +    gdb_test "add-inferior" "Added inferior 2.*"
> +    gdb_test "inferior 2" "Switching to .*"
> +
> +    gdb_load $binfile
> +    if ![runto setup_done] then {
> +	fail "can't run to setup_done"
> +	kill_wait_spawned_process $test_spawn_id
> +	return
> +    }
> +
> +    gdb_test_no_output "set breakpoint condition-evaluation $condition_eval"
> +
> +    # Get the PID of the test process.
> +    set pid_inf2 ""
> +    gdb_test_multiple "p mypid" "get pid of inferior 2" {
> +	-re " = ($decimal)\r\n$gdb_prompt $" {
> +	    set pid_inf2 $expect_out(1,string)
> +	    pass $gdb_test_name
> +	}
> +    }
> +
> +    set attempts 3
> +    for {set attempt 1} { $attempt <= $attempts } { incr attempt } {
> +	with_test_prefix "iter $attempt" {
> +	    gdb_test "inferior 1" "Switching to .*"
> +
> +	    set attached 0
> +	    set eperm 0
> +	    set test "attach"
> +	    gdb_test_multiple "attach $testpid" $test {
> +		-re "new threads in iteration" {
> +		    # Seen when "set debug libthread_db" is on.
> +		    exp_continue
> +		}
> +		-re "is a zombie - the process has already terminated.*$gdb_prompt " {
> +		    fail $gdb_test_name
> +		}
> +		-re "Unable to attach: .*$gdb_prompt " {
> +		    fail $gdb_test_name
> +		}
> +		-re "Attaching to program.*process $testpid.*$gdb_prompt " {
> +		    pass $test
> +		    set attached 1
> +		}
> +	    }
> +
> +	    if {!$attached} {
> +		kill_wait_spawned_process $test_spawn_id
> +		return
> +	    }
> +
> +	    if {$non_stop} {
> +		# In non-stop, we will see one stop per thread after
> +		# the prompt.
> +		set stops 0
> +		set tid_re "$::decimal\.$::decimal"
> +		set test "seen all stops"
> +		for {set thread 1} { $thread <= $n_threads } { incr thread } {
> +		    if {[gdb_test_multiple "" $test {
> +			-re "Thread ${tid_re} ${any} stopped" {
> +			    incr stops
> +			}
> +		    }] != 0} {
> +			break
> +		    }
> +		}
> +
> +		# This we haven't seen all stops, then the

This sentence misses something, like in the other test.

I am running it in a loop here and it's passing so far :).  Really, congrats
and thanks for this series, that looked like some hardcore debugging.

Simon