public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Release the GIL while running a gdb command or expression
Date: Fri, 12 Oct 2018 14:52:00 -0000	[thread overview]
Message-ID: <f33bf801-ca39-cc7a-1e2e-77c2af6c707e@redhat.com> (raw)
In-Reply-To: <20181010202233.17985-1-tom@tromey.com>

On 10/10/2018 21:22, Tom Tromey wrote:
> PR python/23615 points out that gdb.execute_gdb_command does not
> release the Python GIL.  This means that, while the gdb command is
> running, other Python threads do not run.
> 
> This patch solves the problem by introducing a new RAII class that can
> be used to temporarily release and then re-acquire the GIL, then puts
> this into the appropriate places in execute_gdb_command and
> gdbpy_parse_and_eval.
> 
> This version of the patch includes a test case from Phil.

I know I said this on the other email, but, Version 2 LGTM also.

Cheers

Phil

  reply	other threads:[~2018-10-12 14:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10 20:23 Tom Tromey
2018-10-12 14:52 ` Phil Muldoon [this message]
2018-10-12 16:49 ` Pedro Alves
2018-10-12 16:51   ` Pedro Alves
2018-10-16 12:48   ` Tom Tromey
2018-10-16 14:50     ` Pedro Alves
2018-10-12 16:56 ` Pedro Alves
2018-10-16 13:05   ` Tom Tromey
2018-10-16 14:51     ` Pedro Alves
2018-10-16 21:39       ` Tom Tromey
2018-10-16 21:45         ` Tom Tromey
2018-10-24 18:08           ` Pedro Alves
2018-10-25 12:46             ` Phil Muldoon
2018-11-04 15:54             ` Tom Tromey
2019-01-29 13:02               ` Tom Tromey
2019-01-29 16:37                 ` Pedro Alves
2018-10-18  9:31         ` Phil Muldoon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f33bf801-ca39-cc7a-1e2e-77c2af6c707e@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).