From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E7D973858CDA for ; Thu, 14 Sep 2023 15:46:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7D973858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694706404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=o5TST5wVFTCgTsKl0FjEdWPdustax/EyguISsu54xSw=; b=L2uX98ofFrsKL/0Ez5j9advtOmImUfJdjRETMooHII5RdKvOGJZysdmOFsK/4rGvMZbm+3 D2Ju77AB3sKMVBs1+SZNwEEyE7EB4R1Kvb4FLaAsQ4DKku2MI2RUxzBT1rxhF882KoyXVl 3oZZR0/TIScZwaprI4GLpdf+vYO+PxY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-FNwmMd_vOvmKesFBxA5XDA-1; Thu, 14 Sep 2023 11:46:42 -0400 X-MC-Unique: FNwmMd_vOvmKesFBxA5XDA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31dc8f0733dso676995f8f.3 for ; Thu, 14 Sep 2023 08:46:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694706397; x=1695311197; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o5TST5wVFTCgTsKl0FjEdWPdustax/EyguISsu54xSw=; b=p7XSJJtd3O9FD6b4iNtS3VK4TEcBSfJB17KcIq4wbL891nsbFlgLl5KM5c6AeV4dfB EPLFROENOuQdww4UJDc7Rlqrhc26f5wpIrmNwVTDmDQ3Yt/FUGnqH4lHhf6j0Oo35Bev snQMyr7eEXXWB7Jr84SPELIXl8zBvkeeGRRTnJQDnIlYOXSJCHxDF+6eg15GYe+8iZsf Z6UJL4JTTisB5zV3in3YN7VTqhRk7YTopUwp1lj0eUKUEt5QlviK93HCaVUJvTNjzaVg 4yASsuvIifb3Woku8IhONAsKjPc5iUCPUguiSTh9UIYYRO2AxCCI3BVRWfFy4SCSzeUW OCfw== X-Gm-Message-State: AOJu0Yy/uaYzP9G4Lm3UIRzVw9kBniZ4pJMFCOlRhUwgRKB2ae0oQhqt S2b34kx8Q1eXed3qEhkz5ERRz7hNOf7udNwS0AswxVVaS/bs4jTo/JshC2ZUzBCVPOp1Y5QF8sL eAaMLsFKd7m3UrqIPkaZs4SRsFJ6cNdqPopJ2h9A0K1sq53v8oJIQD9013Dc57xjzXRoS7etZQ+ uBCDSykA== X-Received: by 2002:a5d:4208:0:b0:31a:c6fb:4142 with SMTP id n8-20020a5d4208000000b0031ac6fb4142mr4903379wrq.16.1694706396908; Thu, 14 Sep 2023 08:46:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXwy7mcGj/fK8UWimgGbKIPLVP2j1agelKgugnXWZfASTzhcFKvg1k2Lajc2AMvdYpSsPasQ== X-Received: by 2002:a5d:4208:0:b0:31a:c6fb:4142 with SMTP id n8-20020a5d4208000000b0031ac6fb4142mr4903361wrq.16.1694706396423; Thu, 14 Sep 2023 08:46:36 -0700 (PDT) Received: from localhost (197.126.90.146.dyn.plus.net. [146.90.126.197]) by smtp.gmail.com with ESMTPSA id a4-20020adfeec4000000b0031c77c010e1sm2096246wrp.96.2023.09.14.08.46.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Sep 2023 08:46:35 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PATCH] gdb: add some missing filename styling Date: Thu, 14 Sep 2023 16:46:33 +0100 Message-Id: X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Spotted a few places where we can add filename styling. --- gdb/symfile-debug.c | 11 +++++++---- gdb/symfile.c | 13 +++++++------ 2 files changed, 14 insertions(+), 10 deletions(-) diff --git a/gdb/symfile-debug.c b/gdb/symfile-debug.c index 233cf3390e5..850da4147a3 100644 --- a/gdb/symfile-debug.c +++ b/gdb/symfile-debug.c @@ -34,6 +34,7 @@ #include "symfile.h" #include "block.h" #include "filenames.h" +#include "cli/cli-style.h" /* We need to save a pointer to the real symbol functions. Plus, the debug versions are malloc'd because we have to NULL out the @@ -542,16 +543,18 @@ objfile::require_partial_symbols (bool verbose) { if (verbose && !printed) { - gdb_printf (_("Reading symbols from %s...\n"), - objfile_name (this)); + gdb_printf (_("Reading symbols from %ps...\n"), + styled_string (file_name_style.style (), + objfile_name (this))); printed = true; } iter->read_partial_symbols (this); } } if (printed && !objfile_has_symbols (this)) - gdb_printf (_("(No debugging symbols found in %s)\n"), - objfile_name (this)); + gdb_printf (_("(No debugging symbols found in %ps)\n"), + styled_string (file_name_style.style (), + objfile_name (this))); } } diff --git a/gdb/symfile.c b/gdb/symfile.c index 1b46ec45f2e..70ade9e119e 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -2322,8 +2322,8 @@ add_symbol_file_command (const char *args, int from_tty) statements because hex_string returns a local static string. */ - gdb_printf (_("add symbol table from file \"%s\""), - filename.get ()); + gdb_printf (_("add symbol table from file \"%ps\""), + styled_string (file_name_style.style (), filename.get ())); section_addr_info section_addrs; std::vector::const_iterator it = sect_opts.begin (); if (!seen_addr) @@ -2369,8 +2369,8 @@ add_symbol_file_command (const char *args, int from_tty) objf = symbol_file_add (filename.get (), add_flags, §ion_addrs, flags); if (!objfile_has_symbols (objf) && objf->per_bfd->minimal_symbol_count <= 0) - warning (_("newly-added symbol file \"%s\" does not provide any symbols"), - filename.get ()); + warning (_("newly-added symbol file \"%ps\" does not provide any symbols"), + styled_string (file_name_style.style (), filename.get ())); if (seen_offset) set_objfile_default_section_offset (objf, section_addrs, offset); @@ -2494,8 +2494,9 @@ reread_symbols (int from_tty) new_modtime = new_statbuf.st_mtime; if (new_modtime != objfile->mtime) { - gdb_printf (_("`%s' has changed; re-reading symbols.\n"), - objfile_name (objfile)); + gdb_printf (_("`%ps' has changed; re-reading symbols.\n"), + styled_string (file_name_style.style (), + objfile_name (objfile))); /* There are various functions like symbol_file_add, symfile_bfd_open, syms_from_objfile, etc., which might base-commit: d7680f13df105aa8fa0edbdf8efae31a5411f579 -- 2.25.4