Re: [PATCH 1/3] gdb/ctf: don't create a buildsym_compunit when building partial symbols

[Simon Marchi <simon.marchi@polymtl.ca>]

> Here is the spec for CTF V3:
> 
> http://www.esperi.org.uk/~oranix/ctf/ctf-spec.pdf
> 
> which hopefully is helpful.

Thanks, I read the first section (CTF archives), I think it somewhat
matches what I thought.  I'm not sure about how the details of how types
are deduplicated exactly, but that's not relevant for this patch.

>> I'll attach the output of "readelf --ctf=.ctf" for the file I am working
>> with.
>>
>> My understanding from the readelf output is that there is some debug
>> info (function, types, etc) described at the top-level.  It doesn't seem
>> associated to a source file, and it seems to contain things that are
>> global.
>>
>> Then there is one "archive" for each compiled .c file, such as:
>>
>>    CTF archive member: /home/simark/src/babeltrace/src/lib/current-thread.c:
>>
>> Each archive contains very little data, my guess is that it only
>> contains what is not already described at the top-level?
> 
> Yes, that's my understanding too.
> 
>>
>> Right now, in GDB, we create one CU (partial_symtab, and then
>> compunit_symtab after expansion) for the top-level, and the one CU for
>> each archive.  My patch does not change that.  It only removes a
>> "new buildsym_compunit" call that just seems useless / to do nothing.
>>
>> In other words, no user-visible changes are expected from this patch.
> 
> OK. Thanks.

Thanks, I will push the series, let me know if you see something
breaking.

Simon