From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 745C23858D20 for ; Fri, 28 Jul 2023 14:20:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 745C23858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690554051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=umbooLJz86Rut4nlKB+KtMvbrP01+RG5XKU8t6IaiL0=; b=LFcYahF66KFTF1TYxjTt+Yw3NDve2wMYPH8JCHTA2cbzPQPF7E2nO5genTs8ojGYvynPSV 79hyRGu56aGr1OFeCZtPWx1lWfMfvO5lVRGHyaksop6KFVlNCN/O/Rd4va2rlaJlraw0p1 iFb4U8w2/cADZxQa0y4ZqbL1OyIyUzU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-o94SUH7xONKS-rK-9OGp2g-1; Fri, 28 Jul 2023 10:20:50 -0400 X-MC-Unique: o94SUH7xONKS-rK-9OGp2g-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fa96b67ac1so12178945e9.0 for ; Fri, 28 Jul 2023 07:20:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690554049; x=1691158849; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=umbooLJz86Rut4nlKB+KtMvbrP01+RG5XKU8t6IaiL0=; b=FLOdRWUQg5//DcEZyTaTxslZmGI4z1deZ06pNr7ILSSI36MPuVMc+ERVt8jXhi8CGt yOXnrh2Jt/8j4pWgZcIEPOZwRAYrmqw12VneJLooPfYXYrDD1cjir68+/n1ufk0b/nLx UsOsTIv2SXOKe5OH/4yXE+PEEGVPa9T1TtnT4L1jAVIQY7MzKe8xwBjmtPaZSzIQxTA2 YNrOwioAoJSSx/naUfewTsYjJMIXgaQRkN3R15v9du3746UDTfRNHcziirx33+DTMsgp D26+yyXp9sDHQsjl2NUcH5A1fVREA/vYAIHDCyZMBx42RYf3J1ARTI0EdUA+bMC1d1wR Y3Hw== X-Gm-Message-State: ABy/qLbcoRxGWOYbZwM5IKDxhJryI6rI+RK27xLPOGuq5JNRhkY5Z3jZ eIVlc0IyZPLC6u5tucB22iV8aFSCzKrTDPUZJIeK5VlC51bszozyBA0zA/Fy0jtiI2gv6c8Ko/r 2nfQOh0aIblsnpE361FJ3XzEz+XRQmg== X-Received: by 2002:a05:600c:2296:b0:3fe:ad3:b066 with SMTP id 22-20020a05600c229600b003fe0ad3b066mr1745692wmf.41.1690554048845; Fri, 28 Jul 2023 07:20:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlE64Ue82bLOfmJSG677/ejpeluZuf0e131dbCJXTEVx+vo35LosCG8EZhD2VlQYvB0es0Cx/w== X-Received: by 2002:a05:600c:2296:b0:3fe:ad3:b066 with SMTP id 22-20020a05600c229600b003fe0ad3b066mr1745677wmf.41.1690554048503; Fri, 28 Jul 2023 07:20:48 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id y18-20020a1c4b12000000b003fbd597bccesm6996787wma.41.2023.07.28.07.20.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 07:20:48 -0700 (PDT) Message-ID: Date: Fri, 28 Jul 2023 16:20:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 3/4] gdb/testsuite: fix testing gdb.reverse/step-reverse.exp with clang To: Tom Tromey , Bruno Larsen via Gdb-patches References: <20230725095833.236804-1-blarsen@redhat.com> <20230727074118.1583199-1-blarsen@redhat.com> <20230727074118.1583199-4-blarsen@redhat.com> <873518i3ey.fsf@tromey.com> <87tttoglv3.fsf@tromey.com> From: Bruno Larsen In-Reply-To: <87tttoglv3.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28/07/2023 16:18, Tom Tromey wrote: >>>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: > Bruno> I mean, yeah I can, but since it is in a loop, the differences would > Bruno> only be a counter at the end of the test case. Are we really getting > Bruno> any value from that? To me it seems like it would just boggle down the > Bruno> sum file with meaningless "tests" that aren't exercising any relevant > Bruno> code paths. I can do it if you disagree, though, it isn't a big deal. > > Yeah, I don't know if it's useful -- but are any of these passes useful? > The problem I think is that the proc can unconditionally emit a fail, so > having a corresponding pass seems to make sense. > Ah, yeah, in that angle it does make sense. I'll do it for v3! -- Cheers, Bruno