* [PATCH] gdb: xtensa: fix build @ 2014-01-16 13:02 Baruch Siach 2014-01-16 16:46 ` Pedro Alves 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2014-01-16 13:02 UTC (permalink / raw) To: gdb-patches; +Cc: Baruch Siach We need asm/ptrace.h for PTRACE_GETXTREGS. gdb/ * xtensa-linux-nat.c: #include asm/ptrace.h instead of sys/ptrace.h gdb/gdbserver/ * linux-xtensa-low.c: #include asm/ptrace.h instead of sys/ptrace.h --- gdb/gdbserver/linux-xtensa-low.c | 2 +- gdb/xtensa-linux-nat.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/gdbserver/linux-xtensa-low.c b/gdb/gdbserver/linux-xtensa-low.c index 7db97a9cc543..479b65b26b00 100644 --- a/gdb/gdbserver/linux-xtensa-low.c +++ b/gdb/gdbserver/linux-xtensa-low.c @@ -24,7 +24,7 @@ void init_registers_xtensa (void); extern const struct target_desc *tdesc_xtensa; -#include <sys/ptrace.h> +#include <asm/ptrace.h> #include <xtensa-config.h> #include "xtensa-xtregs.c" diff --git a/gdb/xtensa-linux-nat.c b/gdb/xtensa-linux-nat.c index 2372e792f3fe..1ebae3266be0 100644 --- a/gdb/xtensa-linux-nat.c +++ b/gdb/xtensa-linux-nat.c @@ -35,7 +35,7 @@ #include "gdb_wait.h" #include <fcntl.h> #include <sys/procfs.h> -#include <sys/ptrace.h> +#include <asm/ptrace.h> #include "gregset.h" #include "xtensa-tdep.h" -- 1.8.5.2 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gdb: xtensa: fix build 2014-01-16 13:02 [PATCH] gdb: xtensa: fix build Baruch Siach @ 2014-01-16 16:46 ` Pedro Alves 2014-01-16 17:01 ` Baruch Siach 0 siblings, 1 reply; 6+ messages in thread From: Pedro Alves @ 2014-01-16 16:46 UTC (permalink / raw) To: Baruch Siach; +Cc: gdb-patches On 01/16/2014 01:01 PM, Baruch Siach wrote: > We need asm/ptrace.h for PTRACE_GETXTREGS. Did something change? Clearly this wasn't needed before. -- Pedro Alves ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gdb: xtensa: fix build 2014-01-16 16:46 ` Pedro Alves @ 2014-01-16 17:01 ` Baruch Siach [not found] ` <CAC3St3Du78bPPpczNwdV-TvCN-egk1kFn=L9tYveazDdse-dnA@mail.gmail.com> 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2014-01-16 17:01 UTC (permalink / raw) To: Pedro Alves; +Cc: gdb-patches, Maxim Grigoriev Hi Pedro, Thanks for reviewing. On Thu, Jan 16, 2014 at 04:46:03PM +0000, Pedro Alves wrote: > On 01/16/2014 01:01 PM, Baruch Siach wrote: > > We need asm/ptrace.h for PTRACE_GETXTREGS. > > Did something change? Clearly this wasn't needed before. I'm not sure what has changed. As far as I can see sys/ptrace.h never had PTRACE_GETXTREGS defined. Maybe Maxim has a clue (Added to Cc). baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CAC3St3Du78bPPpczNwdV-TvCN-egk1kFn=L9tYveazDdse-dnA@mail.gmail.com>]
* Re: [PATCH] gdb: xtensa: fix build [not found] ` <CAC3St3Du78bPPpczNwdV-TvCN-egk1kFn=L9tYveazDdse-dnA@mail.gmail.com> @ 2014-01-16 20:27 ` Baruch Siach 2014-01-17 13:07 ` Pedro Alves 0 siblings, 1 reply; 6+ messages in thread From: Baruch Siach @ 2014-01-16 20:27 UTC (permalink / raw) To: Maxim Grigoriev; +Cc: Pedro Alves, gdb-patches, Marc Gauthier, Dror Maydan Hi Maxim, On Thu, Jan 16, 2014 at 12:11:41PM -0800, Maxim Grigoriev wrote: > Hello Pedro and Baruch, > > I actually haven't been doing Xtensa GDB maintenance for quite some time > now since I left Tensilica. Since xtensa-linux-nat.c used PTRACE_GETXTREGS since the beginning, and since sys/ptrace.h (at least on uClibc) never defined this value, the question is simply how did you build gdb at the time? I should note that Buildroot is carrying this patch for more than a year now. > Let's ask Marc and Dror. I've included them on the list. > > Marc, Dror : Who is doing Xtensa GDB maintenance now ? If you want me to > help, I can do it. baruch > On Thu, Jan 16, 2014 at 9:01 AM, Baruch Siach <baruch@tkos.co.il> wrote: > > Hi Pedro, > > > > Thanks for reviewing. > > > > On Thu, Jan 16, 2014 at 04:46:03PM +0000, Pedro Alves wrote: > > > On 01/16/2014 01:01 PM, Baruch Siach wrote: > > > > We need asm/ptrace.h for PTRACE_GETXTREGS. > > > > > > Did something change? Clearly this wasn't needed before. > > > > I'm not sure what has changed. As far as I can see sys/ptrace.h never had > > PTRACE_GETXTREGS defined. Maybe Maxim has a clue (Added to Cc). > > > > baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gdb: xtensa: fix build 2014-01-16 20:27 ` Baruch Siach @ 2014-01-17 13:07 ` Pedro Alves 2014-01-17 13:11 ` Baruch Siach 0 siblings, 1 reply; 6+ messages in thread From: Pedro Alves @ 2014-01-17 13:07 UTC (permalink / raw) To: Baruch Siach; +Cc: Maxim Grigoriev, gdb-patches, Marc Gauthier, Dror Maydan On 01/16/2014 08:27 PM, Baruch Siach wrote: > Hi Maxim, > > On Thu, Jan 16, 2014 at 12:11:41PM -0800, Maxim Grigoriev wrote: >> Hello Pedro and Baruch, >> >> I actually haven't been doing Xtensa GDB maintenance for quite some time >> now since I left Tensilica. > > Since xtensa-linux-nat.c used PTRACE_GETXTREGS since the beginning, and since > sys/ptrace.h (at least on uClibc) never defined this value, the question is > simply how did you build gdb at the time? > > I should note that Buildroot is carrying this patch for more than a year now. Alright. Indeed, the original submission left me wondering whether the "We" in "We need" might even be talking about a different libc than what the original port was done against (if not, weird that this didn't come up then), and if so, then I have to wonder whether just switching to asm/ptrace.h might be breaking the build against other libc (glibc?), and therefore we might need to include both. So mainly I'm just looking for a little more confirmation and more extended description for the commit log / archives. -- Pedro Alves ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gdb: xtensa: fix build 2014-01-17 13:07 ` Pedro Alves @ 2014-01-17 13:11 ` Baruch Siach 0 siblings, 0 replies; 6+ messages in thread From: Baruch Siach @ 2014-01-17 13:11 UTC (permalink / raw) To: Pedro Alves; +Cc: Maxim Grigoriev, gdb-patches, Marc Gauthier, Dror Maydan Hi Pedro, On Fri, Jan 17, 2014 at 01:06:59PM +0000, Pedro Alves wrote: > On 01/16/2014 08:27 PM, Baruch Siach wrote: > > On Thu, Jan 16, 2014 at 12:11:41PM -0800, Maxim Grigoriev wrote: > >> Hello Pedro and Baruch, > >> > >> I actually haven't been doing Xtensa GDB maintenance for quite some time > >> now since I left Tensilica. > > > > Since xtensa-linux-nat.c used PTRACE_GETXTREGS since the beginning, and since > > sys/ptrace.h (at least on uClibc) never defined this value, the question is > > simply how did you build gdb at the time? > > > > I should note that Buildroot is carrying this patch for more than a year now. > > Alright. Indeed, the original submission left me wondering whether > the "We" in "We need" might even be talking about a different libc > than what the original port was done against (if not, weird that this > didn't come up then), and if so, then I have to wonder whether > just switching to asm/ptrace.h might be breaking the build against > other libc (glibc?), and therefore we might need to include both. > So mainly I'm just looking for a little more confirmation and > more extended description for the commit log / archives. OK. I'll resend with a more verbose commit log, summarizing what I know, including any additional information that Maxim will provide. baruch -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il - ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-17 13:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-16 13:02 [PATCH] gdb: xtensa: fix build Baruch Siach
2014-01-16 16:46 ` Pedro Alves
2014-01-16 17:01 ` Baruch Siach
[not found] ` <CAC3St3Du78bPPpczNwdV-TvCN-egk1kFn=L9tYveazDdse-dnA@mail.gmail.com>
2014-01-16 20:27 ` Baruch Siach
2014-01-17 13:07 ` Pedro Alves
2014-01-17 13:11 ` Baruch Siach
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).