From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2043.outbound.protection.outlook.com [40.107.105.43]) by sourceware.org (Postfix) with ESMTPS id 560EA3858D28 for ; Fri, 24 Mar 2023 06:28:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 560EA3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=72fCpYcyygDheyOWCNZMn4PGxBSXqh60Ot0u3HtSB2w=; b=9BYc9m+W73rat0PrvkAZNrnmBZGU/KlWppldOkuCxrB7dkL+hKWOgGOF0qB4LUJcki1j4Woyi6my/TfDUn385cxrzQMfvHpBLEsvDMPvEcDF2BQYNnCHEyhhCJq2CujXdK3K82mT7cU8gUso9ZuyuhGnJoN6DBI+4YQcmpjTgVk= Received: from DB8PR09CA0008.eurprd09.prod.outlook.com (2603:10a6:10:a0::21) by AS8PR08MB7323.eurprd08.prod.outlook.com (2603:10a6:20b:442::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 06:28:27 +0000 Received: from DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::b6) by DB8PR09CA0008.outlook.office365.com (2603:10a6:10:a0::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38 via Frontend Transport; Fri, 24 Mar 2023 06:28:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT055.mail.protection.outlook.com (100.127.142.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.22 via Frontend Transport; Fri, 24 Mar 2023 06:28:27 +0000 Received: ("Tessian outbound fcd8b5fba459:v135"); Fri, 24 Mar 2023 06:28:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ed1532975e96a41f X-CR-MTA-TID: 64aa7808 Received: from a20dd52928cb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CC0B5B0A-A3E9-4016-8A6D-5F6502C7B61F.1; Fri, 24 Mar 2023 06:28:20 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a20dd52928cb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 24 Mar 2023 06:28:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SATpq8S5RRD/ocJ476vex/CbmbnCOfFNXJMVUjQGZP8evXZuyZRdBUaipXPo3+VlO+rKy4p/Ra6XF89g2sUL6rM5v5PGe9u3vDO/KjOk2My2fYIiAcVIoNoWxBz/yxAc/4njJ58c03ALd5LGeXCNcbD2uBOwlW3RBQI0p1NVaKRMLDXe5/jrMNqwkT6EaU4BrIzeZSvLFllsZombBup1nineRhJOBW+ZU+H8X13hF60eli5EWE60Y3BoFSiRIriy2uSxVDwGAZhGeOqeuCuSZfdodf/R95E/RzjirGPFc+zdyR+TUoCnefK5ugF4ZqxhhyUGLOh8EsGYKQRSrjx3aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=72fCpYcyygDheyOWCNZMn4PGxBSXqh60Ot0u3HtSB2w=; b=DzXzHjg8pKjq/uhpD3icxjVc8UTzyhhYA6uk6Rn9JESgDl+aVvA4N9H1HTA21Rzw7Ge2z7FnL35uyzE1ov652GlErhW5Aej2cd1vR3v6ayfuuGTp1nwjNn2bTLHopVKVR+u5USWfXmmXlI5xjBrZDkTARULWTFrhzluEqJ1RwWB0YOTNZPXWS52u0LOaKCyX4SXvMFA3u+DG/sVcv29p76dPWj9uJrD90YcWa9dneeV9XA4olALhLVRvNODsJ3oe6msUE4a7OAzUhL8d3v9YVyNHB/Eoyo7ugqtRwPxHGdDMsoieH+T8WY5CwMnBoJ0atDCGR3at7Kc809LEmOFxYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=72fCpYcyygDheyOWCNZMn4PGxBSXqh60Ot0u3HtSB2w=; b=9BYc9m+W73rat0PrvkAZNrnmBZGU/KlWppldOkuCxrB7dkL+hKWOgGOF0qB4LUJcki1j4Woyi6my/TfDUn385cxrzQMfvHpBLEsvDMPvEcDF2BQYNnCHEyhhCJq2CujXdK3K82mT7cU8gUso9ZuyuhGnJoN6DBI+4YQcmpjTgVk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB10222.eurprd08.prod.outlook.com (2603:10a6:20b:63c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 06:28:18 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::bced:32a3:b77e:90a6%5]) with mapi id 15.20.6178.038; Fri, 24 Mar 2023 06:28:17 +0000 Message-ID: Date: Fri, 24 Mar 2023 06:28:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH, v2] aarch64: Check for valid inferior thread/regcache before reading pauth registers To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20230316103904.1947447-1-luis.machado@arm.com> <20230323105619.9151-1-luis.machado@arm.com> <20230323112551.66e4da4f@f37-zws-nv> <20230323113927.466085b3@f37-zws-nv> Content-Language: en-US From: Luis Machado In-Reply-To: <20230323113927.466085b3@f37-zws-nv> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN6PR05CA0019.namprd05.prod.outlook.com (2603:10b6:805:de::32) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB10222:EE_|DBAEUR03FT055:EE_|AS8PR08MB7323:EE_ X-MS-Office365-Filtering-Correlation-Id: 48d0ccf5-650b-44fb-2d9b-08db2c30fa30 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: iCd5oW3ilipZdnAG8EtQho/qF/s7mIadKJ+S15YSqXPLtp37OV1fM1WUgJd+tcuVuj1pJJYvmjMtBtsLGrg7LDrzggpM/Ga44CSF8XGFBgGsWT4GxnBDW896wWCPmph2S8TylqkxA70WazB709HfR/FOjCHfpEinDR+24Mv+MsZ+x+j/F9iw0ApxyZ7a2GSZYpsjgrhDuGm8RCPV4P/Mx8lcZNiTieVjPc70pWMZLrYUmdZ3HyPMJ0I7zcyLkHYaMeZh20gUVDOOVc9X+ut5uzprdb7AB8B7WIgGCGmQ7vlH61i/UziPdw3YZZj6s8C00i1hEyhApQLWr3B9LzcbMxhnLidDNnERGBsxvpQnmrfxpQKfZ0Ojn7Wbu0UUFCJm4dCT8UacUp31sPVrNKU+QaVqMaxD6S3no/eXIYog4RevRBJVTymszQUDQy8odALj3NRu7z1hY3I7hwwUF+q4M1gocAKCHwFcr2R239PY0Hwy6IVX0vxcC1u/BJLoo/vRou3Mda2D+XPU3/FJcrYkCS2XkP2k7PaypekIOAVkJfhq0NR55FPtruQuYBBCqRKX4ghBoXODq0FPmOLKZCNSyanQErCEc+k6Vvb+u6YrG/MNt1fRzOHzDwXfcfb0wd11SGxCdcH5L6UwgvEkjLoe+Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(451199018)(36756003)(66476007)(8676002)(6916009)(4326008)(66556008)(8936002)(41300700001)(66946007)(478600001)(6486002)(966005)(316002)(44832011)(2906002)(5660300002)(86362001)(31696002)(38100700002)(53546011)(6512007)(6506007)(186003)(26005)(6666004)(83380400001)(2616005)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB10222 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d3302e7b-f1c2-4b8c-9850-08db2c30f3d4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6tnnWzhIyfQDLoRd0WWDFH1ORgR6lqjY1LA6bAM9/XCEFiZVvjnxVXA/y7N48wlsS+gT3YD3Rn5b+QK9L9aqjDehchFapmhT2y84LA4z1m81EK6cK04ra7I3GZ0Hr7LsrD7yUMgHawZAV5agDUyB/g+8cmdHYHbCX5Wgx1GhCRv4aYDXG2co6ybP9DXuB8D1tNfsvwOp3NVqB43MYKJh+PVQiHzul2jBrywST4b6KfHXqKeCZCyLZahbguZpZWjzXw4GfZbsSav0oKndXJxbsmcGtRFDFKuwtdvxIDdqGirM9zxMAXeQe/bQstTo2mZtgZaaeiBaivhvB5A+705+uKDBL4jF25CfhkQZ3SfJ7SnLN3UErdMHaa/3YiS2QEjdNE8vZpMAhF1Bnz2vzL28QSe4U4wv6GX4+NkKoC+vOO3nPiwyNB6uWgKvZrTJmXgQaX59fLPY24xla7RJ/OTh2FIacf7iubJGyA13kMMTxl7loM+cxk6/T1E+3zYtLdJyRzuVITScUiDvqOzSRcq9ZmAkWSeTx0+jzhGWAJZDSEjxgWwogOrWg4yC0FYD/xGHFoMmXGFcVtY3neVr4yG5CdzXmpT7VRbFs8G+Faq7miQxwPZB8AehcCDIjVNm0zuk3JqpM6Pad8+/0Ou+G6c9u470ZLtFmJmwrplYIVzyuz6Thum7pFdy4AgwgBcIldNjjJbxA6hMIcLqxasqI0Qj48hjptfLG02xk+4vZN1Wkt8= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230025)(4636009)(39860400002)(346002)(136003)(376002)(396003)(451199018)(40470700004)(36840700001)(46966006)(40460700003)(478600001)(4326008)(8676002)(5660300002)(53546011)(70206006)(36860700001)(70586007)(6666004)(81166007)(41300700001)(82740400003)(26005)(6862004)(8936002)(44832011)(47076005)(6512007)(6506007)(316002)(186003)(2616005)(336012)(83380400001)(966005)(6486002)(31696002)(36756003)(82310400005)(86362001)(40480700001)(356005)(2906002)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 06:28:27.0570 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 48d0ccf5-650b-44fb-2d9b-08db2c30fa30 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7323 X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/23/23 18:39, Kevin Buettner wrote: > On Thu, 23 Mar 2023 18:32:31 +0000 > Luis Machado wrote: > >> On 3/23/23 18:27, Luis Machado wrote: >>> On 3/23/23 18:25, Kevin Buettner wrote: >>>> On Thu, 23 Mar 2023 10:56:19 +0000 >>>> Luis Machado via Gdb-patches wrote: >>>> >>>>> Changes in v2: >>>>> >>>>> - Dropped helper functions and used inferior_ptid/current_inferior () >>>>> instead.__ Changes are now aarch64-specific. >>>> >>>> A bug which your patch fixes had been reported in Fedora bugzilla; see: >>>> >>>> https://bugzilla.redhat.com/show_bug.cgi?id=2177655 >>>> >>>> I made a scratch build using your v1 patch and one user reported the >>>> bug fixed. >>>> >>>> I've looked over your v2 patch and it looks good to me. >>> >>> Thanks for testing. Andrew B. had pinged me about a report on his end. >>> >>> Hopefully we can get this sorted out soon, as it is quite annoying. >>> >>>> >>>> Kevin >>>> >>> >> >> Worth mentioning that I plan to backport this fix to GDB 13.1, which might require a >> slightly different patch because in GDB 13 this code is linux-specific instead of >> OS-independent. > > In order to apply your v1 patch to (Fedora) GDB 13.1, I first > cherry-picked commit 6d0020873de. I think it might make sense > to do the same for the 13.1 branch. Though that works, it will enable pauth support for bare metal in GDB 13.1. The change could be backported without that particular feature. > > Kevin >