From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Iir9=AZ=suse.de=tdevries@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
	by sourceware.org (Postfix) with ESMTPS id 946813857019
	for <gdb-patches@sourceware.org>; Thu,  4 May 2023 09:12:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 946813857019
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id B46B033930;
	Thu,  4 May 2023 09:12:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1683191550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=inljsi57p42K2nC62ze8RTO1Ckr+DRE7rMgn2OBpd24=;
	b=K7RdBBEacXbkbCm/ZjXTMuKd44brVdpj4vBDq7N52EF3MUTVYjl1JP87pxKH+bu5bWLviR
	OtVpRj+RSK4tOZHFt9PdSkl7RQERbDYCrFn2i23/OyI/sLKvLoRY1jb7ZXKjZna5WD3Y6N
	HGXi+LP80YamGZFcOBVZIaxu6U+xf/g=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1683191550;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=inljsi57p42K2nC62ze8RTO1Ckr+DRE7rMgn2OBpd24=;
	b=yVyprToGELiKvkpYfWCAsBxeqqxl4YTShMa2GR7n3sDGaRA8ilvcGttRgsTDlz9YhrDVnS
	y0ssJoa6t7670UAg==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A08213444;
	Thu,  4 May 2023 09:12:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id 2blwJP52U2R0TwAAMHmgww
	(envelope-from <tdevries@suse.de>); Thu, 04 May 2023 09:12:30 +0000
Message-ID: <f3eca976-5081-4e83-a967-5019298f19d9@suse.de>
Date: Thu, 4 May 2023 11:12:26 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH] [gdb/build] Fix frame_list position in frame.c
Content-Language: en-US
To: =?UTF-8?Q?K=c3=a9vin_Le_Gouguec?= <legouguec@adacore.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20230503175826.4242-1-tdevries@suse.de>
 <7ccea69e-7cce-9016-06a4-e63b3bf16a17@polymtl.ca>
 <da98123c-2495-1b35-16e9-f023e95174a4@suse.de> <877ctoii71.fsf@adacore.com>
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <877ctoii71.fsf@adacore.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 5/4/23 11:01, Kévin Le Gouguec wrote:
> Tom de Vries <tdevries@suse.de> writes:
> 
>> On 5/3/23 20:47, Simon Marchi wrote:
>>
>>> In any case, this LGTM, thanks for doing this.
> 
> Seconded, thanks for getting rid of that if guard.  I find the new state
> of affairs (everything defined in the same unit, in the correct order)
> easier to grok.

Hi Kévin,

thanks for the review and the confirmation.

- Tom