From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125222 invoked by alias); 16 Oct 2017 13:44:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125208 invoked by uid 89); 16 Oct 2017 13:44:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=no version=3.3.2 spammy= X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 13:44:15 +0000 Received: by mail-wm0-f54.google.com with SMTP id q124so3495145wmb.0 for ; Mon, 16 Oct 2017 06:44:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=FjDsQ3P6ytSe90evJbjKKJBdblJIE3Ui6AvzXN5k4F8=; b=Awa3L53qGDeqir3atYtl2kTkO8J2JEfkcL4VPDgB2ib4ogcsr7R0wDeXW0YEHsNwTm yWueGKnhPYvxqfU/LZuD9/smKnJxfDU6d2ZmcmsXdAsNTdMNha3KA0JoS60FphcF+T52 c8/lcUK6toIR8NYSHxpj29CR3h+YfeKol4/i0hAdJBuO9y8JIcG/XLeZB9WooCMPH/7l /uxp1Lk5gPkgqlt51YGr/xCXB0j3SvOlMZbLqbTAkmO8fYCGJOqHmNKD7r0wUTVPid66 l4KZt5Q+VZfE1rYTbcelfo+uP5XaWk6uDSUT5BkulyINhBGiJ6DVUK3P4yoVwdNB9T/+ kC9Q== X-Gm-Message-State: AMCzsaVGdQ8R3YMidrTuizHRLt71NEGhedBE+RzbQA2wxForHgoBmvG4 gOybEAkmVyVvbFtONPjoFqwOTqZVeKM= X-Google-Smtp-Source: ABhQp+R56FAYpA18Cb+YCC8oWAjZYwvWEURilW4pX8FiQRnXzS9hP1imB8SHKZZ+HAt0xQxF9bXmGg== X-Received: by 10.28.181.144 with SMTP id e138mr1042420wmf.115.1508161452701; Mon, 16 Oct 2017 06:44:12 -0700 (PDT) Received: from [192.168.0.150] (bl17-148-124.dsl.telepac.pt. [188.82.148.124]) by smtp.gmail.com with ESMTPSA id 55sm9072088wrw.60.2017.10.16.06.44.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 06:44:11 -0700 (PDT) Subject: Re: [pushed 8.0-branch] [Bug server/22137] gdbserver crashes on hosts with pkru register To: "Tedeschi, Walfred" , "gdb-patches@sourceware.org" References: <4e1810f2-a6cd-1c80-bdc6-6588e8759246@redhat.com> From: Pedro Alves Message-ID: Date: Mon, 16 Oct 2017 13:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00440.txt.bz2 On 10/16/2017 02:20 PM, Tedeschi, Walfred wrote: > >>> > > I also couldn't compile master: >>> > > ../../../binutils-gdb/gdb/probe.c: In function \u2018void >> > parse_probes_in_pspace(const probe_ops*, program_space*, const char*, >> > const char*, const char*, std::vector*)\u2019: >>> > > ../../../binutils-gdb/gdb/probe.c:68:12: error: types may not be defined in a >> > for-range-declaration [-Werror] >>> > > for (struct probe *probe : probes) >>> > > ^~~~~~ >>> > > ../../../binutils-gdb/gdb/probe.c: In function \u2018VEC_probe_p* >> > find_probes_in_objfile(objfile*, const char*, const char*)\u2019: >>> > > ../../../binutils-gdb/gdb/probe.c:213:8: error: types may not be defined in a >> > for-range-declaration [-Werror] >>> > > for (struct probe *probe : probes) >>> > > ^~~~~~ >>> > > >>> > > Are you aware of it? >> > >> > Yes, it's a GCC bug: >> > https://sourceware.org/ml/gdb-patches/2017-09/msg00270.html >> > >> > What is your gcc version? >> > >> > I don't see this myself, but I know that Keith also ran into this recently. If it's >> > easy to work around it, I don't see why not. >> > >> > Does this work for you? >> > > It worked! Thanks, I'll push in a bit. I'm still curious to know your gcc version though. Actually, I'm confused on how it worked for you, since I hadn't fixed the same problem around line "213" quoted above. Are you sure you tested with the same compiler? Thanks, Pedro Alves