From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2072.outbound.protection.outlook.com [40.107.116.72]) by sourceware.org (Postfix) with ESMTPS id 0B36C38560AA for ; Wed, 11 Oct 2023 14:18:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B36C38560AA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFcJ4vut1FkD3dHOJGHvnw33RzEbxlyF/CB1jygHX0SMHUzQdQwE65Ni+yNJXuNwUTY+CHjaPwuHagwPeIPylYR9ru+ahvts7K5ehf7qCTBdJlwWMIUgRrBmH7mUKU2Nc6YHzaAPYYl97ZHgOj+Arwj/InntNLmDjpzLbAYkWbpU993mqxdRxWz5kIok7ScD8NqzKhXSaTajg9WalzrbIVPG881fYYvE44Td3XCCkbtRimdnseceMiJHBm28Y6LB78MzKNhBSqwwWlSmGaTkQ5aIPDD2IRSRbkH7I2fX0psbLWgcklHi7JM0eLRzifYMu5qSY4/MQwtpTq7NYAtJng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1sAczscYOCV4FVkcc/VgWuJ5AYCUE/9x1akvDZLTMMw=; b=DX2VNOHWs5cPgV0MIDtlFEjw5rZghLCxmdx/+/hHodvKm61RSYE8TUsbHFnXAz8mb2rrtVAC5XVKM5KZ8IpM6sAvtCx9UmE9mMrzywWwUBXTSCnKgtje7giQboP7jyZ5TRpEKk9GescLx//CKIvtoO4S5xt37ZKB5CKruhISuTn7phpUbvIW9kKB0wFZDFtBHW1zhl6htT0C+wpdzOCPY6yus2Oc+JU7VK41o4lcMJ8yWjvc7qooGRhVVXn64/c8uptEoQmBAtbWnxh8IQ20an8IhZyv0RW+h7rnkcgpygyVWw2OldZX6nxIQwsuHLb/pfa34I5BD657+QnjHRf/zA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1sAczscYOCV4FVkcc/VgWuJ5AYCUE/9x1akvDZLTMMw=; b=CdeyL9zuWkai725EuIXX5RzK/iCVNR1/fIsmX98TrtAcVPY5u3ZkXCU9XQwm6RvtzImsLXi4bxDdrEEc4eljeObHYSF0Bp4ofVaaf8XYIVrVHHiL2RcddbvHaYQ135BXkJBSnJS6KzxD/zMtnIcpRq2ODikcUO2zNyVcY7a1w1fIgaJZ3QPA3XmoHPcS+pJiVNS8/ojlkm795T5B3tKOWQhsOMdOsJhB8DR3vuPIARN5wJYBZGHFHrWSBw/GYyNwaZ3QnedUJHdeAnnOSHbOnZ+fp/KZxzKLQBL2olShOJYkNCebWGR8JJ2LSz5pfZ0t7JJw/aq2/14dJRzSXSv/ng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT2PR01MB9189.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:bc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.38; Wed, 11 Oct 2023 14:18:25 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2746:9503:a301:a80a%6]) with mapi id 15.20.6863.043; Wed, 11 Oct 2023 14:18:25 +0000 Message-ID: Date: Wed, 11 Oct 2023 10:18:23 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/24] gdb: make interps_notify work with references To: Lancelot SIX Cc: gdb-patches@sourceware.org, Simon Marchi References: <20231010204213.111285-1-simon.marchi@efficios.com> <20231010204213.111285-4-simon.marchi@efficios.com> <20231011084853.uas5bmm7nxnupoyw@octopus> Content-Language: fr From: Simon Marchi In-Reply-To: <20231011084853.uas5bmm7nxnupoyw@octopus> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0353.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6b::27) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT2PR01MB9189:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c2c878b-2cb9-4ed8-cb64-08dbca64eeaa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NJ/VWh9O5Zh+0vji/rOGhxazczFVeF0P7dkbcNSPhU1WBdHEqsuYYp4+jsQNzwfxRmNv5XUjsfeP5S1azDo8tnK7v5YAjpPjoy6pi4PK/APHip85pUTKZXFcP5n1RE1ohuPj+BwCIeJFHZafBbrVo+Dup1amCbwuJGzQdmEPQMdVaSz9+tphIJWKbhT+hr3kFB0D7+8ZOnkrqCW0V6nr0bd+fY0j37zrXPet2a8vUB4UK5NwMJZNd4w3sJlDALso61iqqA5HcVpWFw5ewoj6h9rVbb4XPgncqY6lOiA2n98djrt34jIapOyh+EdcpEO7selPOvaabwIJHS26h/w3JSKQUCc7jraE8Pt4bOcCyYrCIcxV9Z6N/shUY5zjgLUlWsopJmKLhXNOAv5jHRAVk8iXL9OJsttGxtGfglHXrWdcRMg49UEWk/7k9l72ptISeKRMbqscl/Wy8ObMpuuqH9Wnme8v8u4Tk4PjngZxUKigMbOFjN7lLX/RXJWQHMJW7ge5+ilXfsTUzq8xUxI1jdtO5Bzgj0tUFQ86Ri65wTV+eUZEluO70G/SI0KbNyZpkjrsFWoWy4ektdh1d7BpUDzOiZvVgJqz9osMc8PQKbDCu3fAwNNxUOfvnIjvWYR+CE+7sTBbYbDnE68U2oCtjg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(346002)(136003)(366004)(39830400003)(230922051799003)(1800799009)(186009)(64100799003)(451199024)(66556008)(31686004)(53546011)(6512007)(36756003)(38100700002)(478600001)(26005)(2906002)(66476007)(44832011)(8936002)(4744005)(6486002)(6506007)(2616005)(31696002)(8676002)(6916009)(4326008)(41300700001)(316002)(66946007)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUVWOFpvRjNPY1ovQ1kzUVl2UDZ2amVKVFJFNjRUZGI1U3pYbGV6bUcrSksv?= =?utf-8?B?Mjh2V2ZmNVNRb1hSLy9SU3I3V255NlJWaHhmQWFVUTJGbC85L3VkaTUxK0Qr?= =?utf-8?B?ME1FanFNbzUzbWdqS0d4N3p2dldMK1ZyQU96emUzZEppTGNiUG5TSzE0ZUZq?= =?utf-8?B?d2xrY1RCVlNPVXFmdWo3MklxMFQ1QTZqdDdKdEwyNHhmWGQ0S053Zk94OUE3?= =?utf-8?B?bHEwV2VaSlpyR1FTZGVsbTdsbHRPamxMUnBKNzJISG16N1ZjZTBrbDJIaGl6?= =?utf-8?B?M3pCSU13cVFEMzFHb09qUjVRU0czbnV5ZWd5VDNadnRPdXoxVkpaV1VPOXVI?= =?utf-8?B?TDBvMXY1SDVzY0d0VXFYS0lZRUZXUnlKRGRDeEtYWjNOZ1ZwUC9RamQ3SU1t?= =?utf-8?B?MkpGeU00K0N1Ym1rdUJJTGhkei94Mzg4Y0VYbW1QWEl6Z2ZLcGk0d0hTOEJj?= =?utf-8?B?YmttN2hsTmNubEJLOGdWYWFsZFZTT2FjZUZBWk8rTUMwQUt0MGhBVFBJaVA5?= =?utf-8?B?Zll6NXE2YTlBZTJyYUxBRG00MW9VNkoybmRtaE9kSnc4a0hhSXQwdTNDOGlR?= =?utf-8?B?azlXcFJnWHF2Q216TStYcnI0dnk0Q1hJUURrTDk2S1JSMzNESS82ODR4K3pp?= =?utf-8?B?ZitnbUpUT243Z2g3NFN6VkgxNzk2T2luN2lSWEt6TWN1K2UvUG9jTm9zSzlV?= =?utf-8?B?eTRQT2VHS0lPd3B6TG54TTZRMXZ2NDZKbVJuQ010TzRnL1BRLzFNQ3I3SW9S?= =?utf-8?B?QWkvcU85SHFZK1puR0x6bHZYNjlhTFZHejlaeGNDeXJUSFFqNEhjZXpOMG4y?= =?utf-8?B?TjVRbnhLbC8yTmM3ZnJRQVZpM29WbTM2KzBsYUg5amRQd0dtVDJra1hlbDdS?= =?utf-8?B?OXNYSHYwcE5CS1oxdmdWcHR6YTBjTzJkemJXekd1MVZGZ0pEbGpzNXFOZXV2?= =?utf-8?B?dUZ4WkdjOUFHVDNGeFNtK0pxdThQMEc1bjJWUzVnS1FRMWRyTVVZSFNqc3dm?= =?utf-8?B?Y3JZeUsrdE9YQ2tWREF2R3RRLzdoWDRJcnlRb1JpSTFadnV4MFI0aExBSXln?= =?utf-8?B?Z2lob1laZ2hvWU94cTArSXBaK0tLczhsbC9qdm5yTWJIdXVsM2ZDUzdRV05w?= =?utf-8?B?QXZDN0hwRFlFenpiVEs4L05xZnBnbzV5eFNoT1VManJybUpOK1VrSldNaDRr?= =?utf-8?B?dGNXZDEwYXJxY0RTNnJRUGlXeCtkWlpycVJIQStERTNyMDkwblQ5KzJhQWY4?= =?utf-8?B?K3BCZkVDMnF5c01TcC96bzZVNTA1WGhvMzVvcmhabXJJN0UxSi9zZld0RmNI?= =?utf-8?B?Nnp3b09SeHFkeXhBN3ByN1hjN1h6NjZHa21UcU04Vmk1WTNVL2tkQUlGL2NS?= =?utf-8?B?YW4yeEdwTmlIYzhKajhmS3VaRFZDcFdLMWVZWDlWNmNmTHBkTmNBQmM5TEIr?= =?utf-8?B?ZnE4eXo5ZlVhdnVrYWVkQWxZb3hVWThjSWJEOXlZK2lYZ3ExQ2Q4NkUvRHR4?= =?utf-8?B?Tm8xVDQ5TWl6SGRyeXp1S3Q3UXV2SmUyUUdzQzIwUG5kQ0U3R2doY3N5NEk5?= =?utf-8?B?bjdpckRnLzR5eVk3bUphMHdESnpUQXIyWE9JYlBFZEZDNGVwY1dOdzQ2NEpt?= =?utf-8?B?REg0WkhNODhtdTEzTW55Rm1PeDFMZXpBSmJEN0Y1cURFT0d3ZjQ0cXAxR0Na?= =?utf-8?B?YzhsVHFtOS95c1JSRXRVUmFwc2FEMmttUElCT3Fmd3VMa2FTYTQ5aTdON3VM?= =?utf-8?B?OFlrb05xK0V4UFJXRmZaU2U1aGJYZWRkTUhJcldzNFNsRUczUU1tRG5qQ25h?= =?utf-8?B?UXNwOXBPWDJCKzM1SUFoTGwvNmVvQUxtN2JTZit3ZWNwaG4xZnlJd3Z5Sndy?= =?utf-8?B?Qit2WHNCQzU0QUprYWNuaTBaOTBFQ1BNWFYvQmNMY0xNMDR3ZVI0b2xLQytv?= =?utf-8?B?a3Vxb25IRHJxZEtQdUJ0Q0hXQ2VZbXVHTkR4empTQlVZMXRaQVpMY1RoQUFJ?= =?utf-8?B?ckF0T0FLWGVPTWk0VUk5VXRaTHVlTEYzTFRaZDFPdC93ZmN5RHZJc1AxSUdV?= =?utf-8?B?NWd1RFdIZTM0cUZhSXFGdDF4MGJSbkNXTjgzbEtLU3N5Sld0azFySi8yUGdh?= =?utf-8?Q?XgZurf5gAJMlPB6ci8HgaiLHv?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c2c878b-2cb9-4ed8-cb64-08dbca64eeaa X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 14:18:25.4752 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EL1cAK5bCYgSZls7WWFgSHZuyHSu5iWChtybyrBP8n5zUL3Q0ZrVf+fNcUVt/8toyj5k2Mjwcq0ig75DD/NXJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9189 X-Spam-Status: No, score=-3038.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/11/23 04:48, Lancelot SIX wrote: >> diff --git a/gdb/interps.c b/gdb/interps.c >> index f91b2b62c1ba..62a30583e8c0 100644 >> --- a/gdb/interps.c >> +++ b/gdb/interps.c >> @@ -358,15 +358,15 @@ current_interpreter (void) >> /* Helper interps_notify_* functions. Call METHOD on the top-level interpreter >> of all UIs. */ >> >> -template >> +template >> void >> -interps_notify (void (interp::*method) (Args...), Args... args) >> +interps_notify (MethodType method, Args&&... args) >> { >> SWITCH_THRU_ALL_UIS () >> { >> interp *tli = top_level_interpreter (); >> if (tli != nullptr) >> - (tli->*method) (args...); >> + (tli->*method) (std::forward(args)...); > ^ > > Space missing before the "(". > > Best, > Lancelot. Thanks, fixed locally. Simon