From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 471AE3858D28 for ; Wed, 20 Mar 2024 18:58:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 471AE3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 471AE3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710961091; cv=none; b=AN62BI/lCNYah3SaieN9dx8oR2JnsBQ489sIZbLs7Sd43k6ddMc3zAdWaN31KP/xawEWCvEVxLu4La49iVWS3xCkaBZwKsQ9KnWp6sq4TrSNkv/gVJsZ1ugH+JXvDxRu7pi+9aHBWqsSWObOiWunE0NpG+FLljeLRJna75pXenc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710961091; c=relaxed/simple; bh=Z8FFc5+XlvptxcekiVm2Rkrr0PDSG8rd7YW19eio7GY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=DLvVUG5TpDuggYKiy4ElFPqgt/TOz4tMiwdDV8bP7ozEtzyDpld0jl9Ch6Nz5OdzMhuyQLnaP1geHHecj7IaKIrpd/j4CLf1HttdQVnOxfE9l8HV4HHtE2FBCNlfCSNmNSYSnPl4WOIvwltR+iKbgz9fUm0v0lsZlfldQvl52qQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1710961089; bh=Z8FFc5+XlvptxcekiVm2Rkrr0PDSG8rd7YW19eio7GY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=VErYSulWl5pUQCTlSu6PsdeQW9tCrci1gQ6/hLw68f4IALb5qwO0tlOYaYfx11NZu Li7OlDnnabYnzeQwxqXlF+dJkFj3LBLL0Qq7oMnnHMKf5nzgCVmlA316NyVdpNYj7Y 3mfmKaOwBONFKyO9kvJwMMUhHEO9RXDaV8OdIXmc= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9EB201E08C; Wed, 20 Mar 2024 14:58:09 -0400 (EDT) Message-ID: Date: Wed, 20 Mar 2024 14:58:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 8/9] Suppress some "undefined" warnings from flake8 Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20240319-more-flake8-v1-0-893549dbed75@adacore.com> <20240319-more-flake8-v1-8-893549dbed75@adacore.com> From: Simon Marchi In-Reply-To: <20240319-more-flake8-v1-8-893549dbed75@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/19/24 13:33, Tom Tromey wrote: > flake8 warns about some identifiers in __init__.py, because it does > not realize these come from the star-imported _gdb module. This patch > suppresses these warnings. > --- > gdb/python/lib/gdb/__init__.py | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py > index 2ff1f95c8fd..cff2f3afa49 100644 > --- a/gdb/python/lib/gdb/__init__.py > +++ b/gdb/python/lib/gdb/__init__.py > @@ -56,15 +56,14 @@ class _GdbFile(object): > self.write(line) > > def flush(self): > - flush(stream=self.stream) > + flush(stream=self.stream) # noqa: F405 So, this calls _gdb.flush? I would prefer if those calls were qualified (not relying on the star import), so that we wouldn't have to guess where these symbols come from. Is it possible to do, in addition of having the star import (needed to re-export stuff)? Simon