Re: [PATCH][gdb/testsuite] Support .debug_aranges in dwarf assembly

[Simon Marchi <simon.marchi@polymtl.ca>]

> OK, I've integrated the subst bit (and made it conditional, that was
> still missing).  Also added the subst part for the default arguments,
> and added a proper log message.  Any further comments?

LGTM.

> [ FWIW, a bit of bike-shedding.  I could imagine a pattern where you
> pair a proc <name> and <name>_ like this:
> ...
>   proc arange_ { options start len } {
>     ...
>   }
>   proc arange { start len } {
>     arange_ {} start len
>   }
> ...
> to be able to do:
> ...
>   arange $start $len
> ...
> and:
> ...
>   arange_ { comment "bla" } $start $len
> ...
> which would be slightly less annoying that having to specify empty
> options. ]

I don't mind either way.  Even nicer would be to allow both:

  arange $start $len
  arange { comment "bla" } $start $len

But that would probably require going back to using args, which breaks
the purpose of what you're doing here.

Just to understand how we can do this in a systematic and predictable
way, would you do it just for "arange" or would you do it for all procs
of this style, like "cu"?  In some cases (like cu), the case of having
options is more common than the case of not having options.  So would
you still have "cu" without options and "cu_" with options?

Simon