From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id CE8523858C3B for ; Sun, 29 Aug 2021 19:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE8523858C3B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 17TJshN7010248 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 29 Aug 2021 15:54:48 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 17TJshN7010248 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 375971EE13; Sun, 29 Aug 2021 15:54:42 -0400 (EDT) Subject: Re: [PATCH][gdb/testsuite] Support .debug_aranges in dwarf assembly To: Tom de Vries , Tom Tromey , Tom de Vries via Gdb-patches References: <20210826115625.GA22715@delia> <87eeafovsa.fsf@tromey.com> <40b7d95e-cc02-38c7-5406-0fc83a2a1b28@polymtl.ca> <3ece042f-2e05-66dd-2f18-0ba2555a76dd@polymtl.ca> <27d5091f-19e7-1f7f-8f0c-06e841c29d79@polymtl.ca> From: Simon Marchi Message-ID: Date: Sun, 29 Aug 2021 15:54:42 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 29 Aug 2021 19:54:43 +0000 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Aug 2021 19:55:00 -0000 > OK, I've integrated the subst bit (and made it conditional, that was > still missing). Also added the subst part for the default arguments, > and added a proper log message. Any further comments? LGTM. > [ FWIW, a bit of bike-shedding. I could imagine a pattern where you > pair a proc and _ like this: > ... > proc arange_ { options start len } { > ... > } > proc arange { start len } { > arange_ {} start len > } > ... > to be able to do: > ... > arange $start $len > ... > and: > ... > arange_ { comment "bla" } $start $len > ... > which would be slightly less annoying that having to specify empty > options. ] I don't mind either way. Even nicer would be to allow both: arange $start $len arange { comment "bla" } $start $len But that would probably require going back to using args, which breaks the purpose of what you're doing here. Just to understand how we can do this in a systematic and predictable way, would you do it just for "arange" or would you do it for all procs of this style, like "cu"? In some cases (like cu), the case of having options is more common than the case of not having options. So would you still have "cu" without options and "cu_" with options? Simon