From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id ADFD438618CD for ; Mon, 13 Nov 2023 14:07:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ADFD438618CD Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ADFD438618CD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884438; cv=none; b=g2+xoRNZmn0Ro+DajKuuT8v/r9HrBbVLMoHTVtFHaXMDFMCVWIGTwvM7ip642/sQroiY2BLlO1YhpmXfsJjmyk849UPVVTWx1642Q3BFoE+84SQYSR+gPtZhyA9DoBWP+VYa5/Nq2Pgfniqd/55CDmKO4wyiahTQoqgoltGfpts= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699884438; c=relaxed/simple; bh=kjXI4TAewmJGXnxe55/Z2W3lQCtww/jQxYsBw36cclo=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=AmxSmIUJFCakjjTUM+4LUf/CDTeqIOubrS/tDaQ5rWWZG8ip1U3DBKTM6FuRk4LMuiohwthEtfmcWkANUaEKO7c515JTWA+qJY1qnuPsV2J0z8xfImpAl+I/E+PpGmqXwRGj7vQ78xlLFhPJGurCgrDcWZH4KoUP/FldbWsziiI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4084095722aso37285875e9.1 for ; Mon, 13 Nov 2023 06:07:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699884435; x=1700489235; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5mqeAiH7BC6+QWYXdtY9jw00sdyksFRuUty/Kcj4BgA=; b=mnuu6OT/J4GiDEBhWac0BZZ8m+zki4FRgUvmmzpStQDbyUlhB1p6KJrHmy0SkyK/Ra NqBo16ryX/5liZ3MB+BWwwIcwCY9e2nnfQ0mJ8rStrYYBUvAoFDim/OK/LoDS1RXwwcB bmbys0DMXhTyMXgdpeuruLrLdR+tFvcwCllhIL0npy9o75UXtJtK4G7icfYJr1mBkpju l4FZDGCvBNly/QTq1pMhcIF/xFZbFZI2LRNFJHlDCVw2gq86sJgpKhQI5HZHzcPK+y/Q 0bLmonw836nPdmN8dJJVE+cs1ZMgQxmiVxLmxKa8vBZeIESGYocr4a5wmh0bMA1wqjwk cqHg== X-Gm-Message-State: AOJu0YwDu7eGLw4oE4sfxviGEI1GT8qkMOzW2/zhv6j1EqchotVHZ9OX Izzj/ijbgKv71MLGMY20WLwcHa7em6k= X-Google-Smtp-Source: AGHT+IGI9zT7WVmnEO/i6AF6XfMLg3xcc1nkmJd1vDyCtkq9XP5H5rMBEd9sXTn2EQ1zPtT2Azm+JQ== X-Received: by 2002:a5d:4574:0:b0:32f:b902:e018 with SMTP id a20-20020a5d4574000000b0032fb902e018mr4039496wrc.25.1699884435200; Mon, 13 Nov 2023 06:07:15 -0800 (PST) Received: from ?IPV6:2001:8a0:f91e:1a00:8060:1e54:fb28:9635? ([2001:8a0:f91e:1a00:8060:1e54:fb28:9635]) by smtp.gmail.com with ESMTPSA id w7-20020adff9c7000000b0032fbd0c7d04sm5525593wrr.55.2023.11.13.06.07.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 06:07:14 -0800 (PST) Message-ID: Date: Mon, 13 Nov 2023 14:07:14 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/31] Thread options & clone events (Linux GDBserver) To: Andrew Burgess , gdb-patches@sourceware.org References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-11-pedro@palves.net> <87h6rk3cjo.fsf@redhat.com> Content-Language: en-US From: Pedro Alves In-Reply-To: <87h6rk3cjo.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-06-06 15:12, Andrew Burgess wrote: > Pedro Alves writes: >> @@ -3527,7 +3538,8 @@ linux_process_target::wait_1 (ptid_t ptid, target_waitstatus *ourstatus, >> >> /* Break the unreported fork relationship chain. */ >> if (event_child->waitstatus.kind () == TARGET_WAITKIND_FORKED >> - || event_child->waitstatus.kind () == TARGET_WAITKIND_VFORKED) >> + || event_child->waitstatus.kind () == TARGET_WAITKIND_VFORKED >> + || event_child->waitstatus.kind () == TARGET_WAITKIND_THREAD_CLONED) > > Can we not use: > > if (is_new_child_status (event_child->waitstatus.kind ())) > > here? > We can! Done. > I almost asked here: do we really need to check for THREAD_CLONED here, > given the body of the `if` only changes the `fork_relative` field, which > surely is only related to forks, right? > > ... but then I dug deeper and spotted that the field also used for clone > events now, so: I wonder if we should rename `fork_relative` to > something better, maybe `fork_clone_relative`, or maybe go generic with > something like `related_lwp`? > > It just seemed a little confusing (to me). > > But otherwise, this patch looks good. > I've renamed the field to just "relative". That made me spot a few more places where the comments could be adjusted to not refer only to "fork". > Reviewed-By: Andrew Burgess Thanks!