From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 289DD38582B3 for ; Mon, 18 Dec 2023 14:41:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 289DD38582B3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 289DD38582B3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=134.134.136.31 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702910470; cv=none; b=XStpOQ8bWqnJP4zs9cwpQUa8/sCQ6z4L7ecCwUsQ476u8NdZgAZ6PgZXfjm/QmUm/rFWuuUrrLNezriBfYSmS6cOHWaiXrqWhBVuMfVTIrZH98b3xDR+YlpQe5gzfYR3IpJjC1++9G84MlGfA8Nsc8I6ydtjtbK07R8du7LnP+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702910470; c=relaxed/simple; bh=s/djDY/0D8a/JUanuIZiA+lcB5/08pgXsPH9L3hB7pM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=ftO0ICPXbEtFO8gjvwYP9ED7c/iA6FZCi91mCq81VoEpazEd+RMt6LdFephOFEbK/8wXockYvkTZ3uN08uta9ymUWHn3HDIH3dFxLJgUuS4i0Wxk7RQZF7zWmGGL661WrtRO+cPWiktdZmZURfvUKuh6Qbd+6Zgp/LtfC9v8mnU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702910469; x=1734446469; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=s/djDY/0D8a/JUanuIZiA+lcB5/08pgXsPH9L3hB7pM=; b=Wgg9TKmc6pG3VPY8yt4fBedWvV40uBNK9COX6GS4nLG3UMDwl5LkdYbB Vm9jEQcx/IPkqzWAp8OPzPhLOuwGnPlWyqb0oqO/xcJVo9Unw8cVnhBGq oiVaIztqSjNoJqXWtXAp2sXMigxODqJaVZ4XGLsIwXR+yW+Y6ifrlXUJf peInuow0W8okqO/Oevcgxt1snvWmukKbxDf9wwhxjFjzXbwSc4ocjvgqY RlPYqvMj9WS/2jPJ0lwF+h8ezMPMVJCukLvp4+WVoFdipehCFtrslNH7w bvunJVAAfU4p9ILX/yQrTAIVf74o4V5ip02DiLo0XQnPZMiNBcELwRo7B A==; X-IronPort-AV: E=McAfee;i="6600,9927,10928"; a="459840764" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="459840764" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 06:41:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="775602909" X-IronPort-AV: E=Sophos;i="6.04,285,1695711600"; d="scan'208";a="775602909" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2023 06:41:07 -0800 From: Tankut Baris Aktemur To: gdb-patches@sourceware.org Subject: [PATCH v4 1/2] gdb/regcache: return REG_UNAVAILABLE in raw_read if NOT_AVAILABLE_ERROR is seen Date: Mon, 18 Dec 2023 15:40:42 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In regcache's raw_read, it is possible that 'raw_update' fails with an exception. This could happen, for instance, if the debugged thread is already exited and the target cannot fetch its registers. Catch the exception and return REG_UNAVAILABLE if the error is of kind NOT_AVAILABLE_ERROR. This makes clients' lives easier. Regression-tested on X86_64-Linux using the unix, native-gdbserver, and native-extended-gdbserver board files. --- gdb/regcache.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gdb/regcache.c b/gdb/regcache.c index 6140a05f02b..0ed433aa182 100644 --- a/gdb/regcache.c +++ b/gdb/regcache.c @@ -616,7 +616,17 @@ readable_regcache::raw_read (int regnum, gdb::array_view dst) assert_regnum (regnum); gdb_assert (dst.size () == m_descr->sizeof_register[regnum]); - raw_update (regnum); + try + { + raw_update (regnum); + } + catch (const gdb_exception_error &ex) + { + if (ex.error != NOT_AVAILABLE_ERROR) + throw; + + m_register_status[regnum] = REG_UNAVAILABLE; + } if (m_register_status[regnum] != REG_VALID) memset (dst.data (), 0, dst.size ()); -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928