From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by sourceware.org (Postfix) with ESMTPS id 6995A3944186 for ; Fri, 21 Oct 2022 21:08:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6995A3944186 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f49.google.com with SMTP id 186-20020a1c02c3000000b003c6c154d528so5959609wmc.4 for ; Fri, 21 Oct 2022 14:08:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IgilSc/ueLgTkBtX1FeaK6XEWEamz9jawjBf1bN6Kk4=; b=7azZP7/n92E0pUD/t2Z6ILezWjfVawgwF0/vaxIsKpYbC3yQ1R+q/7YUiChLAUS7Cf nCvzsJcAn2bg/EHNzsQzrrtePhZVo/lUMKk94qAsuB6usUQ/i+KVMWd0HqF55TlhF7uD wBYGn7PQ3NUiScX55COWaMbpIJAlIEbjzgN/DgHwfISGDqYZc+yaZ9+DU1Fyu9ezyz6o 0934i2csrSztnP7fTk4VUbAw042RVDbEe4BMf8dGQ5Udql/qb45RDJwbRQx6zhPulVXM I95bDYjZNW1hGS9YIXFlpDCpVcag9dZYE6CMF023MkPDGbGC9ABoXnsecgaxLNCG+Kq3 0OrA== X-Gm-Message-State: ACrzQf2S73Kcn0sgFCUDNLu1WhDtPuCfCDT+qkiPsi8gVcexdoHInI1n 418pX3JM/M2AS7S9nSftzEOJkT3CEUDz5Q== X-Google-Smtp-Source: AMsMyM7D+wMclH7jtHjJfE/g0veukUDPV0uhBQDGWzHZkevz/Q9fxw5fou2P3T9GwF5ANs8Q+oWFGw== X-Received: by 2002:a1c:acc5:0:b0:3c6:eebf:feee with SMTP id v188-20020a1cacc5000000b003c6eebffeeemr14482980wme.122.1666386470040; Fri, 21 Oct 2022 14:07:50 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653? ([2001:8a0:f93a:3b00:e038:5cdc:b8bf:4653]) by smtp.gmail.com with ESMTPSA id g12-20020a05600c4ecc00b003c6f8d30e40sm640009wmq.31.2022.10.21.14.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 14:07:49 -0700 (PDT) Subject: Re: [PATCH v3 4/4] gdb/python doc: Move unwinder skeleton code To: Eli Zaretskii Cc: ptsneves@gmail.com, gdb-patches@sourceware.org References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220603160139.136115-1-ptsneves@gmail.com> <20220603160139.136115-4-ptsneves@gmail.com> <83wndxbtwn.fsf@gnu.org> <8ed127eb-221b-2b85-1019-1968060f68bc@palves.net> <83y1u0dfjm.fsf@gnu.org> <2ad190e6-7892-d3f6-3426-46878c87a4fa@palves.net> <83o7uwdaq8.fsf@gnu.org> From: Pedro Alves Message-ID: Date: Fri, 21 Oct 2022 22:07:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <83o7uwdaq8.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2022 21:08:35 -0000 Hi, On 2022-09-30 6:37 p.m., Eli Zaretskii wrote: >> Cc: ptsneves@gmail.com, gdb-patches@sourceware.org >> From: Pedro Alves >> Date: Fri, 30 Sep 2022 17:41:50 +0100 >> >> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi >> index 2692211f388..4a7b047c3e0 100644 >> --- a/gdb/doc/python.texi >> +++ b/gdb/doc/python.texi >> @@ -2861,21 +2861,21 @@ class MyUnwinder(Unwinder): >> >> @end smallexample >> >> -@subheading Registering a Unwinder >> +@subheading Registering an Unwinder >> >> -An object file, a program space, and the @value{GDBN} proper can have >> -unwinders registered with it. >> +Object files and program spaces can have unwinders registered with >> +them. In addition, you can also register unwinders globally. >> >> -The @code{gdb.unwinders} module provides the function to register a >> +The @code{gdb.unwinders} module provides the function to register an >> unwinder: >> >> @defun gdb.unwinder.register_unwinder (locus, unwinder, replace=False) >> -@var{locus} is specifies an object file or a program space to which >> -@var{unwinder} is added. Passing @code{None} or @code{gdb} adds >> -@var{unwinder} to the @value{GDBN}'s global unwinder list. The newly >> -added @var{unwinder} will be called before any other unwinder from the >> +@var{locus} specifies which unwinder list the @var{unwinder} is >> +prepended to. It can be either an object file, a program space, or >> +@code{None}, in which case the unwinder is registered globally. The >> +newly added @var{unwinder} will be called before any other unwinder from the >> same locus. Two unwinders in the same locus cannot have the same >> -name. An attempt to add a unwinder with already existing name raises >> +name. An attempt to add an unwinder with an already existing name raises >> an exception unless @var{replace} is @code{True}, in which case the >> old unwinder is deleted. >> @end defun > > That's fine, but let's avoid passive tense where we can (and make the > sentence easier to grasp while at that). So: > > @var{locus} specifies to which unwinder list to prepend the > @var{unwinder}. > Finally done, and merged. Thanks, Pedro Alves