From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 0C6573858C52 for ; Mon, 22 May 2023 09:09:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0C6573858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0AA401FDB5; Mon, 22 May 2023 09:09:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684746590; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2bgjB4s6PY2fhfnKxjqWN8xqVHzPnyzexAXHJ1RslOk=; b=TKk00zTwP00SlW07hjZURZV1DHahituhjihTItieMCtc3TTMOzmz3x5W4WnhsFcY4PTP52 3tJfBmOOvoynMvt59kUTZ/isrKJ4PCO0NVpXicaPdVGMEEN246pQ5M2LJTpNT5n9+uMOqS gsuKVpour/mP9+jCZRevGH07CwOtZ/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684746590; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2bgjB4s6PY2fhfnKxjqWN8xqVHzPnyzexAXHJ1RslOk=; b=6CdjqbneiIbJqhXy0YlncFpOjqPzq32FrR0+5XhK6MsbmdtM2/5dCOj5CziaZxyIRIf721 QyvDh2UZLVw/acCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E215513336; Mon, 22 May 2023 09:09:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id MtItNV0xa2T7aQAAMHmgww (envelope-from ); Mon, 22 May 2023 09:09:49 +0000 Content-Type: multipart/mixed; boundary="------------jvzevqzacH3O17hJ7c9xbfuQ" Message-ID: Date: Mon, 22 May 2023 11:09:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] [gdb/tui] Factor out border-mode help text Content-Language: en-US To: gdb-patches@sourceware.org Cc: Tom Tromey References: <20230521195933.5351-1-tdevries@suse.de> From: Tom de Vries In-Reply-To: <20230521195933.5351-1-tdevries@suse.de> X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------jvzevqzacH3O17hJ7c9xbfuQ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/21/23 21:59, Tom de Vries via Gdb-patches wrote: > I noticed that the help texts for tui border-mode and tui active-border-mode > are similar. > > Factor out the common part into macro HELP_ATTRIBUTE_MODE. > This is a v2, which uses c++ std::string instead of a macro. OTOH, it changes the translation boundaries, and I'm not sure if the new parts still classify as "entire sentence". Then again, I was not able to find any files containing translations for gdb, so perhaps it doesn't matter. Thanks, - Tom --------------jvzevqzacH3O17hJ7c9xbfuQ Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-gdb-tui-Factor-out-border-mode-help-text.patch" Content-Disposition: attachment; filename="v2-0001-gdb-tui-Factor-out-border-mode-help-text.patch" Content-Transfer-Encoding: base64 RnJvbSA5ZDlhZjM2MGYwNzMyY2M5MmRlNTRjNGQ4NmE4NjgxNjQ0NGYxOTk2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFNhdCwgMjAgTWF5IDIwMjMgMTM6MDc6NDAgKzAyMDAKU3ViamVjdDogW1BBVENI IHYyXSBbZ2RiL3R1aV0gRmFjdG9yIG91dCBib3JkZXItbW9kZSBoZWxwIHRleHQKCkkgbm90 aWNlZCB0aGF0IHRoZSBoZWxwIHRleHRzIGZvciB0dWkgYm9yZGVyLW1vZGUgYW5kIHR1aSBh Y3RpdmUtYm9yZGVyLW1vZGUKYXJlIHNpbWlsYXIuCgpGYWN0b3Igb3V0IHRoZSBjb21tb24g cGFydCBpbnRvIHN0ZDo6c3RyaW5nIGhlbHBfYXR0cmlidXRlX21vZGUuCgpUZXN0ZWQgb24g eDg2XzY0LWxpbnV4LgotLS0KIGdkYi90dWkvdHVpLXdpbi5jIHwgMzUgKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25z KCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nZGIvdHVpL3R1aS13aW4uYyBi L2dkYi90dWkvdHVpLXdpbi5jCmluZGV4IDY3MTBiM2UxN2U1Li5iYzY5OWNlMDA4MCAxMDA2 NDQKLS0tIGEvZ2RiL3R1aS90dWktd2luLmMKKysrIGIvZ2RiL3R1aS90dWktd2luLmMKQEAg LTEyMTksMzQgKzEyMTksMzkgQEAgVGhpcyB2YXJpYWJsZSBjb250cm9scyB0aGUgYm9yZGVy IG9mIFRVSSB3aW5kb3dzOlxuXAogCQkJc2hvd190dWlfYm9yZGVyX2tpbmQsCiAJCQkmdHVp X3NldGxpc3QsICZ0dWlfc2hvd2xpc3QpOwogCi0gIGFkZF9zZXRzaG93X2VudW1fY21kICgi Ym9yZGVyLW1vZGUiLCBub19jbGFzcywgdHVpX2JvcmRlcl9tb2RlX2VudW1zLAotCQkJJnR1 aV9ib3JkZXJfbW9kZSwgXygiXAotU2V0IHRoZSBhdHRyaWJ1dGUgbW9kZSB0byB1c2UgZm9y IHRoZSBUVUkgd2luZG93IGJvcmRlcnMuIiksIF8oIlwKLVNob3cgdGhlIGF0dHJpYnV0ZSBt b2RlIHRvIHVzZSBmb3IgdGhlIFRVSSB3aW5kb3cgYm9yZGVycy4iKSwgXygiXAotVGhpcyB2 YXJpYWJsZSBjb250cm9scyB0aGUgYXR0cmlidXRlcyB0byB1c2UgZm9yIHRoZSB3aW5kb3cg Ym9yZGVyczpcblwKKyAgY29uc3Qgc3RkOjpzdHJpbmcgaGVscF9hdHRyaWJ1dGVfbW9kZSAo XygiXAogICAgbm9ybWFsICAgICAgICAgIG5vcm1hbCBkaXNwbGF5XG5cCiAgICBzdGFuZG91 dCAgICAgICAgdXNlIGhpZ2hsaWdodCBtb2RlIG9mIHRlcm1pbmFsXG5cCiAgICByZXZlcnNl ICAgICAgICAgdXNlIHJldmVyc2UgdmlkZW8gbW9kZVxuXAogICAgaGFsZiAgICAgICAgICAg IHVzZSBoYWxmIGJyaWdodFxuXAogICAgaGFsZi1zdGFuZG91dCAgIHVzZSBoYWxmIGJyaWdo dCBhbmQgc3RhbmRvdXQgbW9kZVxuXAogICAgYm9sZCAgICAgICAgICAgIHVzZSBleHRyYSBi cmlnaHQgb3IgYm9sZFxuXAotICAgYm9sZC1zdGFuZG91dCAgIHVzZSBleHRyYSBicmlnaHQg b3IgYm9sZCB3aXRoIHN0YW5kb3V0IG1vZGUiKSwKKyAgIGJvbGQtc3RhbmRvdXQgICB1c2Ug ZXh0cmEgYnJpZ2h0IG9yIGJvbGQgd2l0aCBzdGFuZG91dCBtb2RlIikpOworCisgIGNvbnN0 IHN0ZDo6c3RyaW5nIGhlbHBfdHVpX2JvcmRlcl9tb2RlCisgICAgPSAoc3RkOjpzdHJpbmcg KCJcCitUaGlzIHZhcmlhYmxlIGNvbnRyb2xzIHRoZSBhdHRyaWJ1dGVzIHRvIHVzZSBmb3Ig dGhlIHdpbmRvdyBib3JkZXJzOlxuIikKKyAgICAgICArIGhlbHBfYXR0cmlidXRlX21vZGUp OworCisgIGFkZF9zZXRzaG93X2VudW1fY21kICgiYm9yZGVyLW1vZGUiLCBub19jbGFzcywg dHVpX2JvcmRlcl9tb2RlX2VudW1zLAorCQkJJnR1aV9ib3JkZXJfbW9kZSwgXygiXAorU2V0 IHRoZSBhdHRyaWJ1dGUgbW9kZSB0byB1c2UgZm9yIHRoZSBUVUkgd2luZG93IGJvcmRlcnMu IiksIF8oIlwKK1Nob3cgdGhlIGF0dHJpYnV0ZSBtb2RlIHRvIHVzZSBmb3IgdGhlIFRVSSB3 aW5kb3cgYm9yZGVycy4iKSwKKwkJCWhlbHBfdHVpX2JvcmRlcl9tb2RlLmNfc3RyICgpLAog CQkJdHVpX3NldF92YXJfY21kLAogCQkJc2hvd190dWlfYm9yZGVyX21vZGUsCiAJCQkmdHVp X3NldGxpc3QsICZ0dWlfc2hvd2xpc3QpOwogCisgIGNvbnN0IHN0ZDo6c3RyaW5nIGhlbHBf dHVpX2FjdGl2ZV9ib3JkZXJfbW9kZQorICAgID0gKHN0ZDo6c3RyaW5nICgiXAorVGhpcyB2 YXJpYWJsZSBjb250cm9scyB0aGUgYXR0cmlidXRlcyB0byB1c2UgZm9yIHRoZSBhY3RpdmUg d2luZG93IGJvcmRlcnM6XG4iKQorICAgICAgICsgaGVscF9hdHRyaWJ1dGVfbW9kZSk7CisK ICAgYWRkX3NldHNob3dfZW51bV9jbWQgKCJhY3RpdmUtYm9yZGVyLW1vZGUiLCBub19jbGFz cywgdHVpX2JvcmRlcl9tb2RlX2VudW1zLAogCQkJJnR1aV9hY3RpdmVfYm9yZGVyX21vZGUs IF8oIlwKIFNldCB0aGUgYXR0cmlidXRlIG1vZGUgdG8gdXNlIGZvciB0aGUgYWN0aXZlIFRV SSB3aW5kb3cgYm9yZGVyLiIpLCBfKCJcCi1TaG93IHRoZSBhdHRyaWJ1dGUgbW9kZSB0byB1 c2UgZm9yIHRoZSBhY3RpdmUgVFVJIHdpbmRvdyBib3JkZXIuIiksIF8oIlwKLVRoaXMgdmFy aWFibGUgY29udHJvbHMgdGhlIGF0dHJpYnV0ZXMgdG8gdXNlIGZvciB0aGUgYWN0aXZlIHdp bmRvdyBib3JkZXI6XG5cCi0gICBub3JtYWwgICAgICAgICAgbm9ybWFsIGRpc3BsYXlcblwK LSAgIHN0YW5kb3V0ICAgICAgICB1c2UgaGlnaGxpZ2h0IG1vZGUgb2YgdGVybWluYWxcblwK LSAgIHJldmVyc2UgICAgICAgICB1c2UgcmV2ZXJzZSB2aWRlbyBtb2RlXG5cCi0gICBoYWxm ICAgICAgICAgICAgdXNlIGhhbGYgYnJpZ2h0XG5cCi0gICBoYWxmLXN0YW5kb3V0ICAgdXNl IGhhbGYgYnJpZ2h0IGFuZCBzdGFuZG91dCBtb2RlXG5cCi0gICBib2xkICAgICAgICAgICAg dXNlIGV4dHJhIGJyaWdodCBvciBib2xkXG5cCi0gICBib2xkLXN0YW5kb3V0ICAgdXNlIGV4 dHJhIGJyaWdodCBvciBib2xkIHdpdGggc3RhbmRvdXQgbW9kZSIpLAorU2hvdyB0aGUgYXR0 cmlidXRlIG1vZGUgdG8gdXNlIGZvciB0aGUgYWN0aXZlIFRVSSB3aW5kb3cgYm9yZGVyLiIp LAorCQkJaGVscF90dWlfYWN0aXZlX2JvcmRlcl9tb2RlLmNfc3RyICgpLAogCQkJdHVpX3Nl dF92YXJfY21kLAogCQkJc2hvd190dWlfYWN0aXZlX2JvcmRlcl9tb2RlLAogCQkJJnR1aV9z ZXRsaXN0LCAmdHVpX3Nob3dsaXN0KTsKCmJhc2UtY29tbWl0OiA5MjE3MmExOWY2NzAyNmIz ZWIwZjliZTY3NjJiN2E1ODIxYWJlZjg0Ci0tIAoyLjM1LjMKCg== --------------jvzevqzacH3O17hJ7c9xbfuQ--