From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 616E93858D1E for ; Thu, 21 Apr 2022 01:49:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 616E93858D1E Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 23L1KA41011664 for ; Thu, 21 Apr 2022 01:49:17 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fjff3aewe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 21 Apr 2022 01:49:15 +0000 Received: from m0098396.ppops.net (m0098396.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 23L1nFeP004841 for ; Thu, 21 Apr 2022 01:49:15 GMT Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3fjff3aew7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Apr 2022 01:49:15 +0000 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 23L1l3Rb011025; Thu, 21 Apr 2022 01:49:14 GMT Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by ppma01dal.us.ibm.com with ESMTP id 3ffneb0j46-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Apr 2022 01:49:14 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 23L1nC0Y13435374 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 21 Apr 2022 01:49:12 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C94BE12405A; Thu, 21 Apr 2022 01:49:12 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0FAF6124052; Thu, 21 Apr 2022 01:49:12 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.163.11.46]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 21 Apr 2022 01:49:11 +0000 (GMT) Message-ID: Subject: Re: [PING 3] [PATCH] Fix for gdb.base/solib-search.exp test. From: Carl Love To: dje@google.com, gdb-patches@sourceware.org, Ulrich Weigand , cel@us.ibm.com Cc: Will Schmidt , Rogerio Alves Date: Wed, 20 Apr 2022 18:49:11 -0700 In-Reply-To: References: <8fe6f3bee129c0a3159d3ef57c942b9473255d8d.camel@us.ibm.com> <45f13f3998d4e36b1c7a84ab8b676718249c6d28.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 1H03TZyO3v_Sdrf0qUuY-kCIPzlSmHq_ X-Proofpoint-ORIG-GUID: 2PaEhUmT-19X0H3h9UzZO2foOiL1f9UU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-20_06,2022-04-20_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2204210006 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2022 01:49:19 -0000 GDB maintainers: This patch has yet to be reviewed by a GDB maintainer. Carl On Thu, 2022-04-07 at 08:13 -0700, Carl Love wrote: > GDB maintainers: > > Still hoping someone can take a look at this patch for me. Thanks. > > Carl Love > > On Mon, 2022-03-28 at 08:21 -0700, Carl Love wrote: > > On Tue, 2022-03-22 at 14:49 -0700, Carl Love wrote: > > > GDB maintainers: > > > > > > The following patch fixes the setting of the variable > > > right_lib_flags > > > in the solib-search.exp test. With the fix the test now run > > > correctly > > > on Powerpc. > > > > > > The patch has been tested on a Power 10 system. > > > > > > Please let me know if the patch is acceptable for mainline gdb. > > > Thanks. > > > > > > Carl Love > > > > > > --------------------------------------------------- > > > Fix for gdb.base/solib-search.exp test. > > > > > > The variable right_lib_flags is not being set correctly to define > > > RIGHT. > > > The value RIGHT is needed to force the address of the library > > > functions > > > lib1_func3 and lib2_func4 to occur at different address in the > > > wrong > > > and > > > right libraries. > > > > > > With RIGHT defined correctly, functions lib1_func3 and lib2_func4 > > > occur > > > at different addresses the test runs correctly on Powerpc. > > > --- > > > gdb/testsuite/gdb.base/solib-search.exp | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/gdb/testsuite/gdb.base/solib-search.exp > > > b/gdb/testsuite/gdb.base/solib-search.exp > > > index eaabe508bf0..202e79d85de 100644 > > > --- a/gdb/testsuite/gdb.base/solib-search.exp > > > +++ b/gdb/testsuite/gdb.base/solib-search.exp > > > @@ -54,7 +54,7 @@ set binfile2_lib [standard_output_file > > > ${libname2}.so] > > > > > > set lib_flags [list debug ldflags=-Wl,-Bsymbolic] > > > set wrong_lib_flags "$lib_flags additional_flags=-DARRAY_SIZE=1" > > > -set right_lib_flags "$lib_flags additional_flags=- > > > DARRAY_SIZE=8192 > > > -DRIGHT" > > > +set right_lib_flags "$lib_flags additional_flags=- > > > DARRAY_SIZE=8192 > > > additional_flags=-DRIGHT" > > > > > > # Binary file. > > > standard_testfile .c