From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1035 invoked by alias); 4 May 2016 09:20:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 976 invoked by uid 89); 4 May 2016 09:20:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=TESTS, morning X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 May 2016 09:20:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 900402196; Wed, 4 May 2016 09:20:07 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u449K6pw017012; Wed, 4 May 2016 05:20:06 -0400 Subject: Re: [PATCH] Add mi-threads-interrupt.exp test (PR 20039) To: Simon Marchi , gdb-patches@sourceware.org References: <1462305612-16493-1-git-send-email-simon.marchi@ericsson.com> <5983d4d2-016a-8020-c109-cb7ea2cfd179@redhat.com> From: Pedro Alves Message-ID: Date: Wed, 04 May 2016 09:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <5983d4d2-016a-8020-c109-cb7ea2cfd179@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00055.txt.bz2 On 05/03/2016 10:57 PM, Pedro Alves wrote: > AFAICS, the test relies on "set mi-async off". Could you make sure that > if you run it against a board file that forces that on, the test either > passes (probably with -exec-interrupt in async mode) or is skipped? > See mi_detect_async and the async global. Woke up this morning realizing that I hadn't done this for so long myself that I had forgotten how I used to do it. We don't really need a board file -- as described in the TestingGDB wiki page [1], we can use GDBFLAGS from the command line for this: $ make check RUNTESTFLAGS="GDBFLAGS='-ex set\ mi-async\ on'" TESTS="gdb.mi/mi-threads-interrupt.exp" ... FAIL: gdb.mi/mi-threads-interrupt.exp: interrupt #1 (unknown output after running) FAIL: gdb.mi/mi-threads-interrupt.exp: continue #2 [1] https://sourceware.org/gdb/wiki/TestingGDB Thanks, Pedro Alves