From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 2F1593858C83
 for <gdb-patches@sourceware.org>; Wed, 19 Oct 2022 20:03:12 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2F1593858C83
Received: from [10.0.0.85] (modemcable162.249-56-74.mc.videotron.ca
 [74.56.249.162])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 607991E0CB;
 Wed, 19 Oct 2022 16:03:11 -0400 (EDT)
Message-ID: <f4efd0a3-f1db-9a98-e2f7-1369a341d96a@simark.ca>
Date: Wed, 19 Oct 2022 16:03:10 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.2
Subject: Re: [PATCHv2 4/4] gdb: some int to bool conversion in breakpoint.c
Content-Language: fr
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
References: <cover.1664962269.git.aburgess@redhat.com>
 <cover.1666184729.git.aburgess@redhat.com>
 <62e73978fa2b623f42e567d34429104fe70304c5.1666184729.git.aburgess@redhat.com>
From: Simon Marchi <simark@simark.ca>
In-Reply-To: <62e73978fa2b623f42e567d34429104fe70304c5.1666184729.git.aburgess@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_PASS,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Oct 2022 20:03:22 -0000

On 10/19/22 09:07, Andrew Burgess via Gdb-patches wrote:
> Some int to bool conversion in breakpoint.c.  I've only updated the
> function signatures of static functions, but I've updated some
> function local variables throughout the file.
> 
> The most interesting change is in unduplicated_should_be_inserted,
> where I've made use of make_scoped_restore to temporarily change the
> bl->duplicate flag.

This isn't part of this patch.

Some nits below, but otherwise, the series LGTM:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

> @@ -1922,7 +1922,7 @@ add_dummy_location (struct breakpoint *b,
>     watchpoint removal from inferior.  */
>  
>  static void
> -update_watchpoint (struct watchpoint *b, int reparse)
> +update_watchpoint (struct watchpoint *b, bool reparse)

Update the REPARSE doc, non-zero -> true.

> @@ -4216,7 +4216,7 @@ moribund_breakpoint_here_p (const address_space *aspace, CORE_ADDR pc)
>  /* Returns non-zero iff BL is inserted at PC, in address space
>     ASPACE.  */
>  
> -static int
> +static bool
>  bp_location_inserted_here_p (const struct bp_location *bl,

non-zero -> true in the doc

Simon