From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdbserver: constify the 'pid_to_exec_file' target op
Date: Mon, 12 Apr 2021 10:10:26 -0400 [thread overview]
Message-ID: <f50a1f51-2b55-ed62-4bc9-2ed59c7f864f@polymtl.ca> (raw)
In-Reply-To: <1618230638-20102-1-git-send-email-tankut.baris.aktemur@intel.com>
On 2021-04-12 8:30 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index 2a443305691..156fd4333df 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -1466,7 +1466,7 @@ handle_qxfer_exec_file (const char *annex,
> gdb_byte *readbuf, const gdb_byte *writebuf,
> ULONGEST offset, LONGEST len)
> {
> - char *file;
> + const char *file;
Since you are touching this, let's move the declaration to where the
assignment is done.
Otherwise, LGTM, thanks.
Simon
next prev parent reply other threads:[~2021-04-12 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 12:30 Tankut Baris Aktemur
2021-04-12 14:10 ` Simon Marchi [this message]
2021-04-12 14:38 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f50a1f51-2b55-ed62-4bc9-2ed59c7f864f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).