From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id 4FC0E3850405
 for <gdb-patches@sourceware.org>; Mon, 12 Apr 2021 14:10:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4FC0E3850405
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13CEARSv030062
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Mon, 12 Apr 2021 10:10:32 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13CEARSv030062
Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 1B24F1E54D;
 Mon, 12 Apr 2021 10:10:27 -0400 (EDT)
Subject: Re: [PATCH] gdbserver: constify the 'pid_to_exec_file' target op
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
 gdb-patches@sourceware.org
References: <1618230638-20102-1-git-send-email-tankut.baris.aktemur@intel.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <f50a1f51-2b55-ed62-4bc9-2ed59c7f864f@polymtl.ca>
Date: Mon, 12 Apr 2021 10:10:26 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <1618230638-20102-1-git-send-email-tankut.baris.aktemur@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 12 Apr 2021 14:10:27 +0000
X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2021 14:10:36 -0000

On 2021-04-12 8:30 a.m., Tankut Baris Aktemur via Gdb-patches wrote:
> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
> index 2a443305691..156fd4333df 100644
> --- a/gdbserver/server.cc
> +++ b/gdbserver/server.cc
> @@ -1466,7 +1466,7 @@ handle_qxfer_exec_file (const char *annex,
>  			gdb_byte *readbuf, const gdb_byte *writebuf,
>  			ULONGEST offset, LONGEST len)
>  {
> -  char *file;
> +  const char *file;

Since you are touching this, let's move the declaration to where the
assignment is done.

Otherwise, LGTM, thanks.

Simon