From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id AB857385829B for ; Mon, 26 Sep 2022 18:01:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AB857385829B Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 28QI1a2x009162 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 14:01:41 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 28QI1a2x009162 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 96FB31E0D3; Mon, 26 Sep 2022 14:01:36 -0400 (EDT) Message-ID: Date: Mon, 26 Sep 2022 14:01:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 0/3] Fix gdb.gdb/python-helper.exp + cleanups Content-Language: en-US To: Tom de Vries , Luis Machado , gdb-patches@sourceware.org References: <20220923141801.1106678-1-simon.marchi@polymtl.ca> <4fe6a9e7-9b87-2755-b741-3a06180cdcc3@suse.de> From: Simon Marchi In-Reply-To: <4fe6a9e7-9b87-2755-b741-3a06180cdcc3@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 26 Sep 2022 18:01:36 +0000 X-Spam-Status: No, score=-3032.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2022 18:01:46 -0000 On 2022-09-23 17:35, Tom de Vries wrote: > On 9/23/22 19:02, Luis Machado via Gdb-patches wrote: >> On 9/23/22 15:17, Simon Marchi via Gdb-patches wrote: >>> My patches that touched TYPE_LENGTH and TYPE_TARGET_TYPE caused >>> regressions in gdb.gdb/python-helper.exp.  I forgot to update >>> gdb-gdb.py.in, as always. >>> >>> It looks like my CI doesn't run the test properly.  Because inserting the >>> first breakpoint times out, do_self_tests skips the test.  I also had >>> troubles running the test locally due to these timeouts.  So the first >>> two patches address problems related to that, and the third one is the >>> actual fix. >>> >>> Simon Marchi (3): >>>    gdb/testsuite: bump duration for the whole test in do_self_tests >>>    gdb/testsuite: use gdb_test in gdb.gdb/python-helper.exp >>>    gdb/testsuite: update field names in gdb-gdb.py.in >>> >>>   gdb/gdb-gdb.py.in                       |  4 +- >>>   gdb/testsuite/gdb.gdb/python-helper.exp | 88 +++++-------------------- >>>   gdb/testsuite/lib/gdb.exp               |  8 +-- >>>   gdb/testsuite/lib/selftest-support.exp  | 36 +++------- >>>   4 files changed, 31 insertions(+), 105 deletions(-) >>> >>> >>> base-commit: 8e037eae6823caf5b9cb5b4feb3de838abb25956 >> >> Thanks for the series. I tested this on my end and it seems to work nicely. >> >> The only hiccup I noticed is when GDB runs into a SIGSEGV due to the guile >> interpreter hitting GC_find_limit_with_bound. I'm not sure why this happens. Maybe >> it is a problem with guile and armhf. > > It's documented behaviour of libgc1, see > https://sourceware.org/bugzilla/show_bug.cgi?id=29325 . Ack, this is an orthogonal issue (and for some reason I don't see it on my Arch Linux, but I have certainly seen it elsewhere). Just to confirm, does the series look good to you too Tom? Simon