From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id A35043858C60 for ; Thu, 8 Feb 2024 19:38:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A35043858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A35043858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707421086; cv=none; b=XXJKud1eGAPu0XFZ97IvxWJERcP4wWXQGZDrn54QdjIbXrEDQhRGsCyjZdcmb0s39VxdWwomYQkT4ZwJgaL6Y7fFwTsQIwrD+rUTPNzpEQhqKQNU3jp7wTKXK04W7K84Gw+ymtPJwfCTKK2fS9bir1WECMf42lgu27HnjgxUZRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707421086; c=relaxed/simple; bh=KB8GsO3avoCwGN2FVIVf/3QmLsXC+kiyr++eO/8egkI=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WTfnt7yCthhj1g3NQtOUGSGJ1UgVsKkUQGtnLehR7m831pHbmfiEJ1P3kOcPsJvF6LAJowRl7X5so50q8IitnrzcRqCAdZd3tZBIQGZbLylctXdEx/AjY+TSo5Jn9VF8gJoHxaVlj9ZlmnDq0VeUX7MfQlKhEfcIwGxnuArNgiU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 418JRF9q024663; Thu, 8 Feb 2024 19:38:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=N5W6xMnfIFwhpcqwW2py84upSO7Uib9eEPxv/+7EzIE=; b=dBH0VJKzi6lCu7F566MVlOk6UgULplfO22UFlhUPVO1P9kkTebpd40ljAH+3SdKTzZ5o +SVF/Wri9vY0pcz9iiGsAbPBXyM9uLQSyXAZL3Oyt/OYOOpALvJ/Gl6f9OiyoZG+TVtq 58toFsDcVJpU0wi6Z/nqKGeI6OFYtFJ0qiMvw8ophpk44NYdpkvsTdMbxK5J6yV5x8zF hAUcEOkeRwd+esnJx0GS2LD5qV7KMi42q5OkA1yyPRAciKjOE8Tzz7tNvZEgxHw+TgBp J4sh1QXd9DBOo6qn20isc6GhLgeLQDpsPyEHuJ8NQqjduzX0R7phPSjR8AesSn2DEi+T qA== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w554hga8u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Feb 2024 19:38:03 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 418IiVcC008487; Thu, 8 Feb 2024 19:38:02 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3w221kec94-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 08 Feb 2024 19:38:02 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 418JbxHL50069942 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Feb 2024 19:37:59 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3E1358054; Thu, 8 Feb 2024 19:37:58 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 432955804E; Thu, 8 Feb 2024 19:37:58 +0000 (GMT) Received: from [9.67.188.151] (unknown [9.67.188.151]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 8 Feb 2024 19:37:58 +0000 (GMT) Message-ID: Date: Thu, 8 Feb 2024 11:37:57 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] rs6000, unwind-on-each-instruction fix. Content-Language: en-US To: Tom Tromey , Carl Love Cc: Ulrich Weigand , gdb-patches@sourceware.org References: <87sf22945o.fsf@tromey.com> From: Carl Love In-Reply-To: <87sf22945o.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Scd49iDUEishsnvrtfYaRk1uk-FdvMcg X-Proofpoint-ORIG-GUID: Scd49iDUEishsnvrtfYaRk1uk-FdvMcg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-08_08,2024-02-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 mlxlogscore=497 mlxscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402080103 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom: On 2/8/24 10:55, Tom Tromey wrote: >>>>>> "Carl" == Carl Love writes: > > Carl> The patch fixes all 10 regression failures for the test. The patch > Carl> has been tested on Power 9 and Power 10 with no additional regression > Carl> test failures. > > Carl> Please let me know if this patch is acceptable to GDB mainline. > > I think it would be best if someone familiar with PPC reviewed this. > > FWIW it looks reasonable to me. > > Carl> + /* The PC is found in the link register. */ > Carl> + cache->saved_regs[gdbarch_pc_regnum (gdbarch)] = > Carl> + cache->saved_regs[tdep->ppc_lr_regnum]; > > Here the '=' should go on the 2nd line. Yes, the "=" is on the wrong line. I fixed it locally. Thanks for catching that. Hopefully Ulrich will get a chance to look at the patch. I think he was out of the office for a few days. I am thinking the patch got overlooked with all of his other mail. Carl