From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA v2 0/3] Handle dereferencing Rust trait objects
Date: Fri, 17 Nov 2017 19:43:00 -0000 [thread overview]
Message-ID: <f546c85c-9749-df99-1ea4-ab08624719a7@redhat.com> (raw)
In-Reply-To: <20171117192547.3515-1-tom@tromey.com>
On 11/17/2017 07:25 PM, Tom Tromey wrote:
> This is version 2 of the patch for inspecting Rust trait objects.
>
> I think this version addresses the comments from the earlier version:
>
> * Use a std::vector rather than unordered_map -- note that a temporary
> set was needed to avoid temporarily making a gigantic vector in the
> libxul case.
>
> * Change a reinterpret_cast to a static_cast.
>
> * Use readelf to check the test's debuginfo before proceeding.
>
> I've also tacked on a couple of patches that we discussed; one to
> change the "subclass" information for struct symbol to use an enum,
> and one to change template_symbol to use derivation.
>
> Tested on x86-64 Fedora 25.
LGTM.
Thanks,
Pedro Alves
prev parent reply other threads:[~2017-11-17 19:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 19:26 Tom Tromey
2017-11-17 19:26 ` [RFA v2 3/3] Use an enum to represent subclasses of symbol Tom Tromey
2017-11-17 19:26 ` [RFA v2 2/3] Make template_symbol derive from symbol Tom Tromey
2017-11-17 19:26 ` [RFA v2 1/3] Handle dereferencing Rust trait objects Tom Tromey
2017-11-17 19:43 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f546c85c-9749-df99-1ea4-ab08624719a7@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).