From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99337 invoked by alias); 11 Dec 2017 11:20:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99326 invoked by uid 89); 11 Dec 2017 11:20:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:2449 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Dec 2017 11:20:36 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9194C0587CB; Mon, 11 Dec 2017 11:20:35 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB97051C69; Mon, 11 Dec 2017 11:20:34 +0000 (UTC) Subject: Re: [PATCH 3/5] Don't ever Quit out of resume To: "Maciej W. Rozycki" References: <1510010836-15287-1-git-send-email-palves@redhat.com> <1510010836-15287-4-git-send-email-palves@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 11 Dec 2017 11:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00227.txt.bz2 On 12/09/2017 01:16 AM, Maciej W. Rozycki wrote: > Hi Pedro, > > On Mon, 6 Nov 2017, Pedro Alves wrote: > >> gdb/ChangeLog: >> yyyy-mm-dd Pedro Alves >> >> * infrun.c (resume_cleanups): Delete. >> (resume): No longer install a resume_cleanups cleanup nor call >> QUIT. >> (proceed): Pass the terminal to the inferior. >> (keep_going_pass_signal): No longer install a resume_cleanups >> cleanup. > > This change, i.e.: > > commit d930703d68ae160ddfe8ebe5fdcf416fb6090e1e > Author: Pedro Alves > Date: Thu Nov 16 18:44:43 2017 +0000 > > caused regressions to appear in remote `mips-mti-linux-gnu' target testing > (`x86_64-linux-gnu' host), specifically: > > FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind > FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw on: single-step breakpoint is not left behind > FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: step in ro region (cannot insert hw break) > FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw off: single-step breakpoint is not left behind > FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted on: auto-hw on: single-step breakpoint is not left behind > > and indeed detailed logs indicate a breakpoint is left lingering, e.g.: > > (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break) > maint info breakpoints 0 > Num Type Disp Enb Address What > 0 sw single-step keep y 0x00400774 in main at [...]/gdb/testsuite/gdb.base/breakpoint-in-ro-region.c:24 inf 1 thread 1 > stop only in thread 1 > (gdb) FAIL: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind > > vs: > > (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: step in ro region (cannot insert sw break) > maint info breakpoints 0 > No breakpoint or watchpoint matching '0'. > (gdb) PASS: gdb.base/breakpoint-in-ro-region.exp: always-inserted off: auto-hw off: single-step breakpoint is not left behind > > as at commit d930703d68ae^. > > Can you please look into it? If I can assist you anyhow, then just let > me know. > Thanks. I filed to track this. Pedro Alves