From: Simon Marchi <simon.marchi@polymtl.ca>
To: Jan Beulich <jbeulich@suse.com>
Cc: simon.marchi@ericsson.com, tim.wiederhake@intel.com,
gdb-patches@sourceware.org
Subject: Re: [PATCH] x86-64: fix ZMM register state tracking
Date: Mon, 10 Sep 2018 13:01:00 -0000 [thread overview]
Message-ID: <f5a4adb4d3f4a0aa84b1666e7967a9fc@polymtl.ca> (raw)
In-Reply-To: <5B960E3D020000780013C85E@prv1-mh.provo.novell.com>
On 2018-09-10 07:25, Jan Beulich wrote:
>>>> Simon Marchi <simon.marchi@ericsson.com> 09/08/18 1:13 AM >>>
>> Would it be possible to update or create a test to exercise that?
>> arch-specific tests are in testsuite/gdb.arch.
>
> I'm sure it would be possible, but while I was happy to invest the time
> to
> fix the actual bug (because it affects work I'm doing), I'm afraid I
> don't have
> the time to learn how gdb test cases are to be constructed (I'm
> familiar
> only with the binutils / gas side of things).
I understand. If you can provide:
- a minimal source file (C + assembly in this case, I suppose)
- GDB commands to reproduce the bug
- actual and expected output
I can take care of turning it in a GDB test case.
>> On 2018-09-05 02:22 PM, Jan Beulich wrote:
>>> --- a/gdb/i387-tdep.c
>>> +++ b/gdb/i387-tdep.c
>>> @@ -923,7 +923,8 @@ i387_supply_xsave (struct regcache *regc
>>> enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
>>> struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
>>> const gdb_byte *regs = (const gdb_byte *) xsave;
>>> - int i;
>>> + int i, zmm_endlo_regnum = I387_ZMM0H_REGNUM (tdep)
>>> + + std::min (tdep->num_zmm_regs, 16);
>>
>> The GNU standard requires to parenthesis when breaking lines:
>>
>> int i, zmm_endlo_regnum = (I387_ZMM0H_REGNUM (tdep)
>> + std::min (tdep->num_zmm_regs, 16));
>
> This is easy enough to fix (perhaps even without the need to send a v2,
> but just before/while committing?); I don't think this is a rule being
> enforced on the binutils side, so I simply wasn't aware.
Yeah, no problem, I can do it. It's suggested in the GNU coding
standards, so I think it would apply to binutils too:
https://www.gnu.org/prep/standards/html_node/Formatting.html
Search for "Adding a set of parentheses".
Simon
next prev parent reply other threads:[~2018-09-10 13:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 13:23 Jan Beulich
2018-09-07 23:13 ` Simon Marchi
2018-09-10 6:25 ` Jan Beulich
2018-09-10 13:01 ` Simon Marchi [this message]
2018-09-18 13:38 ` Jan Beulich
2018-09-25 3:29 ` Simon Marchi
2018-09-25 15:04 ` Jan Beulich
2018-10-02 19:20 ` Simon Marchi
2018-10-03 14:30 ` Jan Beulich
2018-10-03 14:41 ` Simon Marchi
2018-09-11 10:34 ` Pedro Alves
2018-09-11 11:34 ` Jan Beulich
2018-09-24 17:19 ` Metzger, Markus T
2018-09-25 7:47 ` Jan Beulich
2018-10-10 15:12 ` [PATCH v2] " Jan Beulich
2018-10-29 10:31 ` Ping: " Jan Beulich
2018-10-31 14:00 ` Simon Marchi
2018-11-07 9:07 ` Metzger, Markus T
2018-11-07 9:12 ` Jan Beulich
2018-11-07 13:18 ` Metzger, Markus T
2018-11-07 13:25 ` Jan Beulich
2018-11-07 14:18 ` Simon Marchi
2018-11-08 11:16 ` Jan Beulich
2018-11-08 16:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5a4adb4d3f4a0aa84b1666e7967a9fc@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=jbeulich@suse.com \
--cc=simon.marchi@ericsson.com \
--cc=tim.wiederhake@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).