From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id B9DA83858403 for ; Wed, 17 Jan 2024 16:00:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B9DA83858403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B9DA83858403 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705507221; cv=none; b=qEGtufJ7k09HO1ZAzogJC6ouU5OnpG0cbO8fnSAN+EJHX/EokDCKwXnEMGXNLKcBCiCyFM4/Axg27H+pYNYiG0Qg27YnBbZR1oss0vr/5+Kj73QyjEpDgFPDlBbu36cOvzOh3Sb5y4MVMYLpVZNYAM2bubPRzCyCRxtT2MEK80c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705507221; c=relaxed/simple; bh=42nkVoT0WAZhtZ3QtB0PsWF6uZeJbyiiky9pMyjUzdQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=GcQquodc1DMmTkkVGK36syWGvdnPNHHEAY1jn6xMRJmAmdW9cuHDTudMmDu413nI3qJ/BO1N0I11S2DeN13A8XCn9NDsYI7FNuRrs2uBpMPQZTeTWxd7OREWC6SCiiorfiAls8vpGqBm1DhCX/D5p03kyjHRnbHvMMC8flzk/i0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A670E2201D; Wed, 17 Jan 2024 16:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705507217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UaQikQgqOJgdyLHlnTz3KxUvzHZGblUCe9whlFU3GXM=; b=bmhqidJ1M0ytQ3DhAsOHOksESbPIyERLpYknPX4NzTU8FhDT8vFje/Xom1u9Poqsu/NKTS WavIXk5bnFAlvrInhdmQRhZ/6RLBhqrbJWQS16KUBSlzkEzP1sR2ib1CvHwv3UpQt6nfJZ Jq7ZjQyHR5LPM9DqfVmVtwLz5klZpOk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705507217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UaQikQgqOJgdyLHlnTz3KxUvzHZGblUCe9whlFU3GXM=; b=Zpe/Fu12XoGuq2srSecdHafiwTH5qAGClRuLKjUYQaicHz4EPX6xunpvbPQc81zhMdpKB3 xHYI+qlKllMnS9CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705507217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UaQikQgqOJgdyLHlnTz3KxUvzHZGblUCe9whlFU3GXM=; b=bmhqidJ1M0ytQ3DhAsOHOksESbPIyERLpYknPX4NzTU8FhDT8vFje/Xom1u9Poqsu/NKTS WavIXk5bnFAlvrInhdmQRhZ/6RLBhqrbJWQS16KUBSlzkEzP1sR2ib1CvHwv3UpQt6nfJZ Jq7ZjQyHR5LPM9DqfVmVtwLz5klZpOk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705507217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UaQikQgqOJgdyLHlnTz3KxUvzHZGblUCe9whlFU3GXM=; b=Zpe/Fu12XoGuq2srSecdHafiwTH5qAGClRuLKjUYQaicHz4EPX6xunpvbPQc81zhMdpKB3 xHYI+qlKllMnS9CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8C33413751; Wed, 17 Jan 2024 16:00:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WCbIIJH5p2U+JAAAD6G6ig (envelope-from ); Wed, 17 Jan 2024 16:00:17 +0000 Message-ID: Date: Wed, 17 Jan 2024 17:01:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: handle long filenames in gdb.base/startup-with-shell.exp Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <8be51f9325a83a446404cf595bbe60b330af79e0.1705485491.git.aburgess@redhat.com> <392f3495-5d71-4cba-b456-3484498f906c@suse.de> <871qag6kn8.fsf@redhat.com> From: Tom de Vries In-Reply-To: <871qag6kn8.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=bmhqidJ1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="Zpe/Fu12" X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-6.50 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; NEURAL_HAM_LONG(-1.00)[-1.000]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,sourceware.org:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Score: -6.50 X-Rspamd-Queue-Id: A670E2201D X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/17/24 16:32, Andrew Burgess wrote: > Tom de Vries writes: > >> On 1/17/24 10:58, Andrew Burgess wrote: >>> I got a report of a failure from Linaro's CI testing for the test >>> gdb.base/startup-with-shell.exp. >>> >>> Looking at the log I see this: >>> >>> (gdb) PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: inferior started >>> print argv[1] >>> $1 = 0xfffed978 "/home/tcwg-build/workspace/tcwg_gnu_4/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-e"... >>> (gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: first argument expanded >>> >>> Notice that the value of $1 was truncated (indicated by the trailing >>> ellipses), and as a result it isn't going to match the expected output >>> pattern. >>> >>> Avoid this by adding a call to 'set print characters unlimited' which >>> allows GDB to print strings of any length. >> >> Hi Andrew, >> >> LGTM. >> >> I don't see the FAIL in my usual setup, but I managed to reproduce it by >> using "set print characters 20". >> >> FWIW, I noticed with target native-extended-gdbserver: >> ... >> FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args >> = *.unique-extension: first argument expanded >> FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args >> = $TEST: testing first argument >> ... >> but that's both with and without your patch. PR28392 ( >> https://sourceware.org/bugzilla/show_bug.cgi?id=28392 ) looks related. > > These failures (along with a lot of other problems) are fixed by this series: > > https://inbox.sourceware.org/gdb-patches/cover.1704809585.git.aburgess@redhat.com > Thanks, I've added a note in the PR. - Tom > Thanks, > Andrew > >> >> Approved-By: Tom de Vries >> >> Thanks, >> - Tom >> >>> --- >>> gdb/testsuite/gdb.base/startup-with-shell.exp | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp >>> index b73d5d740f5..d5ec503dceb 100644 >>> --- a/gdb/testsuite/gdb.base/startup-with-shell.exp >>> +++ b/gdb/testsuite/gdb.base/startup-with-shell.exp >>> @@ -59,6 +59,7 @@ proc initial_setup_simple { startup_with_shell run_args } { >>> >>> with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" { >>> initial_setup_simple "on" "$unique_file_dir/*.unique-extension" >>> + gdb_test_no_output "set print characters unlimited" >>> gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file\"" \ >>> "first argument expanded" >>> } >>> >>> base-commit: 1b346e50485ee450e8103e4b1704b43f61bc39f7 >