From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on2081.outbound.protection.outlook.com [40.107.116.81]) by sourceware.org (Postfix) with ESMTPS id 1FC783858410 for ; Fri, 18 Nov 2022 15:07:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1FC783858410 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WP53aZkJb/htObhmKwuAQXZFIfdGduX9WZkua+BKXxs3Oza8l1gvCfP15o+x8ZhoQbeWYMaJSXk69s1UxpoQKslRoOpqQay2fqy17hL+aAC1hCaFbg0pOdN7SPg0BtO7TmiNvcvaYUqv5FzKvLw/Pm77aSfKjPyL+rw0KsLVE0s2FkF3gQyCVswRqpfHfTh0DiwmMw3PaGhsorgXmaXTLR04oHEpO62WBPuhGPJM+5FjyeDO3vkfiUzGcUn58/U0OQe8W1w9BeHJn8rI6IS5uMlW/MAtPEnnL0YzC+dp0uKCzh7gs8RiGdf5fF8v/72wgiQjNE99Gw+CxIJPMKDlKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2sYqizOahJPY5LTrcm/zwhZgt3cyriFwDpULmguDge0=; b=PznNZcejjBAta5iA5fkKCclZgWcN0zcoQmzmVsG2Slrm/hrD6TDYumeZyJ3eE0Khj/OCCriL7gMzo8PzL55g1/PTMS8m+HcANzDe5vw9XDC+j/h2JKzUZcy0f54JrMz0sDK3oUhTTQqGkDZIbhxeaMEEbLuOQcHt9NrBA+vjUqGq13Z3o4kVkM2/8kS9wr1MRFmyunJbOyKg62OuqZGTW10k/SBywrcQSj/QVkpoBcFCti/8jVTeCnRcr+yJtRExrjT5pfEw18WlnxxJRDR2zmS/PHwtvdoXPgXZrrHvgWLxzWcDLm58c/vgIbtx3+Tqf42ubJJWpJFUc/NrvvB4JA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2sYqizOahJPY5LTrcm/zwhZgt3cyriFwDpULmguDge0=; b=sYHuwxjzjFsYTCdPaILpreAboxin4v3kiJ9tWite7DRa87Jg9JKDPuFr51X3ZBbHZv2gUau5HphaeAD3cqGr+GJ61D5Uw+iS6IV4AwNYVWMZYIoi/va1Yd8YflHJUHFSqvDfIX5naUd6S7bhgeZBeBowoFDCGnT3oWt2Wphpc7PvEkYVUEBM98sTrSTgmYR6isC2IAHpOjsxOAdk6FXsxXMAj0HUivrZuVYmPru87oERjy1xI/plSh1774f7yrg2dY4ryAYrRsW4wfR8xNkXVF6UgTkWvf/e048J+8XXmFpVRcMrcuGrdhw3vKI4s2OOvA47f4Kqe/hD9IP7Pbfhhw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YT1PR01MB8394.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:c2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Fri, 18 Nov 2022 15:07:56 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2465:ab25:2168:32df]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::2465:ab25:2168:32df%4]) with mapi id 15.20.5813.020; Fri, 18 Nov 2022 15:07:56 +0000 Message-ID: Date: Fri, 18 Nov 2022 10:07:54 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 1/8] gdb/testsuite: remove global declarations in gdb.threads/detach-step-over.exp Content-Language: en-US To: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: <20221117194241.1776125-1-simon.marchi@efficios.com> <20221117194241.1776125-2-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0136.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::36) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YT1PR01MB8394:EE_ X-MS-Office365-Filtering-Correlation-Id: 74bab6e7-b835-4e8d-0d39-08dac976ac30 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pALx/xChHSo3+ZIGSIlEReemQdtnry1Ne0FM7bDMYDWIgX3ZEuNTiU5+B7qjt/14aB3PvKMpkh3fTmu1+a9UT7N0RE6H4ZFTKKrNuR00zX23DRFNnelbYWjLZZBwWmGMremsnHM7FykpVohwsT4s9+0uinO6U0boP74pngOkYaUF2caSZOzu30Twzyn6WoALjMmqeu0jeT0ors7J7JujXq3RKBp6nqHJM9cd6siOyfY1u3NJEyM9CckKwhEazfyb8HiqeE482MujdtkRfgrKGUZpJ6kokry8Szx0MjKKj/Cp9Ub2qhTkGYcvt4vdAWkRta+WODluqVlhIpOl/Z5im+lRoZk6oRJz/iD0V2lLjjZ/E4TB1mQU1RzDyERkG4i+ij7EvHKpVdjCal65rOT5L58vDQs6+8OZ6B+98tz93hkcKQxULkg0PKeWq8ibzkz8Gs77eNuv+nHFWZCIU+bDntSqb95uzyzfs0uuLgFb+RXN1wSGA1fMo5EZ/C/DEOw7Uht4Fy7bdhPoFypNLXMK0L9FKnj7sNtTJLXltbNKAqCuXCdVT6khHnnR8jDkASq30GPSrtWdTVPw52nB6a8dPfezBhQBnz/58RPBuP1Zg0uXHHRzWL+++byctX2Ee0Qy5lmqi5hDLsG1f3pyO57Lmqk66n4UMM6QqPcoyAfv7XvXK0dtLYLmT2imLBAZbOrpxpb/vtTLTAmGRyoddUUXVLA19Eg4dr/ebIzI18flPzSNOrL9JKBbFzCDobl5WGP3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230022)(346002)(39830400003)(376002)(366004)(396003)(136003)(451199015)(31696002)(66946007)(6486002)(8676002)(5660300002)(66556008)(66476007)(8936002)(41300700001)(26005)(6512007)(44832011)(2616005)(38100700002)(478600001)(53546011)(6506007)(316002)(186003)(110136005)(31686004)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzcwM282UnZ4SDcxOHczZEw5Z3FYdG41TVdwNHE5YUdoZjNxcUlIeEw3Z3BM?= =?utf-8?B?bjRKaUlQNkR4YmRyVlhpYi9ZUTFWYitBTm95RnhsZGdvK0NKNFBTMjFudVBo?= =?utf-8?B?SUNZVDFvZnY5VGxQS2NnTFowb2lzRHRYL3BUckoxY3RDZmZSM3VwM1VDakpS?= =?utf-8?B?dmIrSFp6M1hkNXlsalZvWVpwVVpGMkdoUjRGRUtiRlgvaHVMc2hhZ2M4TUhQ?= =?utf-8?B?WmZCREZmcWd0UTBzMnJEOXl1Ti9CbE5LK3pRNmYzSDFrdEE1S09mY05MbS9y?= =?utf-8?B?bXVRVEVVSWhDZlppdkF3ODZjY2UxeXRwaUowWkg3L2tYRGxHbUtFQ0t1c1dY?= =?utf-8?B?bHdpNlhOelNOcURMd1N4Y3BQRm95KzY2bmlsVENzdkhicGlmaG1OMlhuclN0?= =?utf-8?B?ZGJXaXgrVG9zM1ZsMC9oWDRxS3pjVGsrZTdqQTVmNHJmMVZmaVYzZzFaQ3ZT?= =?utf-8?B?R3NsRDVrTDRMZEVWYjJoZnFxZEdid09RNXczMFU2UEZVSWxseWFSYitDVnAy?= =?utf-8?B?WWhVeGowZkR1TkhlbGl1TE1mcXYxSldsYzNZbkl6TnpDbDFvdGhrRzBCWFhn?= =?utf-8?B?S0lEb05LWnRiakNXdWZnNkN3M1FSQno0ZHdXc0lVQlN1STlDSmFFK2FiODRu?= =?utf-8?B?Y2ZKL2tYNTBocGF1b1dhUjd2WHluYVZ5UDBIbWJ6bDkrblZOcGppd1JzT01J?= =?utf-8?B?Tkxra000SVpqTTZTOUhyNnRmajVUczVkY0FDS1l4VkszU3E4aXRPcGNEeGJZ?= =?utf-8?B?Q3dsdzAwMXhBSzN3cS96T01MRzdXZlNEbEVVSVV2c2NzU293OFRjemVXT01u?= =?utf-8?B?WVloSWVQdDU1Zy9GeW96cG9MSlZTTHBkOS9UYVZjdzU3dk11UGI1MTRvbHRr?= =?utf-8?B?c0dsMXFWU25TVEt4ZCt2MTlKZjB4RktreFUrN1F4V2RUMVEwQ0gwWWNjNHRa?= =?utf-8?B?RHp6ajI0ZUVoMXU5Z2gwWElibjBOblVVeEptbTlMeEtuWndYMHN6ekFFbzRx?= =?utf-8?B?WW1tbUxNMHljSzlJbFB2VkI1RU04MnRjVHFKOW0zU09HUnI2MCttMmZUQmRs?= =?utf-8?B?OThFeHM1MkgrR29EMjFKdS8rbTk4MFNRc3hMT0ZiQnJ5dG82WlQ5UVdIZGdZ?= =?utf-8?B?K3lwS29rTHROVVNTaHFma3pnVldKZ0VFamp0UnZYVEU4SCtwSng2ZmNQNkNO?= =?utf-8?B?OXBiVkJBcFRSbm95YktCSFVzLzMrTG9mLzhTeWJESTU5UG9Zd3pxNHRGRXA1?= =?utf-8?B?OEc0WHRmVWw1akVTeGFxZjhhMVFzSWovZUxEN0RmZTMyeUZ6a1dBdVFNUjNi?= =?utf-8?B?M0xraE5GQnB4Y0EzMStmNkhIbXB2cnM2alNqR3hVZEFHblZKbFVhYXlQS0xG?= =?utf-8?B?amY0Y2VUNER3WjhWenFkQlZpRlhiT2VaamF2aFVNL3BLbThmTzJSbG5VbmEw?= =?utf-8?B?aW0rRkVwRzZNdm84cmxsdFJyaDFvUWtJNnNpSURid0hvaGNtS1owVjl4bm50?= =?utf-8?B?R2ttRXZQNjcvWnJ4MUhFMUk2TURsUy9BdHMyQXZDR2l2c0RyWlZpMzJSUWlX?= =?utf-8?B?SEhSL3VvYm9iT2c3cElVQW1HNnZkWFJOeG45NnpiaGYvQjZya1BzM3Faa0FW?= =?utf-8?B?UVpzYmMvMDdFT2pwckMzNnJLYkovN3E1aEh4RXB3aURGZDFsNysyS3BkOHNB?= =?utf-8?B?N3pOSEttZjBETVp1WlJjVnFJK21jTW9jTFpiRm5YVmczWmFWdE8vYzJlNXVR?= =?utf-8?B?VnQya0F2a2huVSszaC9GMjZrWWJVWjVweXV2NVR0c3dCaFdxUHJEWk1xWHVI?= =?utf-8?B?T2EreTFUeHhybnRVemZSTlNmaFhhQWlpdDgrUGd6ZEs2RVNIb1hsakVQeS80?= =?utf-8?B?V0xMUUIzTFBzNXFJYkJ5eUxNL3ZmbnhWbEpNSDhpNTgxRE81cnAxODNodGhM?= =?utf-8?B?VWQ5Nys2L0VBUlovMlE5LzlhL1BzM2ZaQ1l1S0hhYkYxdEVXaGxUL0U5TDB4?= =?utf-8?B?UXkzeHhtQm1WRFp5R1hwVHd1U0tlUnh3NTFqQnc2a2tqbVJSa3dQd25haVpT?= =?utf-8?B?ZldMRDNnT1kyK00reU04TWpyYThaWDFrK0o2aG1lUUg5a3VFL1VPaXJuUXFS?= =?utf-8?Q?rm35QqqZFtKstAbjN5i3Pmpk7?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74bab6e7-b835-4e8d-0d39-08dac976ac30 X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2022 15:07:55.9594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rev9ga/wp1pGrDi6neO6kBCqLYjUi/sWnl9lMpiFyXpRyWJL1d4EK+DzKJwk8JK7vyYyMdoMocK3mYagJq9dTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PR01MB8394 X-Spam-Status: No, score=-3033.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/22 03:30, Aktemur, Tankut Baris wrote: > Hi Simon, > > On Thursday, November 17, 2022 8:43 PM, Simon Marchi wrote: >> Before doing further changes to this file, change to use the :: notation >> instead of declaring global variables with the `global` keyword. > > Could you please give more clarification about why this is needed? > I fear that this could lead to divergence in the testsuite code-style, > where some files use the global keyword and others use the `::` notation, > similar to the inconsistency of the use of the 'then' keyword [1]. Hi Baris, This is not mandatory at all, just a cleanup. I've been suggesting to people for a while to use the :: notation instead of the global keyword, because I believe it makes things clearer, it avoids leaving stale global declarations, and it's just less lines of code. Since I use that notation whenever I make changes, I thought I would do a preparatory patch to change the test to use it, so that we don't end up with two styles in the same file, and I don't inter-mix orthogonal changes in one patch. That being said, it's true that it creates mixed styles in the testsuite (it is already the case, both styles are used). Unfortunately, it's not an as simple fix as the "then" thing, I don't think it can be a mass change done by regexes. Simon