From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66]) by sourceware.org (Postfix) with ESMTPS id F20B8385737C for ; Fri, 29 Apr 2022 10:39:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F20B8385737C ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Mk8v5yELzn2j6B7w3kFdEIzqC3mdn5yjfZPRUGBulsOxHpJf3+5uYpshrfqstaA7jm15CyxLbigfKJPeRRTuFrjW4YFDWHUGVY1eIzPd3XcjMY/cOLSusdhieVz9vQF5nplsluDiJV/nCuaT5D3pVMuvNrg5akxsiXXO4WMb08JTtAXfOZFgI8fsf46IHi4MQzXRxqtGr7JXHhWHAmGMR7T2icLZpkMzISt43Q7+924VHhmp2WEaSlqyJMBv+SI3fu1H1AG+q4zZM8RqTd6MI0Wj9yFb2EBE0trOgR3/MzWlN3pd0DGRURPVNpnqSLYPK33fQhX6FoRl5/us3QXAcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BxE5Ns1Uc1QpQd/F2K/jDTsU0MA148rHidJm1GW6NlA=; b=jAO1kF8BUB9LZaJbjiIpAEEL5F9mDnxFAsX6mcRYXxP9lSOEaGysANJqSkcSk+3FCsw9N79fkE+xtV+haQARyFDlrTy60HRTeEVxHRhm169RH0Lv9KTJGPHzOI6U3C73WoZdqgLYiqdewXy9uE8xK3tDgmQat5ehaI0gkjYAwqglhBpa+ihQDTrxOESTq2RNSJXAEtfa/U6PCoMmkn3gs2w6CE6nUcayJtCiS/XZRJO1k5lH8XeYOwEIrherEBPmP6jHh7C8SOSjpv0LZcm1r6IiRrWGScB8v4hNl9RLSj7n7u1iSXkodwlLHXHaiVTFamaZA2jds0f3YR63NxV8mQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR06CA0773.eurprd06.prod.outlook.com (2603:10a6:20b:484::28) by AM0PR08MB3265.eurprd08.prod.outlook.com (2603:10a6:208:56::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 10:39:32 +0000 Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:484:cafe::6e) by AS9PR06CA0773.outlook.office365.com (2603:10a6:20b:484::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.18 via Frontend Transport; Fri, 29 Apr 2022 10:39:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.12 via Frontend Transport; Fri, 29 Apr 2022 10:39:31 +0000 Received: ("Tessian outbound ab7864ef57f2:v118"); Fri, 29 Apr 2022 10:39:31 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e20fd050245d9b1f X-CR-MTA-TID: 64aa7808 Received: from ba96f7fd91af.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 906246B5-BBCF-442A-8CBD-E33BEFBFEDA0.1; Fri, 29 Apr 2022 10:39:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ba96f7fd91af.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Apr 2022 10:39:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWvW8erwdhshBb6NtpchA9ANZY87KE28GO/NGwBM1ek6AxsGm6aFv4qVsSUYVo6tvuyrHKjGro4Yg6R2ZSkMqo+0ecJGEIwGvu+oO0PlDmf6YS/ld7qmh3szENsMT0hD0wX6WXzNtRlNP68QT1t6sxv8DrfdqDSbYAeTBpL1dRPbo7I5XAN2DS5tBjr1pChTl9+gFp/eRELw+GKN3WUTNwyhSIzt5vmvY2Om2e8ivX0w/Fs2B4WE0d64rDqW5IJ/ViqJa5UJjA37r7lnFKbQ+YCeOwMGEnuXkO7qJQhl8BvPqxW60MOGaDtHtTV8uqo9BUIwK6njYVV1w0yo42G6og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BxE5Ns1Uc1QpQd/F2K/jDTsU0MA148rHidJm1GW6NlA=; b=LIsCQY3B46JvbQe4hef2VyAisflVtDPZ7jVmEiXnWahjU7Yjw9MOcvRC5fJfvHdQ4jji73R7HYbsoHcinHgqDx2GpQAs4dkfgASerz0NgHbK8v915fMNjU/kxrvpzcHMNt0aq1sQYe3tOn2zzy0+5cpM4uWYLy7Io7oO9jcVzTqjFlOTUA96dkAzii3e1TgBZoXUxvCU1290qgzclH+JLTWNslD0PEe7gZTefGI9pgGbN+8TaaiamhtESeHlH/GKEQdd/8QoEHo9crRq/rZ1vozmNWxvQosVU3mLMmQI9VtETAxGarfL4fxUH/s1vJ/VKT/gYoJF2Sn6x0pW+Aojog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM6PR08MB3880.eurprd08.prod.outlook.com (2603:10a6:20b:86::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Fri, 29 Apr 2022 10:39:20 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7080:6233:cf8f:a8a6%7]) with mapi id 15.20.5186.023; Fri, 29 Apr 2022 10:39:19 +0000 Message-ID: Date: Fri, 29 Apr 2022 11:39:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] Fix crash with "maintenance print arc" Content-Language: en-US To: Andrew Burgess , Tom Tromey , Luis Machado via Gdb-patches References: <20220427100753.364631-1-luis.machado@arm.com> <87h76dmdp9.fsf@tromey.com> <6d4bd7ec-89de-c115-3205-b0d1999b3aab@arm.com> <87mtg4nqfv.fsf@redhat.com> From: Luis Machado In-Reply-To: <87mtg4nqfv.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0232.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::21) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e997b6c1-6ecc-4d43-037d-08da29cc8bbb X-MS-TrafficTypeDiagnostic: AM6PR08MB3880:EE_|VE1EUR03FT008:EE_|AM0PR08MB3265:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 574nutlKy7uFjsQYSfhGmUNQdT+t9QBDnEfNFmlXv0511GmnYF9I/hC116XH0xe0l1vLt+vgXUhzVqe/nIm8a9cmVd2qS2E2wrRYGd6u2bbr2jNiikiL4d+j/O/mqjtvJaUx8f5HOj7QmcyKyXVCN+jKocphldfXGrDvqCD5doVlJxccYnYhrI5GUcDid0F+5Lz7GYZHVa7v2fBB6jsRiuq7DgNs3uzMwHvNWxKqpP4MznGVbAW81HnVU6AEm5SnVhii2UZkRGsytC0XHa7JXAJzZpEn9a6uWNlgdX/k/qMXHq0/4AYt3s3siEKirilq0zhADHrA9IhYbNr/st9v2uexd8E6QdGVjbREhI/RmhgKCQ8U9p15cp1Ai7rb7P/PDqHxCYB/gIXxcdtiUaz9+XE+Zd+xGg5Q24wVt3r68cOkNYeJAFyNIbz+LRBNWYEsoMS7QTSOp0zle231H0lc2ldHZEyrof9kRkHrUWuVYR1MAzKuVxoG98I/8+5hEtKQSKuXtw3sdR3FLEJ+t7D7wluqRCfWCNAMa928pjNdhQlUMt3UezSsVQkbsJaP/CBaMZ1RhUKIHt4vHQmQLqOJWqogEgpSXF97o0aRRgQlMO4SJTWGD+nNlsADep/4bZueyVjr2QXTz4ap0HnVlX0VCKTCq/YV7pbaUN6kV72PPJmVmU+EjCS3XOP4QwdBPfrrBiQbMOzhcFOGkA2PTKEr3m3y5ETwslk+kucdvPebGPc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(2906002)(53546011)(508600001)(26005)(6486002)(6512007)(6506007)(8936002)(5660300002)(31686004)(44832011)(38100700002)(31696002)(83380400001)(86362001)(66556008)(2616005)(186003)(8676002)(66476007)(66946007)(36756003)(316002)(110136005)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3880 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b692a052-85e3-43b5-bfe2-08da29cc83ee X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9EQStzh9L7IXY1k5zBvLLY6hx6N01iNR98hBr28PdyolN9rnT4bw0o5oWEJiGDQmrB5FEdmx6TbzesLx1BaYtdTXC1aLskv/1zE/fgCzoOqXXYIWn+bYBWSHlXHnBg4a2PnzGCPCMQmtJ7tlVt/pfyxJEwaJQNJdqbIqpDqxBUKzTWtnUp5/HJ3/q288jaCjrVC4wZ2aXUGB3wjRyI6Xyi2AFhxNInKaTegQP+GldswF7+l30XKcudxkNAeeZeLBln0ilWv2W0Q4pSKv+gPA3tq2Qf04VA7OfjhAAzU4QmEZyalzaEFi6SAbTP8Hq+yyhMG4dwkpknNpBNoIar5UOJuqNCRRSdgsF3D4nvwNPbG40hVYIyzUeE8/5+7rNlphXNMhhWpE87N3EF+wd+AR7A77pjDiFyed5wQ39Z2PObFA3ag1KVJTwVgV2Vd8blfXLLrwTHQ0T0zx/QNosREjj5KBlD+iAijGRjxOBg+P9jY5oBqfv5HgAt3vLRRwd9YROLs6EG7Gn5qjD8kHTNhTtE9SW7Dg4fPZbONLhBePtbjMoUEoQYxELDYjOUknNhSmUsCsLt3qJD2NBKKvUZ/WyntQvpXWGO7ncQf3vj0VPokNkzPkO63mkO06zCVopw66RUzU6T8fC/eNIhvO7d4uliVZuz1bmoLmThoZLsnJQE2UmJzxOasOhWMelPJqmFMViezVM3ZH0sNoTHq+vPWRmg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(5660300002)(356005)(186003)(8936002)(83380400001)(508600001)(81166007)(336012)(82310400005)(40460700003)(2616005)(44832011)(70586007)(6486002)(70206006)(8676002)(47076005)(86362001)(31686004)(2906002)(26005)(36860700001)(316002)(110136005)(53546011)(6506007)(6512007)(36756003)(31696002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2022 10:39:31.9609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e997b6c1-6ecc-4d43-037d-08da29cc8bbb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3265 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2022 10:39:37 -0000 On 4/29/22 11:18, Andrew Burgess wrote: > Luis Machado via Gdb-patches writes: > >> On 4/28/22 16:26, Tom Tromey wrote: >>>>>>>> "Luis" == Luis Machado via Gdb-patches writes: >>> >>> Luis> While doing something else, I noticed GDB crashed with >>> Luis> "maintenance print arc". >>> >>> I think the bug here is that this uses add_show_prefix_cmd and not >>> add_basic_prefix_cmd. See the appended, which also fixes the crash. >> >> Ah, you're right. It did look odd why we were feeding maint commands to >> code that is supposed to handle show commands. >> >>> >>> Luis> This happens because the code expects to find a "show" string pattern >>> Luis> within "maintenance print arc", since "arc" here is a prefix, and skip it. >>> Luis> In this case though, it won't find it, and we will have a bad pointer >>> Luis> getting dereferenced. >>> >>> This looks reasonable to me. >> >> Should we prevent further situations like this by asserting that we >> don't have a class_maintenance prefix being registered as a show >> prefix? > > Would this not trigger for all the existing 'maint show ...' commands? > Ah, we have a "maint show" command. I wasn't aware of it until now. Isn't this particular behavior a bit strange though? "maintenance" will always output the maintenance prefix, except for "maintenance show", which removes the show part. It might be historical.