From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D02573858401 for ; Mon, 1 Nov 2021 13:17:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D02573858401 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-598-HDfr9yaLN8O7g5TTm4OnjQ-1; Mon, 01 Nov 2021 09:17:26 -0400 X-MC-Unique: HDfr9yaLN8O7g5TTm4OnjQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6CF05100B703; Mon, 1 Nov 2021 13:17:25 +0000 (UTC) Received: from [10.97.116.50] (ovpn-116-50.gru2.redhat.com [10.97.116.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0124D694B6; Mon, 1 Nov 2021 13:17:23 +0000 (UTC) Message-ID: Date: Mon, 1 Nov 2021 10:17:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PING*2][PATCH v3 0/2] [gdb] untie and validate inheritance location From: Bruno Larsen To: gdb-patches@sourceware.org Cc: simon.marchi@efficios.com References: <20210930192647.31897-1-blarsen@redhat.com> <461f4ea1-8534-a6dc-c50d-2e6dd7522da1@redhat.com> In-Reply-To: <461f4ea1-8534-a6dc-c50d-2e6dd7522da1@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 13:17:29 -0000 ping On 10/19/21 16:15, Bruno Larsen wrote: > ping > > On 9/30/21 16:26, Bruno Larsen wrote: >> This started with what was thought of as an incorrect inheritance >> location expression, but turned out to be a correct, but unusual >> expression, and uncovered an incorrect assumption when calculating >> offsets of baseclasses. >> >> This patchset is the new iteration of that solution, that changed >> gnuv3_baseclass_offset calculation to allow for non-virtual inheritance >> that has a non-trivial location expression and also moved the basic >> validation to this function. The check in value_contents_copy_raw was >> changed to an assert. >> Finally, the test was expanded to have one incorrect trivial location, >> and two non-trivial location expressions, one correct and one incorrect. >> >> Bruno Larsen (2): >>    [gdb] Untied inheritance virtuality and loc kind >>    [gdb] Add Simple offset validation when calculating baseclass_offset >> >>   gdb/gnu-v3-abi.c                              |  23 +- >>   .../gdb.dwarf2/dw2-inheritance-locexpr-1.exp  | 233 +++++++++++++++++ >>   .../gdb.dwarf2/dw2-inheritance-locexpr-2.exp  | 235 ++++++++++++++++++ >>   .../gdb.dwarf2/dw2-inheritance-locexpr.c      |  69 +++++ >>   gdb/value.c                                   |   8 +- >>   5 files changed, 561 insertions(+), 7 deletions(-) >>   create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr-1.exp >>   create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr-2.exp >>   create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-inheritance-locexpr.c >> > > -- Cheers! Bruno Larsen