From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 461CF3858C2C for ; Thu, 30 Sep 2021 12:31:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 461CF3858C2C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 18UCUR0g020606 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Sep 2021 08:30:32 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 18UCUR0g020606 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1E0B31EDF7; Thu, 30 Sep 2021 08:30:27 -0400 (EDT) Message-ID: Date: Thu, 30 Sep 2021 08:30:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v4 1/4] gdb: Introduce setting construct within cmd_list_element Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org References: <20210929215011.1489639-1-lsix@lancelotsix.com> <20210929215011.1489639-2-lsix@lancelotsix.com> <90e82ecb-d1ab-d866-ccdb-b6ab64e52f5e@polymtl.ca> From: Simon Marchi In-Reply-To: <90e82ecb-d1ab-d866-ccdb-b6ab64e52f5e@polymtl.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 30 Sep 2021 12:30:27 +0000 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 12:31:35 -0000 On 2021-09-30 08:12, Simon Marchi via Gdb-patches wrote: >> @@ -667,26 +701,35 @@ get_setshow_command_value_string (const cmd_list_element *c) >> break; >> case var_uinteger: >> case var_zuinteger: >> - if (c->var_type == var_uinteger >> - && *(unsigned int *) c->var == UINT_MAX) >> - stb.puts ("unlimited"); >> - else >> - stb.printf ("%u", *(unsigned int *) c->var); >> + { >> + unsigned int const value = var.get (); > > As Pedro mentioned, we prefer "const unsigned int" (here and below). > > LGTM with that fixed. In fact, I tried to build it and there's a build failure due to a recent change: CXX bt-utils.o In file included from /home/simark/src/binutils-gdb/gdb/../gdbsupport/common-defs.h:201, from /home/simark/src/binutils-gdb/gdb/defs.h:28, from /home/simark/src/binutils-gdb/gdb/bt-utils.c:18: /home/simark/src/binutils-gdb/gdb/bt-utils.c: In function ‘void gdb_internal_backtrace_set_cmd(const char*, int, cmd_list_element*)’: /home/simark/src/binutils-gdb/gdb/bt-utils.c:32:18: error: ‘struct cmd_list_element’ has no member named ‘var_type’ 32 | gdb_assert (c->var_type == var_boolean); | ^~~~~~~~ /home/simark/src/binutils-gdb/gdb/../gdbsupport/gdb_assert.h:35:13: note: in definition of macro ‘gdb_assert’ 35 | ((void) ((expr) ? 0 : \ | ^~~~ I think the change below should fix it. Since it's one of those settings that reverts the value if the new value is invalid, it could eventually be changed to use a getter/setter, so that the setter simply rejects the new value if it's not valid. >From 96df63a390451e0bbdfc74784ea09a3aa360656d Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 30 Sep 2021 08:26:41 -0400 Subject: [PATCH] fix Change-Id: Id78157cacf2de9cfacba1f19dea17b0f7b65aa0f --- gdb/bt-utils.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/bt-utils.c b/gdb/bt-utils.c index 79e6e090d428..2054e68c6e5a 100644 --- a/gdb/bt-utils.c +++ b/gdb/bt-utils.c @@ -29,15 +29,15 @@ gdb_internal_backtrace_set_cmd (const char *args, int from_tty, cmd_list_element *c) { gdb_assert (c->type == set_cmd); - gdb_assert (c->var_type == var_boolean); - gdb_assert (c->var != nullptr); + gdb_assert (c->var->type () == var_boolean); + gdb_assert (c->var.has_value ()); #ifndef GDB_PRINT_INTERNAL_BACKTRACE - bool *var_ptr = (bool *) c->var; + bool val = c->var->get (); - if (*var_ptr) + if (val) { - *var_ptr = false; + c->var->set (false); error (_("support for this feature is not compiled into GDB")); } #endif -- 2.33.0