From: Keith Seitz <keiths@redhat.com>
To: Jiangshuai Li <jiangshuai_li@linux.alibaba.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH v2] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c
Date: Thu, 22 Sep 2022 14:00:50 -0700 [thread overview]
Message-ID: <f69cbd6f-c2e9-2ebb-97ef-509d1fc827bc@redhat.com> (raw)
In-Reply-To: <20220922022500.8114-1-jiangshuai_li@linux.alibaba.com>
On 9/21/22 19:25, Jiangshuai Li via Gdb-patches wrote:
> Add cskyv2-linux.xml for re-generating cskyv2-linux.c if needed.
> Also update cskyv2-linux.c.
> ---
> gdb/arch/csky.c | 2 +-
> gdb/features/Makefile | 1 +
> gdb/features/cskyv2-linux.c | 162 +++++++++++++++++-----------------
> gdb/features/cskyv2-linux.xml | 102 +++++++++++++++++++++
> 4 files changed, 185 insertions(+), 82 deletions(-)
> create mode 100644 gdb/features/cskyv2-linux.xml
This looks correct now. Thank you for taking care of this.
[IIUC Tom has already pre-approved with these updates. I think you're
clear to commit.]
Keith
prev parent reply other threads:[~2022-09-22 21:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-22 2:25 Jiangshuai Li
2022-09-22 21:00 ` Keith Seitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f69cbd6f-c2e9-2ebb-97ef-509d1fc827bc@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jiangshuai_li@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).