From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 078E43858D38 for ; Thu, 22 Sep 2022 21:00:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 078E43858D38 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-rdjQU4FJM2iYJLYbcEX4ag-1; Thu, 22 Sep 2022 17:00:52 -0400 X-MC-Unique: rdjQU4FJM2iYJLYbcEX4ag-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0C95B2932487; Thu, 22 Sep 2022 21:00:52 +0000 (UTC) Received: from [10.2.17.232] (unknown [10.2.17.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAE4E2027061; Thu, 22 Sep 2022 21:00:51 +0000 (UTC) Message-ID: Date: Thu, 22 Sep 2022 14:00:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2] gdb/csky add cskyv2-linux.xml for cskyv2-linux.c To: Jiangshuai Li , gdb-patches@sourceware.org References: <20220922022500.8114-1-jiangshuai_li@linux.alibaba.com> From: Keith Seitz In-Reply-To: <20220922022500.8114-1-jiangshuai_li@linux.alibaba.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2022 21:00:57 -0000 On 9/21/22 19:25, Jiangshuai Li via Gdb-patches wrote: > Add cskyv2-linux.xml for re-generating cskyv2-linux.c if needed. > Also update cskyv2-linux.c. > --- > gdb/arch/csky.c | 2 +- > gdb/features/Makefile | 1 + > gdb/features/cskyv2-linux.c | 162 +++++++++++++++++----------------- > gdb/features/cskyv2-linux.xml | 102 +++++++++++++++++++++ > 4 files changed, 185 insertions(+), 82 deletions(-) > create mode 100644 gdb/features/cskyv2-linux.xml This looks correct now. Thank you for taking care of this. [IIUC Tom has already pre-approved with these updates. I think you're clear to commit.] Keith