From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id E13DB3858D1E for ; Fri, 8 Sep 2023 17:03:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E13DB3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40078c4855fso24596925e9.3 for ; Fri, 08 Sep 2023 10:03:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694192598; x=1694797398; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fBG/g8rUV6gULMCUmOt00/XVWSFMz1VoOwhCDj2e5pk=; b=ws5/E+E0+E9kgpOT4m/lJFEPF/hnZdXYS0G/bjVpJURxeDRAsUt9BWmlYcl8M6L3NY Wn/rZvYVvMI6/trA8DJkcPT4nzynnTzxtdOZ3rA+FcnM3sQJWyA6I3x2x5qlPT9o5Fmw 9sVLCJHkBI/fd1021U/c8zH1qmKrx0c6ie0lAO2kCGYoYrDw5CHJ91HRWYTQWW3L1bSN UJGNmqe/BjA+He3sKNip+TRunJTNl+68dGUX4sjXD3hvcW8+hX2Ysmbj6k9/0BVPbesQ BLErbTt34Ddj2Yv2gT5nyEB/6kI/5RR/UDC+8pD1Ztx3LuVeqbqwskSnOENjg9xJp4ft yEMA== X-Gm-Message-State: AOJu0Yzo2Cwv8NkTWP+eLS2fst+2Lp6/wE5LLBYoqe00dJeVvO2yv3y7 Js4M/QnUMaaK/1BAVCPNdTuEuPfi5Do3wA== X-Google-Smtp-Source: AGHT+IHht32ElUvRaYkbU42VJ68LylA/Iii8+gPXCMW4dDI0NOCQA1EIRRcg75CpBO1ENOKmhjS46w== X-Received: by 2002:a05:600c:b44:b0:401:dc7c:2488 with SMTP id k4-20020a05600c0b4400b00401dc7c2488mr2728766wmr.11.1694192597626; Fri, 08 Sep 2023 10:03:17 -0700 (PDT) Received: from ?IPV6:2001:8a0:f939:d200:2364:7f7a:f95f:4eb1? ([2001:8a0:f939:d200:2364:7f7a:f95f:4eb1]) by smtp.gmail.com with ESMTPSA id e26-20020a05600c219a00b003feea62440bsm2441216wme.43.2023.09.08.10.03.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Sep 2023 10:03:17 -0700 (PDT) Message-ID: Date: Fri, 8 Sep 2023 18:03:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 2/2] gdb/doc: describe x87 registers Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20230908152102.32731-1-simon.marchi@efficios.com> <20230908152102.32731-2-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: <20230908152102.32731-2-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-09-08 16:20, Simon Marchi via Gdb-patches wrote: > While investigating this [1], I initially had no idea what register > "fioff" stood for, making it difficult to map it to something in the > Intel or AMD manuals. Similarly, I can imaging someone familiar with > x87 to want to print the "x87 last instruction address", and have no > clue that GDB makes it available as register "fioff". The names of the > x87 state fields don't seem to be standardized, they even change between > sections of the Intel manual (between the FSAVE, FXSAVE and XSAVE area > descriptions). > > Add some details to the doc to help one map GDB register names to x87 > state fields. > Thanks for implementing this! Just one nit below: > +@subsubsection x87 registers > + > +GDB provides access to the x87 state through the following registers: GDB -> @value{GDBN}