Re: [FYI/pushed v4 00/25] Step over thread clone and thread exit

[Tom de Vries <tdevries@suse.de>]

On 11/14/23 11:51, Pedro Alves wrote:
> Hi Tom,
> 
> On 2023-11-13 19:28, Tom de Vries wrote:
> 
>> I'm seeing new FAILs:
>> ...
>> FAIL: gdb.threads/stepi-over-clone.exp: continue
>> FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: stepi
>> FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: $thread_count == 2
> 
> ...
> 
>> ...
>>
>> First in more detail:
>> ...
>> (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch process syscalls
>> continue^M
>> Continuing.^M
>> ^M
>> Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M
>> warning: 78     ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory^M
>> (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue
>> ...
>>
> 
> Thanks.  I think the patch below would fix this one.  

It does, thanks.

> The others are hopefully something similar,
> but I wasn't able to spot anything wrong by inspection.  I'd have to see the relevant part of the
> gdb.log to hazard a better guess.
> 
> 

I've managed to fix those as wel.  Posted here ( 
https://sourceware.org/pipermail/gdb-patches/2023-November/204118.html ).

[ I've submitted it as regular patch rather than attaching it here to 
make sure git-pw will pick it up. ]

Thanks,
- Tom

> --- 8< ---
> From: Pedro Alves <pedro@palves.net>
> Subject: [PATCH] Fix gdb.threads/stepi-over-clone.exp regexp
> 
> Tom de Vries reported this FAIL:
> 
>   (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch process syscalls
>   continue^M
>   Continuing.^M
>   ^M
>   Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M
>   warning: 78     ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory^M
>   (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue
> 
> All but one regexps in the .exp file use "clone\[23\]?" with "?" to
> also accept "clone", except the failing case.  This commit fixes that
> case to also use "?".
> 
> Change-Id: I74ca9e7d4cfe6af294fd50e8c509fcbad289b78c
> ---
>   gdb/testsuite/gdb.threads/stepi-over-clone.exp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.threads/stepi-over-clone.exp b/gdb/testsuite/gdb.threads/stepi-over-clone.exp
> index 4c496429632..18cfec19ffa 100644
> --- a/gdb/testsuite/gdb.threads/stepi-over-clone.exp
> +++ b/gdb/testsuite/gdb.threads/stepi-over-clone.exp
> @@ -45,7 +45,7 @@ gdb_test_multiple "catch syscall group:process" "catch process syscalls" {
>   }
>   
>   gdb_test "continue" \
> -    "Catchpoint $decimal \\(call to syscall clone\[23\]\\), .*"
> +    "Catchpoint $decimal \\(call to syscall clone\[23\]?\\), .*"
>   
>   # Return true if INSN is a syscall instruction.
>   
> 
> base-commit: 319b460545dc79280e2904dcc280057cf71fb753