From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 315463858D20 for ; Tue, 14 Nov 2023 13:38:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 315463858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 315463858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699969103; cv=none; b=tMBH80B7UtyaNale9CuItnwsjNxqFS1IWcToZIYZBpf8lle/3j6A5Ga0KS3qXt440LXhqdwQyaGikGdtIRWFV3W8za9CAo12lSDpkdFkTfr5zEM8MuFfreNu+/9MWw9KKuH6k/8zLUnM0DPriuyMQMRm509RRaZ6nRT9KZjRsTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699969103; c=relaxed/simple; bh=zjrpO4+GP0UUuTJhzf0YLRRr64mbTcI+933utTOvTAc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=JSegIcYQQ2elX1dYw1TDimdranBv2JpO6QR55th+sLVvIQV/JsVXdbKHNNQA74NyZrqX9ip/Gh9lkgqCSkzlj9fdwad/0UaybNKE4Wuz3ZalOsYnHgJvw3OMLYs2gaImRZgg5tQXAa35OwUFKJk0rYlOfPjhBOjFG9YOkXvEigk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BD1E021890; Tue, 14 Nov 2023 13:38:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699969099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i3VVZ65Fb4MqSo9Gd+OTYHhfNvHywViBuAZqZ9vN8aI=; b=B2tLzI4CYCERyyE3L4DIK9eL1oDXTmTsVptaoWdmpvTf3Y1fr75sRjxVfSMZHfAKx244zQ T6mDPy0Af2whrKn42lEMrehgyQ9h6ihut7wSXV0MXldcXxUvH4yaMPsoFZYUfHGi9qByOI /seLM0VPJNnHBscN5lk9gkvsTtTh2OA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699969099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i3VVZ65Fb4MqSo9Gd+OTYHhfNvHywViBuAZqZ9vN8aI=; b=d2gAkn4aeWi9oq9gtEvbWYeSYOjIkc16EAU5L/OPfAiiRNNK60Kklh7msnpD/L4GhUT/qV pEari6Yr5DzCzCBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A642F13460; Tue, 14 Nov 2023 13:38:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gsluJ0t4U2UrEwAAMHmgww (envelope-from ); Tue, 14 Nov 2023 13:38:19 +0000 Message-ID: Date: Tue, 14 Nov 2023 14:39:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [FYI/pushed v4 00/25] Step over thread clone and thread exit Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20231113150427.477431-1-pedro@palves.net> <2a6fd4e6-d01f-45ec-b12a-b1e157a27195@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -7.09 X-Spamd-Result: default: False [-7.09 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-3.00)[100.00%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/14/23 11:51, Pedro Alves wrote: > Hi Tom, > > On 2023-11-13 19:28, Tom de Vries wrote: > >> I'm seeing new FAILs: >> ... >> FAIL: gdb.threads/stepi-over-clone.exp: continue >> FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: stepi >> FAIL: gdb.threads/stepi-over-clone.exp: third_thread=false: non-stop=on: displaced=off: i=0: $thread_count == 2 > > ... > >> ... >> >> First in more detail: >> ... >> (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch process syscalls >> continue^M >> Continuing.^M >> ^M >> Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M >> warning: 78     ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory^M >> (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue >> ... >> > > Thanks. I think the patch below would fix this one. It does, thanks. > The others are hopefully something similar, > but I wasn't able to spot anything wrong by inspection. I'd have to see the relevant part of the > gdb.log to hazard a better guess. > > I've managed to fix those as wel. Posted here ( https://sourceware.org/pipermail/gdb-patches/2023-November/204118.html ). [ I've submitted it as regular patch rather than attaching it here to make sure git-pw will pick it up. ] Thanks, - Tom > --- 8< --- > From: Pedro Alves > Subject: [PATCH] Fix gdb.threads/stepi-over-clone.exp regexp > > Tom de Vries reported this FAIL: > > (gdb) PASS: gdb.threads/stepi-over-clone.exp: catch process syscalls > continue^M > Continuing.^M > ^M > Catchpoint 2 (call to syscall clone), clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:78^M > warning: 78 ../sysdeps/unix/sysv/linux/x86_64/clone.S: No such file or directory^M > (gdb) FAIL: gdb.threads/stepi-over-clone.exp: continue > > All but one regexps in the .exp file use "clone\[23\]?" with "?" to > also accept "clone", except the failing case. This commit fixes that > case to also use "?". > > Change-Id: I74ca9e7d4cfe6af294fd50e8c509fcbad289b78c > --- > gdb/testsuite/gdb.threads/stepi-over-clone.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.threads/stepi-over-clone.exp b/gdb/testsuite/gdb.threads/stepi-over-clone.exp > index 4c496429632..18cfec19ffa 100644 > --- a/gdb/testsuite/gdb.threads/stepi-over-clone.exp > +++ b/gdb/testsuite/gdb.threads/stepi-over-clone.exp > @@ -45,7 +45,7 @@ gdb_test_multiple "catch syscall group:process" "catch process syscalls" { > } > > gdb_test "continue" \ > - "Catchpoint $decimal \\(call to syscall clone\[23\]\\), .*" > + "Catchpoint $decimal \\(call to syscall clone\[23\]?\\), .*" > > # Return true if INSN is a syscall instruction. > > > base-commit: 319b460545dc79280e2904dcc280057cf71fb753