From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <m.weghorn@posteo.de>
Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65])
 by sourceware.org (Postfix) with ESMTPS id 0CD19383F843
 for <gdb-patches@sourceware.org>; Tue, 12 May 2020 15:50:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0CD19383F843
Received: from submission (posteo.de [89.146.220.130]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 071E1160060
 for <gdb-patches@sourceware.org>; Tue, 12 May 2020 17:50:44 +0200 (CEST)
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 49M2MR39VHz9rxm;
 Tue, 12 May 2020 17:50:43 +0200 (CEST)
Subject: Re: [PATCH 0/4] gdb: Move construct_inferior_arguments to gdbsupport
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
References: <20200429111638.1327262-1-m.weghorn@posteo.de>
 <20200429111638.1327262-2-m.weghorn@posteo.de>
 <c7f2a9e0-6e05-ba13-6092-56b86b58b709@simark.ca>
From: Michael Weghorn <m.weghorn@posteo.de>
Message-ID: <f6fef84a-f256-56b5-eb1a-08f5f6c094c1@posteo.de>
Date: Tue, 12 May 2020 17:50:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <c7f2a9e0-6e05-ba13-6092-56b86b58b709@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4,
 RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2020 15:50:46 -0000

On 07/05/2020 21.31, Simon Marchi wrote:
>> diff --git a/gdbsupport/common-inferior.cc b/gdbsupport/common-inferior.cc
>> index ed16e89a52..71b9a11e02 100644
>> --- a/gdbsupport/common-inferior.cc
>> +++ b/gdbsupport/common-inferior.cc
>> @@ -24,3 +24,126 @@
>>  /* See common-inferior.h.  */
>>  
>>  bool startup_with_shell = true;
>> +
>> +/* Compute command-line string given argument vector.  This does the
>> +   same shell processing as fork_inferior.  */
> 
> Let's just do a bit of spring cleaning and align this code with our current
> standards while moving it.  Move the function comment to the .h, and in the.cc
> file write:
> 
>   /* See common-inferior.h. */
> 
> Other than that, this patch LGTM.
> 
> Simon
> 

I've moved the comment in the new version,
https://sourceware.org/pipermail/gdb-patches/2020-May/168346.html

Michael