From: Simon Marchi <simon.marchi@ericsson.com>
To: Tom Tromey <tom@tromey.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFA v2 00/10] Remove some cleanups from linespec.c
Date: Thu, 05 Apr 2018 03:08:00 -0000 [thread overview]
Message-ID: <f73a2cba-e073-d17a-14f2-18cef58b7d8d@ericsson.com> (raw)
In-Reply-To: <20180404044049.31481-1-tom@tromey.com>
On 2018-04-04 12:40 AM, Tom Tromey wrote:
> Here's the second version of the series to remove some cleanups from
> linespec.c.
>
> I believe this version addresses all the review comments.
>
> Regression tested by the buildbot.
>
> Tom
>
I took a quick look again, LGTM.
Thanks!
Simon
prev parent reply other threads:[~2018-04-05 3:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 4:40 Tom Tromey
2018-04-04 4:40 ` [RFA v2 02/10] Fix some indentation in linespec.c Tom Tromey
2018-04-04 4:40 ` [RFA v2 07/10] Change streq to return bool Tom Tromey
2018-04-04 4:41 ` [RFA v2 10/10] Remove unnecessary include from linespec.h Tom Tromey
2018-04-04 4:41 ` [RFA v2 06/10] Remove a string copy from event_location_to_sals Tom Tromey
2018-04-04 4:41 ` [RFA v2 09/10] Remove typep and VEC(typep) from linespec.c Tom Tromey
2018-04-04 4:41 ` [RFA v2 05/10] Have filter_results take a std::vector Tom Tromey
2018-04-04 4:41 ` [RFA v2 08/10] More use of std::vector in linespec.c Tom Tromey
2018-04-04 4:41 ` [RFA v2 04/10] Return std::string from canonical_to_fullform Tom Tromey
2018-04-04 4:41 ` [RFA v2 03/10] Make copy_token_string return unique_xmalloc_ptr Tom Tromey
2018-04-04 4:41 ` [RFA v2 01/10] Remove some cleanups from search_minsyms_for_name Tom Tromey
2018-04-05 3:08 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f73a2cba-e073-d17a-14f2-18cef58b7d8d@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).