From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14209 invoked by alias); 5 Apr 2018 03:08:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14198 invoked by uid 89); 5 Apr 2018 03:08:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:346 X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Apr 2018 03:08:17 +0000 Received: from ESESSHC003.ericsson.se (Unknown_Domain [153.88.183.27]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id EE.8F.21035.F1395CA5; Thu, 5 Apr 2018 05:08:15 +0200 (CEST) Received: from ESESSMR501.ericsson.se (153.88.183.108) by ESESSHC003.ericsson.se (153.88.183.27) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 5 Apr 2018 05:08:14 +0200 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSMR501.ericsson.se (153.88.183.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26; Thu, 5 Apr 2018 05:08:14 +0200 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26 via Frontend Transport; Thu, 5 Apr 2018 05:08:14 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by DM5PR1501MB2007.namprd15.prod.outlook.com (2603:10b6:4:a1::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Thu, 5 Apr 2018 03:08:12 +0000 Subject: Re: [RFA v2 00/10] Remove some cleanups from linespec.c To: Tom Tromey , References: <20180404044049.31481-1-tom@tromey.com> From: Simon Marchi Message-ID: Date: Thu, 05 Apr 2018 03:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180404044049.31481-1-tom@tromey.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXPR0101CA0019.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:15::32) To DM5PR1501MB2007.namprd15.prod.outlook.com (2603:10b6:4:a1::37) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cda6e59-9b11-4921-c295-08d59aa277aa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:DM5PR1501MB2007; X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2007;3:478NkjSqiVuuMw2XK6pCKJPp0ZyqA2H/V3wCLeOMAiTRkMzwqUhEjQjMYgoE674BHKFaCOnrDQjgKi1WBwSZp3BQxZE8CL4u4lKQvRuGsMfMfOV/a1X6ULPdws5tvJjVwO76d2eqvsMaLZxpAd1FHD57MSeb7SWVotGid0pzpPLuRGYi3+bZw977z5COksojKQ5W2XJg7urYE6QLLBV7hbo4A023miMOV1T8KEJPyyR3/aLGhaLfMj0JGNwSJU7c;25:xf6A1rkjCZaMttxdK86AVo6xm8lZKh8rlB6fb8Tu72bDPjOrX3yNxp3/h0aAUYLv2fHH3+3ApTgQ90ZWcJbHonA9eoBeXcf4GYTzUoLIEnCYD9Kb+ic+m2rCtBWKYlX8UZZYGj07amq1NVD31fmtvIPb1wfBa1D2dmxxcFoq5lH1THkGRVVGtAPLaGEz0cPECSfFMrRiaZptbeIyanxMIcdYnE/J8ilhdXjzfi61J+y9sxmBwloJHK8+JMtKNG7RZgyKaS0KQKO1w/B8sJ/VglEWj8DEmfc7dL/FV7j+fpwhnPgKAqu1R1AOnvwfDPUAX9jZSpomW/NJbXhc+YID4A==;31:aC83r+SUcfAsROVqPYH7yEfFBMbpAZ/mlBq/N+Zbjwsas5SIQzvxxH3QFhOQ1miXs0VP+DXyTd82Nf32pLXz36kxsTLpytCEUDzNYdgVFCKlKzDQ5VZSEReWwR7OEe4SPrCpQ6Pc+Z0t4It6rXpLRm36kti5ZFIiDxrNed2Bf1yNsUpxpvwqnMMJO1bJcS0XrmmNcMbJ2DbDHY8XwP57vrt4jVfTqRrp9x0HqNYva9I= X-MS-TrafficTypeDiagnostic: DM5PR1501MB2007: X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2007;20:7gOX9hGBf60TVdZ1eXYJqK6X+1z0UvrvzhhEEGQO06MkyY7gzHSzdHDgLtaVf7W1//GYg0lcGeFFRw08dKx9zG7GYS4v/29NOuiqwo9uzz1dM9LPRjffVzi5/0HrL/x+/FBEyVf56GzYbtKpsv2+8B0RCha1hXkG9FVAw0/SSKDU8nVgXNTO6uUZMrMuZLFNgq7fdrIi3y75BxZh2Ex4rHG8iey0Bgx5HZWQ19Lf5K7FUcKPEoMfmi+TRZ85cAZZ28raVbrlndZOX8cKJbFhIxT5mcWsiBTz7ohIN/TinOtcQ3/uteU3wjmWobUzf5QNIJygBGxWeUhcpR8SoyVlDLgvzYUFZReKyrxojuIN96j6zF+oSCOU+ssnUWgUq1dmuoIxAxvChc063Z5TyE3tQQrwovnVEBXyqwivguReEW9+iMC0oMrfnFtoRZC32rJ1ZUY8mKxG1oNDY2yrdPUm6+AFuvcvoxvj4LY50jMSZcEbX8k+jkurmo3OVCC2ysV4;4:UD9+66BcRR7e5848rgFy7miDcuhVQ+5vIhZA3LEbNBenSYxdKQTad4SNuV7hyRhFYxtTyyTKnAovT2xpO+WHb9fI+iUrlKV03eyl+FSVSFXtfMa7qBXwRJ7apsXVPBoceA2y84cHQM1CUvZR7V18i9hPP0xTsx2+sNvkzPLVE0cdDmxuMnxsVPvgJ6q1jGr7Lo6o83JpbJgTKC+17VAMCeSCipdT6xj8dcOEW6g3CVs04h3HZusBeZElMsvwnoMmWAwZPmuZw9Wr3kTt/44Q6Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:DM5PR1501MB2007;BCL:0;PCL:0;RULEID:;SRVR:DM5PR1501MB2007; X-Forefront-PRVS: 06339BAE63 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(39380400002)(376002)(396003)(366004)(346002)(377424004)(199004)(189003)(229853002)(26005)(558084003)(956004)(76176011)(53546011)(316002)(97736004)(77096007)(386003)(5660300001)(186003)(476003)(25786009)(6666003)(36756003)(2486003)(486006)(52146003)(16526019)(2616005)(16576012)(446003)(65826007)(23676004)(58126008)(11346002)(68736007)(7736002)(305945005)(65956001)(8676002)(64126003)(31696002)(8936002)(105586002)(31686004)(50466002)(6246003)(52116002)(6486002)(106356001)(81156014)(3846002)(6116002)(86362001)(81166006)(65806001)(2906002)(47776003)(53936002)(230700001)(66066001)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR1501MB2007;H:[10.0.0.110];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1MDFNQjIwMDc7MjM6QUEzbS90SWZ4eTRPRDBGRWpSR3d1bTA3?= =?utf-8?B?V3RMRGdHL1ZjNkh2NHNhOHlrVDduZkFZMkJlM1c0VkJwNTYxU21XZUVzREpH?= =?utf-8?B?R1BER2xjQzJwME05RDhkUmpLd0g3WjlpYXpQT2lDSXhENm8veEUxelVQWExm?= =?utf-8?B?QmNMTUh6MjBCbVJiOStzb3AxVzViSkYrUmdQVVY5Y3orT2owcjBVcFFZTExQ?= =?utf-8?B?LzdqR3NXclo2NllzUk9Sa2gwUm1teXdmTVBjQkIxcm00M3cyL1QvUERMRkN1?= =?utf-8?B?am8vY1p2ZkltUmtJRlo1TjdrdVhXaWpaUmdEUHJoa2NOb3Q3dEYzV2s2VHh3?= =?utf-8?B?TFkrcDdKai8vWXY2YTl4WFhQTjdENHJwUE4xRVNUVGtvNTF1UW9NVkFEWDBZ?= =?utf-8?B?S1laQ3VmQlZ5TncxMGJnZTdFWitTUVhvOTNFbXZ3NVJlMFpVQ2xINjFGUG95?= =?utf-8?B?aUZ0MUJOallPaFJ5TkM2b1FhSy9YZkZnT1B6OVllUUFkTFFQWDFaMnkxZ2JP?= =?utf-8?B?Ny80VU94Rnl2MGJwK3BtemhRVm1aRU1iRWJrbFE2QU9UWmI4eDVYY0daTlZ0?= =?utf-8?B?Qy9uc2VzTDl4aTJaQUtKdENHaTljb1hrcW5lR0RuMFY5SXFaWWlMWlZySTg3?= =?utf-8?B?TG1EeEkzZDRNS2NTTDZwbTNucmg0d1lrMVBwb3ZWS25yZ2RGWVE5dVBjYk5H?= =?utf-8?B?cEc4U25ucm80NDlZOW9Ta0Zpa3RJMThZVzVIQXk4c3R4K3hINjYwYk9pTkNL?= =?utf-8?B?aXVnU3ZnaFBoWmhmVFh4bldaRnN1dlNFdCsvZlhSWlk3UisxeCtxZk9TalV6?= =?utf-8?B?Zm13amFveDhVdG52OXhIZmxpQ0tLZXIvaVFSVWY5aEhmOFlSNk1DMFN3WGJ4?= =?utf-8?B?a1RTQkNYbmEwS2JlTjBFVGZmM1B2SktjVFhuaGNrbzJaT01aSmlCSXdSTXg0?= =?utf-8?B?VHE4MURPbkJiWEJhbDdYME11cGRmTGR3TURLNzl0b2MvVjlBbUhLR3BMbzIr?= =?utf-8?B?c1BBcXFScHZxU2crbWMyREZHc0U0SmJ0U0JXV1JmVjFQTy9UM2kvOWJLUFYz?= =?utf-8?B?Y3RrUE9idGdvK1VpV0VJNWM4Um4xWkx2Nmp4TmxzQWZEdm9jS2plbnN5Kzho?= =?utf-8?B?cTFvV1RxdXhnT1NmSk1mYVl6Tm13dVlMdTg5QmZBYnlvd0JFTlZYOUE1akRF?= =?utf-8?B?N3lIWllUWWt0bDBzb0ZSc2phVWpkS2FnZ3lxU2s3S0pSenVQK2FDZEcxbFdk?= =?utf-8?B?bFJzSUNUcDcvbTd5ak1wclBvUnMydG52NXg0eDlLYjBXWUhwRUMrc0NPY1NV?= =?utf-8?B?S0lwTS9vN29FWXJsNnF4NER0Q0lyM2NXZTBJVnNNbWNucDk2TUZGV2E1M09T?= =?utf-8?B?TWQvM21Pc1hWNE84bFJ4LzVpNVE1QU5zeFlqeDRQdkVEQjY4LzI1WUtGcW9R?= =?utf-8?B?Tk9NQWkwYlZCUkx3c2ZUZ2hmVFFPRmt3UzNNTHZCdHZRb05CRVZGa2w0Wkpo?= =?utf-8?B?b29IWXVTcGI1aFBQTWVCL3p0RHZIN0hteW45eFFJNHRISGR1OTgrMU5nQkx6?= =?utf-8?B?NEZQYzhYU3RKeU1ER3JuSW9EdDJudVVrUzFidkd4UFpyaFJBRkxiWm5tYkI3?= =?utf-8?B?c0tEdlByenY1Q2IrUFpDN1l4d1hLTENDbVZZUmtGWll0NUtpWktUbnJNS3Vo?= =?utf-8?B?UHg1cG4xN1c3dE4zL3l5YUNDblVoNjJYQ1RnWUtNYjVWd0M4U2ZSZmhBQ3pB?= =?utf-8?B?Mi9vOXhNWFhmNWZUaVZYVDNNL1VPNEY5Q2dGN1VJUkoyM3NSTUc4ZHFSUXFB?= =?utf-8?B?ZDlwcnBaTk9HOVcvUGZ4L0gxcUNJcWFaK0hjRXYydUlJRVhEbVdhRzBLeXJj?= =?utf-8?B?R2hLOWdDSzVoQ1hKbVcrRDVtL3hzdEhvVVdleWh6WWtRSzRPNzd1Zy9OZU04?= =?utf-8?B?YmVDUlE2MG5BNVE9PQ==?= X-Microsoft-Antispam-Message-Info: /+l1qRSCaYsiCwxMTNCgwZsaR0OAj4TfSDxsBUHVwLOS8JFzonG4u7s7w7oa7o+9WOtQX8KDbPxjNaW0Q7UjE9bje+DDZUiEweor9Ke1oZndxgmpYX6VVVSnmQBYnzt76U3oAciIUGmQuoF+A17W03axnU8sS4fUQMIBAV1Oa32q7lR776JRbmxQnocHd7oB X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2007;6:1Erx//6ducHMLx3BQgnSm6h3Bpj3KCYYvIPM6zz05ZFy+BT2+UgwtMyuG7z7a2LI3LGUYGId40ndZGcnLwwjB7ffT+dhCeUiVWbjbX+UyUzFlD4QV4zqvlUsgHcL4sbamVtXiYkP6Yp5KyCknmBtVJHV/0qsFmXPaf1MM4By654v70ZdbIhWQs46IC+Wwsw02N4dER6qV97v33Y8MFWxmUJYf1AMXcovdMgkmD4aXZpdbfIDZLdZ0RuEbZLPCnUhSH1GqiXPTxBmmT6wL+CfWQ9LEt11eETR8afGoyBwcJ+F//30euxPTe+KYvJh+L8Y+x3W0IsDaLJ117HSvYTSYsUgf60on8GLEpaHL+DW2Efdbs4mk0WQyt4ir0j02usUAgiLyNwCEnWk0dC+J2ZSpHsyRLDLGaFqRC8y0cSpcyWdptHN5lMyvaLfIJqQxmv6WKPY6of+VR4SjAv1VwnJLw==;5:hhQisl+M7JAzUST41A49gtC8I/lCwQ73wmco8RNjjR6d+E8d1lu7USRkZ/iBqBq8Zi05Xn9IGU3Rjm36YOm696n0oIlNSgTUOXBQMno38duABENMtjbtWlU2uOSkVvZu2LyZKerSa5fpBvPDAEl/q3mTBJJwoO2DUIpU+KxNSA0=;24:BLcPAvncuSY1J/24yMqLlo95tRE4p/ZzIe06rrKt8/9/y2Oh+Iv8rDyrEOr12D4OtTjYMrSkfKsElmd9bUGi/ErMEEHtXc+WCB6FtrrVjJ8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR1501MB2007;7:+ZCs7EE9F11MN5u8xiF2DfF7izlHO2O9NzRhRsjPrdfmlpkgLbkf+lMKz6bhiKrxVYSO65ytkCRDH+IoCSS3mCOLb86x9XhEAqT8V0Iwd/uBKHowgKbeRtcY4Fx/XIeqHzTyeIXjPwEurtE8KJhpXX2Hc2tLvqtfp4Kt86LWBBeDelmnSe8nddRCkEYo1TIOl/uWrG8zjS4Y8LKo8t5xnn7otrqBOSD4cYYEgGyRf5TKycusus2zyNjh4VA8PWFl X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2018 03:08:12.3508 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7cda6e59-9b11-4921-c295-08d59aa277aa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1501MB2007 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00073.txt.bz2 On 2018-04-04 12:40 AM, Tom Tromey wrote: > Here's the second version of the series to remove some cleanups from > linespec.c. > > I believe this version addresses all the review comments. > > Regression tested by the buildbot. > > Tom > I took a quick look again, LGTM. Thanks! Simon