From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id C2A813858D1E for ; Tue, 20 Jun 2023 15:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C2A813858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4QlrF34T3xz3GpF; Tue, 20 Jun 2023 15:30:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QlrF33lLFz3hRT; Tue, 20 Jun 2023 15:30:47 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687275047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z1H+o9jvOniQUyTALB83XVDyqrQX8Lew7r+7IznU+XY=; b=rb74mld+OBcbEsXAeAjTAiw/O6t3xmnVZzzvju5vPp3Ny1LheE/6/QoVgKudXX6aaEZAQA 5LtVKsIO+X73LUTeXxsyq3RxIANrH+9ysGPyukWwdyIkcdwHC4a+V+3gulfZRdkcteNjCu aaQQ5ZicfHkDb0Qi2Duyt4WiafT4+jhYu5BwYZzzwCSDC87IZzh3XoQSv697JFJwqSGzLl BM6+zUN5cku/3zVdPKuyecqr7H4lhgTGCkyJv2BgnOK6O3SJspmHQDOdTyru0FrNDyoV9i N4YcPB6aSP1xka01IlXh91KSsUURiBZfC/irwurt/UMJhIRtd0Gdc8+9DXo3tQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1687275047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z1H+o9jvOniQUyTALB83XVDyqrQX8Lew7r+7IznU+XY=; b=b6T0bA8EsAQ0ltgIlK5Fbj1YL1TP9RRFYY1XhjmYfPTos9NPZknSpC9cPwYgyhv6tludwN c2ltSUhDCotwuIVYLckUzvxrwLWBfT3KbsdBqsGSINoa2jFzbZjUxIoxUvWuhZZVxZzP1r fPUlGCBieQQh7X3Ci0g9zsY1YBPKiNdaq9YsEUCIxjIJuJUJ9zBSuJUvEjv1qTuMzsbMsH lpGLOeotINygGar0RSBn0uVZEcsRLHwNpJQLFN/Rb2QkfScXvzsHr7qTLo9XSFjsMZVE3r CVPvY5gdF4+WQALJ6gDrlCYqL31DJcpsE7KgHgAF63c33QM3kZAe7n9GQmxgvg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1687275047; a=rsa-sha256; cv=none; b=C1765wf+3Vj1pqrXDxelAIsDjr9T8qygH6BLxO9ckgtIzVpkEXLw7Lkf+lJGBOefKP5lWf NUTwJqDh/CgxEjJTj9rW6QiXPOL5MH0jpm6888FxrLeKuURd4dz/fRqil3N06sPJSyaras 8sxWmu26xO/BTlQm2fFFOrARFMBoTQC0NoJQwg+ZE1APjxBB9GdCpd68Z8vJynf4RXsE93 CugDZEcbvDGVZHvSt1aX6u+MzqytqzedOVEdazD+dYYtDBbM2SVlRa+CIwGzTJqB9RLnLj 84eHQn8Ms7fbVlxyU/sy/IujjdKQoaOvkaai1cbWuykgsKW7l1CNOAj4IYynLA== Received: from [IPV6:2601:648:8680:16b0:953a:c3a0:e269:2ef9] (unknown [IPv6:2601:648:8680:16b0:953a:c3a0:e269:2ef9]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QlrF30bP1z13ZT; Tue, 20 Jun 2023 15:30:46 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 20 Jun 2023 08:30:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20230619-ax-new-v1-0-b26175d997a9@tromey.com> <20230619-ax-new-v1-3-b26175d997a9@tromey.com> From: John Baldwin Subject: Re: [PATCH 3/6] Use std::vector for agent_expr::reg_mask In-Reply-To: <20230619-ax-new-v1-3-b26175d997a9@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/19/23 2:06 PM, Tom Tromey wrote: > agent_expr::reg_mask implements its own packed boolean vector. This > patch replaces it with a std::vector, simplifying the code. > --- > gdb/ax-general.c | 30 ++++++------------------------ > gdb/ax.h | 15 +++++---------- > gdb/tracepoint.c | 16 +++++----------- > 3 files changed, 16 insertions(+), 45 deletions(-) > > diff --git a/gdb/ax-general.c b/gdb/ax-general.c > index d5f4c51e65d..89e297eddc6 100644 > --- a/gdb/ax-general.c > +++ b/gdb/ax-general.c > @@ -330,8 +325,9 @@ ax_print (struct ui_file *f, struct agent_expr *x) > > gdb_printf (f, _("Scope: %s\n"), paddress (x->gdbarch, x->scope)); > gdb_printf (f, _("Reg mask:")); > - for (i = 0; i < x->reg_mask_len; ++i) > - gdb_printf (f, _(" %02x"), x->reg_mask[i]); > + for (i = 0; i < x->reg_mask.size (); ++i) > + if (x->reg_mask[i]) > + gdb_printf (f, _(" %02x"), i); > gdb_printf (f, _("\n")); This was previously printing the bytes of the raw bitmask so that the mask was printed in packed hex. Now it is printing each bit as a 2 character hex value (so you now end up with 01 01 00 00 00 01 00 00 instead of c4 for example). Re-synthesizing the packed hex output may not be useful, but perhaps you could print it as binary instead by only printing 0 or 1 for each bit without spaces (or maybe only spaces between each 8 bits?). Something like: for (i = 0; i < x->reg_mask.size (); ++i) { if (i % 8 == 0) gdb_printf(f, _(" ")); gdb_printf (f, _("%u"), x->reg_mask[i]); } -- John Baldwin