From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3788D3852742 for ; Thu, 20 Oct 2022 07:42:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3788D3852742 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-387-M-sK8RHXNFm1GiLagjp9RQ-1; Thu, 20 Oct 2022 03:42:54 -0400 X-MC-Unique: M-sK8RHXNFm1GiLagjp9RQ-1 Received: by mail-ej1-f69.google.com with SMTP id sa6-20020a1709076d0600b0078d84ed54b9so9091359ejc.18 for ; Thu, 20 Oct 2022 00:42:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ThXD+g+FEKqgI0jPXfNXgIPZddoDGp2UBEy1ngf/Mg8=; b=DHUQy8Rv9v9iARaQrIWmA7ETmDB/vpVJ9yiG6EZS73Uxt5vRG+tX1V8DKhWEGrl9Mi eP9D4qBoq2OZCX6RZ4+WiwQ5IDrXxllQ7TAs3+A9S+Mh/u7vIt4EcKOrBDA2H1fdBYHQ MxAm8EuAbyFs5qrtwdQn6KmbHNVfSELoxGqHEQRfkRbgSE7cbZFs/JUIA8axfsGsACKG Aqun3qdbQFwyogkcLKmy9ND9azRME4HXxd3o+FJ3373NmaJRxYWDo89crf8q7wCPyToK Arvn2oa1Xnb+RmXGFPgsRjcWXlWCvvAsoSJp7aS+fywhYUoJxiKE1zRyB63ubDH2sVMS k7Ww== X-Gm-Message-State: ACrzQf00nyQK3uzqvaulSUtpWHwCkt+m26lIbPhz39XflpmbhbvRwDI0 Ys8TiCDnxCr7qFpqyN5jFRlO3vUSxsXc3r+FOQ7anZc1AteVxf6+AArE4wwb2lU9/kBxwYOJOdE PVTsl6n0SwpUbAqGR9UCing== X-Received: by 2002:a17:907:1b24:b0:76d:7b9d:2f8b with SMTP id mp36-20020a1709071b2400b0076d7b9d2f8bmr9403871ejc.414.1666251773278; Thu, 20 Oct 2022 00:42:53 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7kZWXAyCpkz63XoVkv4Xz4C/gO1uNwpDW7F4NDkpPyDsQhRM/V9rwpuUdyqafZnfFaFdM+Xw== X-Received: by 2002:a17:907:1b24:b0:76d:7b9d:2f8b with SMTP id mp36-20020a1709071b2400b0076d7b9d2f8bmr9403860ejc.414.1666251773030; Thu, 20 Oct 2022 00:42:53 -0700 (PDT) Received: from [192.168.0.45] (ip-62-245-66-121.bb.vodafone.cz. [62.245.66.121]) by smtp.gmail.com with ESMTPSA id j18-20020a17090623f200b007417041fb2bsm9909539ejg.116.2022.10.20.00.42.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 00:42:52 -0700 (PDT) Message-ID: Date: Thu, 20 Oct 2022 09:42:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: [PING][PATCH v4 0/2] Fix reverse nexting over recursions To: Bruno Larsen , Bruno Larsen via Gdb-patches References: <20221005103832.3163424-1-blarsen@redhat.com> From: Bruno Larsen In-Reply-To: <20221005103832.3163424-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2022 07:42:57 -0000 ping! Cheers, Bruno On 05/10/2022 12:38, Bruno Larsen wrote: > This patch series fixes gdb record/16678, GDB being unable to > reverse-next over a recursive function. However, the simple way to fix > it hit a snag when I discovered that the amd64 epilogue unwinder would > give a different frame id than the dwarf2 unwinder would in the rest of > the function. This patch series first change this discrepancy, then > fixes the bug. > > Changelog for v4: > * more style fixes, thanks Pedro. > * Reworked part of the test, as it was not detecting failures > correctly. > > Changelog for v3: > * fix some comments on the amd64_epilogue_unwinder > * fix style for the step-reverse test > > Changelog for v2: > * Implemented Pedro Alves's suggestion to simplify the fix > * Added the first patch to fix a regression that the simple fix > would introduce. > > Bruno Larsen (2): > Change calculation of frame_id by amd64 epilogue unwinder > gdb/reverse: Fix stepping over recursive functions > > gdb/amd64-tdep.c | 10 +- > gdb/infrun.c | 2 +- > .../gdb.base/unwind-on-each-insn-foo.c | 22 +++ > gdb/testsuite/gdb.base/unwind-on-each-insn.c | 25 +++ > .../gdb.base/unwind-on-each-insn.exp | 154 ++++++++++++++++++ > gdb/testsuite/gdb.reverse/step-precsave.exp | 6 +- > gdb/testsuite/gdb.reverse/step-reverse.c | 19 ++- > gdb/testsuite/gdb.reverse/step-reverse.exp | 55 ++++++- > 8 files changed, 280 insertions(+), 13 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn-foo.c > create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.c > create mode 100644 gdb/testsuite/gdb.base/unwind-on-each-insn.exp >