From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 956373858402 for ; Wed, 4 Oct 2023 01:04:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 956373858402 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1696381470; bh=VzvQ8PDTXt53BAerhvapG/p7I5T29AAYnPP1O87K0CQ=; h=Date:Subject:To:References:From:In-Reply-To:From; b=AU13FDJOK63rRFb52k7r7xAX4qX27CyjTCMlNRUIDY4c+4yWwU2h4vU6eN4ZVEjLf UxUc6PJHybm6riB4JhiRHjrJOycF8atkVnzAWH0s89V8kyhqBjOHolEZoQ76Mg7gbA jabTOYJZei5Rs16pxI1rWfzs1CAZmbMxWWJzOme0= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 469691E092; Tue, 3 Oct 2023 21:04:30 -0400 (EDT) Message-ID: Date: Tue, 3 Oct 2023 21:04:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/testsuite: Bump up 'match_max' Content-Language: en-US To: Thiago Jung Bauermann , gdb-patches@sourceware.org References: <20231003195338.334948-1-thiago.bauermann@linaro.org> From: Simon Marchi In-Reply-To: <20231003195338.334948-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-03 15:53, Thiago Jung Bauermann via Gdb-patches wrote: > This fixes "ERROR: internal buffer is full." in gdb.base/maint.exp when > running with "make check-read1". > > Also take the opportunity to fix stray whitespace in the vicinity. > --- > gdb/testsuite/lib/gdb.exp | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index de22da8d8a8c..c6ee4628f8f5 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -6533,13 +6533,14 @@ proc default_gdb_init { test_file_name } { > if { $gdb_wrapper_target != [current_target_name] } { > set gdb_wrapper_initialized 0 > } > - > + > # Unlike most tests, we have a small number of tests that generate > # a very large amount of output. We therefore increase the expect > # buffer size to be able to contain the entire test output. This > - # is especially needed by gdb.base/info-macros.exp. > - match_max -d 65536 > - # Also set this value for the currently running GDB. > + # is especially needed by gdb.base/info-macros.exp and > + # gdb.base/maint.exp. > + match_max -d 196608 > + # Also set this value for the currently running GDB. > match_max [match_max -d] > > # We want to add the name of the TCL testcase to the PASS/FAIL messages. Do you have details about what fails specifically? It runs fine here, so I'm curious which part of the test fills the buffer exactly. Also, my understanding is that check-read1 should have no effect on this, it shouldn't fill the buffer more than a regular "make check". It only makes it such that read system calls return at most 1 byte. Simon